PolarFire SoC dt for 5.19
Subsystems (3)
Conor Dooley
maintainerv5 cover PolarFire SoC dt for 5.19
Hey all,
Got a few PolarFire SoC device tree related changes here for 5.19.
Firstly, patches 1 & 2 of this series supersede [0] & are unchanged compared to that submission, figured it would just be easier to keep all the changes in one series.
As discussed on irc, patch 3 removes the duplicated "microchip" from the device tree files so that they follow a soc-board.dts & a soc{,-fabric}.dtsi format.
Patch 5 makes the fabric dtsi board specific by renaming the file to mpfs-icicle-kit-fabric.dtsi & including it in the dts rather than mpfs.dtsi. Additionally this will allow other boards to define their own reference fabric design. A revision specific compatible, added in patch 4, is added to the dt also.
The remainder of the series adds a bare minimum devicetree for the Sundance Polarberry.
Thanks,
Conor.
Changes since v4:
- Whitespace and status ordering changes in the polarberry dt pointed out by Heiko
- A new patch for same whitspace and status order changes, but applied to the icicle dt
- A reordering of the icicle dt alphabetically to match the formatting of the polarberry dt
Changes since v3:
- remove an extra line of wshitespace added to dt-binding
- remove unneeded "okay" status & sort status to node end
- sort polarberry dts entries in ~alphabetical order
- add a comment explaining why the second mac (mac0) is disabled on polarberry
Changes since v2:
- make ,icicle-reference compatible with ,mpfs & put it inside the enum
Changes since v1:
- fixed whitespace problems in the polarberry dts
- disabled mac0 for the polarberry as its port is on the optional carrier board
Conor Dooley (10):
riscv: dts: microchip: remove icicle memory clocks
riscv: dts: microchip: move sysctrlr out of soc bus
riscv: dts: microchip: remove soc vendor from filenames
dt-bindings: riscv: microchip: document icicle reference design
riscv: dts: microchip: make the fabric dtsi board specific
dt-bindings: vendor-prefixes: add Sundance DSP
dt-bindings: riscv: microchip: add polarberry compatible string
riscv: dts: microchip: add the sundance polarberry
riscv: microchip: icicle: readability fixes
riscv: dts: icicle: sort nodes alphabetically
.../devicetree/bindings/riscv/microchip.yaml | 2 +
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
arch/riscv/boot/dts/microchip/Makefile | 3 +-
...abric.dtsi => mpfs-icicle-kit-fabric.dtsi} | 2 +
...pfs-icicle-kit.dts => mpfs-icicle-kit.dts} | 105 +++++++++---------
.../dts/microchip/mpfs-polarberry-fabric.dtsi | 16 +++
.../boot/dts/microchip/mpfs-polarberry.dts | 99 +++++++++++++++++
.../{microchip-mpfs.dtsi => mpfs.dtsi} | 11 +-
8 files changed, 181 insertions(+), 59 deletions(-)
rename arch/riscv/boot/dts/microchip/{microchip-mpfs-fabric.dtsi => mpfs-icicle-kit-fabric.dtsi} (91%)
rename arch/riscv/boot/dts/microchip/{microchip-mpfs-icicle-kit.dts => mpfs-icicle-kit.dts} (95%)
create mode 100644 arch/riscv/boot/dts/microchip/mpfs-polarberry-fabric.dtsi
create mode 100644 arch/riscv/boot/dts/microchip/mpfs-polarberry.dts
rename arch/riscv/boot/dts/microchip/{microchip-mpfs.dtsi => mpfs.dtsi} (98%)Signature · 1 line
2.35.2
Conor Dooley
maintainerPATCH v5 1/10 riscv: dts: microchip: remove icicle memory clocks
The clock properties in the icicle kit's memory entries cause dtbs_check
errors:arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dtb: /: memory@80000000: 'clocks' does not match any of the regexes: 'pinctrl-[0-9]+'
Get rid of the clocks to avoid the errors.
--- arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts | 2 -- 1 file changed, 2 deletions(-)
arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts +0 -2
@@ -32,14 +32,12 @@ cpus { ddrc_cache_lo: memory@80000000 { device_type = "memory"; reg = <0x0 0x80000000 0x0 0x2e000000>; - clocks = <&clkcfg CLK_DDRC>; status = "okay"; }; ddrc_cache_hi: memory@1000000000 { device_type = "memory"; reg = <0x10 0x0 0x0 0x40000000>; - clocks = <&clkcfg CLK_DDRC>; status = "okay"; }; };
Signature · 1 line
2.35.2
Conor Dooley
maintainerPATCH v5 2/10 riscv: dts: microchip: move sysctrlr out of soc bus
In reply to Conor DooleyThe MPFS system controller has no registers of its own, so move it out
of the soc node to avoid dtbs_check warnings:arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dtb: soc: syscontroller: {'compatible': ['microchip,mpfs-sys-controller'], 'mboxes': [[15, 0]], 'status': ['okay']} should not be valid under {'type': 'object'}
--- arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +5 -5
@@ -146,6 +146,11 @@ refclk: mssrefclk { #clock-cells = <0>; }; + syscontroller: syscontroller { + compatible = "microchip,mpfs-sys-controller"; + mboxes = <&mbox 0>; + }; + soc { #address-cells = <2>; #size-cells = <2>;
@@ -446,10 +451,5 @@ mbox: mailbox@37020000 { #mbox-cells = <1>; status = "disabled"; }; - - syscontroller: syscontroller { - compatible = "microchip,mpfs-sys-controller"; - mboxes = <&mbox 0>; - }; }; };
Signature · 1 line
2.35.2
Conor Dooley
maintainerPATCH v5 3/10 riscv: dts: microchip: remove soc vendor from filenames
In reply to Conor DooleyHaving the SoC vendor both as the directory and in the filename adds little. Remove microchip from the filenames so that the files will resemble the other directories in riscv (and arm64). The new names follow a soc-board.dts & soc{,-fabric}.dtsi pattern.
---
arch/riscv/boot/dts/microchip/Makefile | 2 +-
.../microchip/{microchip-mpfs-fabric.dtsi => mpfs-fabric.dtsi} | 0
.../{microchip-mpfs-icicle-kit.dts => mpfs-icicle-kit.dts} | 2 +-
.../riscv/boot/dts/microchip/{microchip-mpfs.dtsi => mpfs.dtsi} | 2 +-
4 files changed, 3 insertions(+), 3 deletions(-)
rename arch/riscv/boot/dts/microchip/{microchip-mpfs-fabric.dtsi => mpfs-fabric.dtsi} (100%)
rename arch/riscv/boot/dts/microchip/{microchip-mpfs-icicle-kit.dts => mpfs-icicle-kit.dts} (98%)
rename arch/riscv/boot/dts/microchip/{microchip-mpfs.dtsi => mpfs.dtsi} (99%)arch/riscv/boot/dts/microchip/Makefile +1 -1
@@ -1,3 +1,3 @@ # SPDX-License-Identifier: GPL-2.0 -dtb-$(CONFIG_SOC_MICROCHIP_POLARFIRE) += microchip-mpfs-icicle-kit.dtb +dtb-$(CONFIG_SOC_MICROCHIP_POLARFIRE) += mpfs-icicle-kit.dtb obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .o, $(dtb-y))
arch/riscv/boot/dts/microchip/mpfs-fabric.dtsi renamed from arch/riscv/boot/dts/microchip/microchip-mpfs-fabric.dtsi +0 -0
arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts renamed from arch/riscv/boot/dts/microchip/microchip-mpfs-icicle-kit.dts +1 -1
@@ -3,7 +3,7 @@ /dts-v1/; -#include "microchip-mpfs.dtsi" +#include "mpfs.dtsi" /* Clock frequency (in Hz) of the rtcclk */ #define RTCCLK_FREQ 1000000
arch/riscv/boot/dts/microchip/mpfs.dtsi renamed from arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi +1 -1
@@ -3,7 +3,7 @@ /dts-v1/; #include "dt-bindings/clock/microchip,mpfs-clock.h" -#include "microchip-mpfs-fabric.dtsi" +#include "mpfs-fabric.dtsi" / { #address-cells = <2>;
Signature · 7 lines
2.35.2 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Conor Dooley
maintainerPATCH v5 4/10 dt-bindings: riscv: microchip: document icicle reference design
In reply to Conor DooleyAdd a compatible for the icicle kit's reference design. This represents the FPGA fabric's contents & is versioned to denote which release of the reference design it applies to.
--- Documentation/devicetree/bindings/riscv/microchip.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/riscv/microchip.yaml +1 -0
@@ -20,6 +20,7 @@ properties: items: - enum: - microchip,mpfs-icicle-kit + - microchip,mpfs-icicle-reference-rtlv2203 - const: microchip,mpfs additionalProperties: true
Signature · 7 lines
2.35.2 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v5 04/10] dt-bindings: riscv: microchip: document icicle reference design
Quoted 10 lines · Conor Dooley
Add a compatible for the icicle kit's reference design. This represents the FPGA fabric's contents & is versioned to denote which release of the reference design it applies to.
Signed-off-by Conor Dooley <[email protected]>--- Documentation/devicetree/bindings/riscv/microchip.yaml | 1 + 1 file changed, 1 insertion(+)
Conor Dooley
maintainerPATCH v5 5/10 riscv: dts: microchip: make the fabric dtsi board specific
In reply to Conor DooleyCurrently mpfs-fabric.dtsi is included by mpfs.dtsi - which is fine currently since there is only one board with this SoC upstream.
However if another board was added, it would include the fabric contents of the Icicle Kit's reference design. To avoid this, rename mpfs-fabric.dtsi to mpfs-icicle-kit-fabric.dtsi & include it in the dts rather than mpfs.dtsi.
mpfs-icicle-kit-fabric.dtsi specifically matches the 22.03 reference design for the icicle kit's FPGA fabric & an older version of the design may not have the i2c or pwm devices - so add the compatible string to document this.
---
.../microchip/{mpfs-fabric.dtsi => mpfs-icicle-kit-fabric.dtsi} | 2 ++
arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts | 1 +
arch/riscv/boot/dts/microchip/mpfs.dtsi | 1 -
3 files changed, 3 insertions(+), 1 deletion(-)
rename arch/riscv/boot/dts/microchip/{mpfs-fabric.dtsi => mpfs-icicle-kit-fabric.dtsi} (91%)arch/riscv/boot/dts/microchip/mpfs-icicle-kit-fabric.dtsi renamed from arch/riscv/boot/dts/microchip/mpfs-fabric.dtsi +2 -0
@@ -2,6 +2,8 @@ /* Copyright (c) 2020-2021 Microchip Technology Inc */ / { + compatible = "microchip,mpfs-icicle-reference-rtlv2203", "microchip,mpfs"; + core_pwm0: pwm@41000000 { compatible = "microchip,corepwm-rtl-v4"; reg = <0x0 0x41000000 0x0 0xF0>;
arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts +1 -0
@@ -4,6 +4,7 @@ /dts-v1/; #include "mpfs.dtsi" +#include "mpfs-icicle-kit-fabric.dtsi" /* Clock frequency (in Hz) of the rtcclk */ #define RTCCLK_FREQ 1000000
arch/riscv/boot/dts/microchip/mpfs.dtsi +0 -1
@@ -3,7 +3,6 @@ /dts-v1/; #include "dt-bindings/clock/microchip,mpfs-clock.h" -#include "mpfs-fabric.dtsi" / { #address-cells = <2>;
Signature · 7 lines
2.35.2 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Conor Dooley
maintainerPATCH v5 6/10 dt-bindings: vendor-prefixes: add Sundance DSP
In reply to Conor DooleySundance DSP Inc. (https://www.sundancedsp.com/) is a supplier of high-performance DSP and FPGA processor boards and I/O modules.
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -1197,6 +1197,8 @@ patternProperties: description: Summit microelectronics "^sunchip,.*": description: Shenzhen Sunchip Technology Co., Ltd + "^sundance,.*": + description: Sundance DSP Inc. "^sunplus,.*": description: Sunplus Technology Co., Ltd. "^SUNW,.*":
Signature · 7 lines
2.35.2 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Conor Dooley
maintainerPATCH v5 7/10 dt-bindings: riscv: microchip: add polarberry compatible string
In reply to Conor DooleyAdd a binding for the Sundance Polarberry board.
--- Documentation/devicetree/bindings/riscv/microchip.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/riscv/microchip.yaml +1 -0
@@ -21,6 +21,7 @@ properties: - enum: - microchip,mpfs-icicle-kit - microchip,mpfs-icicle-reference-rtlv2203 + - sundance,polarberry - const: microchip,mpfs additionalProperties: true
Signature · 7 lines
2.35.2 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Conor Dooley
maintainerPATCH v5 8/10 riscv: dts: microchip: add the sundance polarberry
In reply to Conor DooleyAdd a minimal device tree for the PolarFire SoC based Sundance PolarBerry.
--- arch/riscv/boot/dts/microchip/Makefile | 1 + .../dts/microchip/mpfs-polarberry-fabric.dtsi | 16 +++ .../boot/dts/microchip/mpfs-polarberry.dts | 99 +++++++++++++++++++ 3 files changed, 116 insertions(+) create mode 100644 arch/riscv/boot/dts/microchip/mpfs-polarberry-fabric.dtsi create mode 100644 arch/riscv/boot/dts/microchip/mpfs-polarberry.dts
arch/riscv/boot/dts/microchip/Makefile +1 -0
@@ -1,3 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 dtb-$(CONFIG_SOC_MICROCHIP_POLARFIRE) += mpfs-icicle-kit.dtb +dtb-$(CONFIG_SOC_MICROCHIP_POLARFIRE) += mpfs-polarberry.dtb obj-$(CONFIG_BUILTIN_DTB) += $(addsuffix .o, $(dtb-y))
arch/riscv/boot/dts/microchip/mpfs-polarberry-fabric.dtsi new file +16 -0
@@ -0,0 +1,16 @@ +// SPDX-License-Identifier: (GPL-2.0 OR MIT) +/* Copyright (c) 2020-2022 Microchip Technology Inc */ + +/ { + fabric_clk3: fabric-clk3 { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <62500000>; + }; + + fabric_clk1: fabric-clk1 { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <125000000>; + }; +};
arch/riscv/boot/dts/microchip/mpfs-polarberry.dts new file +99 -0
99 lines not on this page · raw message
Signature · 7 lines
2.35.2 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Conor Dooley
maintainerPATCH v5 9/10 riscv: microchip: icicle: readability fixes
In reply to Conor DooleyFix the sort order of the status properties, remove some extra whitespace in the mmc entry & add whitespace to the mac entry containing the phys so that the dt is easier to read.
--- arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts +5 -3
@@ -64,8 +64,6 @@ &mmuart4 { }; &mmc { - status = "okay"; - bus-width = <4>; disable-wp; cap-sd-highspeed;
@@ -77,6 +75,7 @@ &mmc { sd-uhs-sdr25; sd-uhs-sdr50; sd-uhs-sdr104; + status = "okay"; }; &spi0 {
@@ -106,16 +105,19 @@ &i2c2 { &mac0 { phy-mode = "sgmii"; phy-handle = <&phy0>; + status = "okay"; }; &mac1 { - status = "okay"; phy-mode = "sgmii"; phy-handle = <&phy1>; + status = "okay"; + phy1: ethernet-phy@9 { reg = <9>; ti,fifo-depth = <0x1>; }; + phy0: ethernet-phy@8 { reg = <8>; ti,fifo-depth = <0x1>;
Signature · 7 lines
2.35.2 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v5 09/10] riscv: microchip: icicle: readability fixes
Am Montag, 9. Mai 2022, 16:26:10 CEST schrieb Conor Dooley:
Quoted 5 lines
Fix the sort order of the status properties, remove some extra whitespace in the mmc entry & add whitespace to the mac entry containing the phys so that the dt is easier to read.
Signed-off-by Conor Dooley <[email protected]>
Conor Dooley
maintainerPATCH v5 10/10 riscv: dts: icicle: sort nodes alphabetically
In reply to Conor DooleyThe icicle device tree is in a "random" order, so clean it up and sort its elements alphabetically to match the newly added PolarBerry dts.
--- .../boot/dts/microchip/mpfs-icicle-kit.dts | 104 +++++++++--------- 1 file changed, 52 insertions(+), 52 deletions(-)
arch/riscv/boot/dts/microchip/mpfs-icicle-kit.dts +52 -52
@@ -43,23 +43,57 @@ ddrc_cache_hi: memory@1000000000 { }; }; -&refclk { - clock-frequency = <125000000>; +&core_pwm0 { + status = "okay"; }; -&mmuart1 { +&gpio2 { + interrupts = <53>, <53>, <53>, <53>, + <53>, <53>, <53>, <53>, + <53>, <53>, <53>, <53>, + <53>, <53>, <53>, <53>, + <53>, <53>, <53>, <53>, + <53>, <53>, <53>, <53>, + <53>, <53>, <53>, <53>, + <53>, <53>, <53>, <53>; status = "okay"; }; -&mmuart2 { +&i2c0 { status = "okay"; }; -&mmuart3 { +&i2c1 { status = "okay"; }; -&mmuart4 { +&i2c2 { + status = "okay"; +}; + +&mac0 { + phy-mode = "sgmii"; + phy-handle = <&phy0>; + status = "okay"; +}; + +&mac1 { + phy-mode = "sgmii"; + phy-handle = <&phy1>; + status = "okay"; + + phy1: ethernet-phy@9 { + reg = <9>; + ti,fifo-depth = <0x1>; + }; + + phy0: ethernet-phy@8 { + reg = <8>; + ti,fifo-depth = <0x1>; + }; +}; + +&mbox { status = "okay"; };
@@ -78,74 +112,43 @@ &mmc { status = "okay"; }; -&spi0 { - status = "okay"; -}; - -&spi1 { - status = "okay"; -}; - -&qspi { +&mmuart1 { status = "okay"; }; -&i2c0 { +&mmuart2 { status = "okay"; }; -&i2c1 { +&mmuart3 { status = "okay"; }; -&i2c2 { +&mmuart4 { status = "okay"; }; -&mac0 { - phy-mode = "sgmii"; - phy-handle = <&phy0>; +&pcie { status = "okay"; }; -&mac1 { - phy-mode = "sgmii"; - phy-handle = <&phy1>; +&qspi { status = "okay"; - - phy1: ethernet-phy@9 { - reg = <9>; - ti,fifo-depth = <0x1>; - }; - - phy0: ethernet-phy@8 { - reg = <8>; - ti,fifo-depth = <0x1>; - }; }; -&gpio2 { - interrupts = <53>, <53>, <53>, <53>, - <53>, <53>, <53>, <53>, - <53>, <53>, <53>, <53>, - <53>, <53>, <53>, <53>, - <53>, <53>, <53>, <53>, - <53>, <53>, <53>, <53>, - <53>, <53>, <53>, <53>, - <53>, <53>, <53>, <53>; - status = "okay"; +&refclk { + clock-frequency = <125000000>; }; &rtc { status = "okay"; }; -&usb { +&spi0 { status = "okay"; - dr_mode = "host"; }; -&mbox { +&spi1 { status = "okay"; };
@@ -153,10 +156,7 @@ &syscontroller { status = "okay"; }; -&pcie { - status = "okay"; -}; - -&core_pwm0 { +&usb { status = "okay"; + dr_mode = "host"; };
Signature · 7 lines
2.35.2 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v5 10/10] riscv: dts: icicle: sort nodes alphabetically
Am Montag, 9. Mai 2022, 16:26:11 CEST schrieb Conor Dooley:
Quoted 4 lines
The icicle device tree is in a "random" order, so clean it up and sort its elements alphabetically to match the newly added PolarBerry dts.
Signed-off-by Conor Dooley <[email protected]>
[email protected]
maintainerQuoted 2 lines · Conor Dooley
Hey all,
Got a few PolarFire SoC device tree related changes here for 5.19.
Hey Palmer,
I know you're busy etc but I had been hoping you'd take this for 5.19. I know it's late, so nw if it's too late. Thanks,
Conor.
Quoted 71 lines
Firstly, patches 1 & 2 of this series supersede [0] & are unchanged compared to that submission, figured it would just be easier to keep all the changes in one series.
As discussed on irc, patch 3 removes the duplicated "microchip" from the device tree files so that they follow a
soc-board.dts& a soc{,-fabric}.dtsi format.Patch 5 makes the fabric dtsi board specific by renaming the file to
mpfs-icicle-kit-fabric.dtsi& including it in the dts rather thanmpfs.dtsi. Additionally this will allow other boards to define their own reference fabric design. A revision specific compatible, added in patch 4, is added to the dt also.The remainder of the series adds a bare minimum devicetree for the Sundance Polarberry.
Thanks,
Conor.Changes since v4:
- Whitespace and status ordering changes in the polarberry dt pointed out by Heiko
- A new patch for same whitspace and status order changes, but applied to the icicle dt
- A reordering of the icicle dt alphabetically to match the formatting of the polarberry dtChanges since v3:
- remove an extra line of wshitespace added to dt-binding
- remove unneeded "okay" status & sort status to node end
- sort polarberry dts entries in ~alphabetical order
- add a comment explaining why the second mac (mac0) is disabled on polarberryChanges since v2:
- make ,icicle-reference compatible with ,mpfs & put it inside the enumChanges since v1:
- fixed whitespace problems in the polarberry dts
- disabled mac0 for the polarberry as its port is on the optional carrier boardConor Dooley (10):
riscv: dts: microchip: remove icicle memory clocks
riscv: dts: microchip: move sysctrlr out of soc bus
riscv: dts: microchip: remove soc vendor from filenames
dt-bindings: riscv: microchip: document icicle reference design
riscv: dts: microchip: make the fabric dtsi board specific
dt-bindings: vendor-prefixes: add Sundance DSP
dt-bindings: riscv: microchip: add polarberry compatible string
riscv: dts: microchip: add the sundance polarberry
riscv: microchip: icicle: readability fixes
riscv: dts: icicle: sort nodes alphabetically.../devicetree/bindings/riscv/microchip.yaml | 2 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/riscv/boot/dts/microchip/Makefile | 3 +- ...abric.dtsi => mpfs-icicle-kit-fabric.dtsi} | 2 + ...pfs-icicle-kit.dts => mpfs-icicle-kit.dts} | 105 +++++++++--------- .../dts/microchip/mpfs-polarberry-fabric.dtsi | 16 +++ .../boot/dts/microchip/mpfs-polarberry.dts | 99 +++++++++++++++++ .../{microchip-mpfs.dtsi => mpfs.dtsi} | 11 +- 8 files changed, 181 insertions(+), 59 deletions(-)rename
arch/riscv/boot/dts/microchip/{microchip-mpfs-fabric.dtsi=>mpfs-icicle-kit-fabric.dtsi} (91%) renamearch/riscv/boot/dts/microchip/{microchip-mpfs-icicle-kit.dts=>mpfs-icicle-kit.dts} (95%) create mode 100644arch/riscv/boot/dts/microchip/mpfs-polarberry-fabric.dtsi
create mode 100644arch/riscv/boot/dts/microchip/mpfs-polarberry.dts
renamearch/riscv/boot/dts/microchip/{microchip-mpfs.dtsi=>mpfs.dtsi} (98%)
Palmer Dabbelt
maintainerQuoted 7 lines · On Mon, 23 May 2022 04:47:55 PDT (-0700), [email protected] wrote:
Quoted 2 lines · Conor Dooley
Hey all,
Got a few PolarFire SoC device tree related changes here for 5.19.Hey Palmer,
I know you're busy etc but I had been hoping you'd take this for 5.19. I know it's late, so nw if it's too late.
It wasn't too late for me, this is on for-next. Thanks!
Quoted 75 lines
Thanks,
Conor.Quoted 71 lines
Firstly, patches 1 & 2 of this series supersede [0] & are unchanged compared to that submission, figured it would just be easier to keep all the changes in one series.
As discussed on irc, patch 3 removes the duplicated "microchip" from the device tree files so that they follow a
soc-board.dts& a soc{,-fabric}.dtsi format.Patch 5 makes the fabric dtsi board specific by renaming the file to
mpfs-icicle-kit-fabric.dtsi& including it in the dts rather thanmpfs.dtsi. Additionally this will allow other boards to define their own reference fabric design. A revision specific compatible, added in patch 4, is added to the dt also.The remainder of the series adds a bare minimum devicetree for the Sundance Polarberry.
Thanks,
Conor.Changes since v4:
- Whitespace and status ordering changes in the polarberry dt pointed out by Heiko
- A new patch for same whitspace and status order changes, but applied to the icicle dt
- A reordering of the icicle dt alphabetically to match the formatting of the polarberry dtChanges since v3:
- remove an extra line of wshitespace added to dt-binding
- remove unneeded "okay" status & sort status to node end
- sort polarberry dts entries in ~alphabetical order
- add a comment explaining why the second mac (mac0) is disabled on polarberryChanges since v2:
- make ,icicle-reference compatible with ,mpfs & put it inside the enumChanges since v1:
- fixed whitespace problems in the polarberry dts
- disabled mac0 for the polarberry as its port is on the optional carrier boardConor Dooley (10):
riscv: dts: microchip: remove icicle memory clocks
riscv: dts: microchip: move sysctrlr out of soc bus
riscv: dts: microchip: remove soc vendor from filenames
dt-bindings: riscv: microchip: document icicle reference design
riscv: dts: microchip: make the fabric dtsi board specific
dt-bindings: vendor-prefixes: add Sundance DSP
dt-bindings: riscv: microchip: add polarberry compatible string
riscv: dts: microchip: add the sundance polarberry
riscv: microchip: icicle: readability fixes
riscv: dts: icicle: sort nodes alphabetically.../devicetree/bindings/riscv/microchip.yaml | 2 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/riscv/boot/dts/microchip/Makefile | 3 +- ...abric.dtsi => mpfs-icicle-kit-fabric.dtsi} | 2 + ...pfs-icicle-kit.dts => mpfs-icicle-kit.dts} | 105 +++++++++--------- .../dts/microchip/mpfs-polarberry-fabric.dtsi | 16 +++ .../boot/dts/microchip/mpfs-polarberry.dts | 99 +++++++++++++++++ .../{microchip-mpfs.dtsi => mpfs.dtsi} | 11 +- 8 files changed, 181 insertions(+), 59 deletions(-)rename
arch/riscv/boot/dts/microchip/{microchip-mpfs-fabric.dtsi=>mpfs-icicle-kit-fabric.dtsi} (91%) renamearch/riscv/boot/dts/microchip/{microchip-mpfs-icicle-kit.dts=>mpfs-icicle-kit.dts} (95%) create mode 100644arch/riscv/boot/dts/microchip/mpfs-polarberry-fabric.dtsi
create mode 100644arch/riscv/boot/dts/microchip/mpfs-polarberry.dts
renamearch/riscv/boot/dts/microchip/{microchip-mpfs.dtsi=>mpfs.dtsi} (98%)
[email protected]
maintainerQuoted 4 lines · Palmer Dabbelt
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Quoted 1 line · On Mon, 23 May 2022 04:47:55 PDT (-0700), [email protected] wrote:
On 09/05/2022 15:26, Conor Dooley wrote:
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
Hey all,
Got a few PolarFire SoC device tree related changes here for 5.19.Hey Palmer,
I know you're busy etc but I had been hoping you'd take this for 5.19. I know it's late, so nw if it's too late.It wasn't too late for me, this is on for-next. Thanks!
Thanks
Quoted 76 lines
Quoted 76 lines
Thanks,
Conor.Quoted 71 lines
Firstly, patches 1 & 2 of this series supersede [0] & are unchanged compared to that submission, figured it would just be easier to keep all the changes in one series.
As discussed on irc, patch 3 removes the duplicated "microchip" from the device tree files so that they follow a
soc-board.dts& a soc{,-fabric}.dtsi format.Patch 5 makes the fabric dtsi board specific by renaming the file to
mpfs-icicle-kit-fabric.dtsi& including it in the dts rather thanmpfs.dtsi. Additionally this will allow other boards to define their own reference fabric design. A revision specific compatible, added in patch 4, is added to the dt also.The remainder of the series adds a bare minimum devicetree for the Sundance Polarberry.
Thanks,
Conor.Changes since v4:
- Whitespace and status ordering changes in the polarberry dt pointed out by Heiko
- A new patch for same whitspace and status order changes, but applied to the icicle dt
- A reordering of the icicle dt alphabetically to match the formatting of the polarberry dtChanges since v3:
- remove an extra line of wshitespace added to dt-binding
- remove unneeded "okay" status & sort status to node end
- sort polarberry dts entries in ~alphabetical order
- add a comment explaining why the second mac (mac0) is disabled on polarberryChanges since v2:
- make ,icicle-reference compatible with ,mpfs & put it inside the enumChanges since v1:
- fixed whitespace problems in the polarberry dts
- disabled mac0 for the polarberry as its port is on the optional carrier boardConor Dooley (10):
riscv: dts: microchip: remove icicle memory clocks
riscv: dts: microchip: move sysctrlr out of soc bus
riscv: dts: microchip: remove soc vendor from filenames
dt-bindings: riscv: microchip: document icicle reference design
riscv: dts: microchip: make the fabric dtsi board specific
dt-bindings: vendor-prefixes: add Sundance DSP
dt-bindings: riscv: microchip: add polarberry compatible string
riscv: dts: microchip: add the sundance polarberry
riscv: microchip: icicle: readability fixes
riscv: dts: icicle: sort nodes alphabetically.../devicetree/bindings/riscv/microchip.yaml | 2 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/riscv/boot/dts/microchip/Makefile | 3 +-
...abric.dtsi => mpfs-icicle-kit-fabric.dtsi} | 2 + ...pfs-icicle-kit.dts => mpfs-icicle-kit.dts} | 105 +++++++++--------- .../dts/microchip/mpfs-polarberry-fabric.dtsi | 16 +++ .../boot/dts/microchip/mpfs-polarberry.dts | 99 +++++++++++++++++ .../{microchip-mpfs.dtsi => mpfs.dtsi} | 11 +- 8 files changed, 181 insertions(+), 59 deletions(-)rename
arch/riscv/boot/dts/microchip/{microchip-mpfs-fabric.dtsi=>mpfs-icicle-kit-fabric.dtsi} (91%) renamearch/riscv/boot/dts/microchip/{microchip-mpfs-icicle-kit.dts=>mpfs-icicle-kit.dts} (95%) create mode 100644arch/riscv/boot/dts/microchip/mpfs-polarberry-fabric.dtsi
create mode 100644arch/riscv/boot/dts/microchip/mpfs-polarberry.dts
renamearch/riscv/boot/dts/microchip/{microchip-mpfs.dtsi=>mpfs.dtsi} (98%)