Skip to contentSkip to conversation

drm/amdgpu/vcn: fixed no previous prototype warning.

PATCH In review James Zhu 4 participants 6 messages May 8, 2022 – May 9, 2022

Subsystems (2)
lore
Share & tools
lore

James Zhu

author
#0 lore raw

PATCH 1/1 drm/amdgpu/vcn: fixed no previous prototype warning.

Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'

---
 drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c +2 -1
index 08fd61622f95..1ceda3d0cd5b 100644
@@ -21,7 +21,8 @@
  *
  */
 
-#include "amdgpu_vcn.h"
+#include "amdgpu.h"
+#include "vcn_sw_ring.h"
 
 void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
 	u64 seq, uint32_t flags)
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 1/1 drm/amdgpu/vcn: fixed no previous prototype warning.

Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'

---
 drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c +1 -0
index f4f97f0f5c64..1ceda3d0cd5b 100644
@@ -22,6 +22,7 @@
  */
 
 #include "amdgpu.h"
+#include "vcn_sw_ring.h"
 
 void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
 	u64 seq, uint32_t flags)
Signature · 1 line
2.25.1
#2 lore raw

Dear James,

You sent this message 30 minutes after sending the same message before (Message-ID: <[email protected]>). Are there any differences?

Am 08.05.22 um 20:00 schrieb James Zhu:

Quoted 1 line

Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'

Please use imperative mood in the commit message summary. Maybe even:

Quoted 1 line

Include header for vcn_dec_sw_ring_emit_fence()

Also, please do not add a dot/period to the end of commit messages.

Kind regards,

Paul

Quoted 18 lines
---
  drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c +1 -0
index f4f97f0f5c64..1ceda3d0cd5b 100644
@@ -22,6 +22,7 @@
   */
 
  #include "amdgpu.h"
+#include "vcn_sw_ring.h"
 
  void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
  	u64 seq, uint32_t flags)
Reviewed-by on v1 1/1
#3 lore raw
In reply to James Zhu

Am 08.05.22 um 19:30 schrieb James Zhu:

Quoted 4 lines

Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'

Quoted 18 lines
---
  drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c +2 -1
index 08fd61622f95..1ceda3d0cd5b 100644
@@ -21,7 +21,8 @@
   *
   */
 
-#include "amdgpu_vcn.h"
+#include "amdgpu.h"
+#include "vcn_sw_ring.h"
 
  void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
  	u64 seq, uint32_t flags)
author
#4 lore raw

PATCH v3 1/1 drm/amdgpu/vcn: include header for vcn_dec_sw_ring_emit_fence

In reply to James Zhu

Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'.

v2: regenerate patch after git rebase.
v3: update commit message.

---
 drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c +1 -0
index f4f97f0f5c64..1ceda3d0cd5b 100644
@@ -22,6 +22,7 @@
  */
 
 #include "amdgpu.h"
+#include "vcn_sw_ring.h"
 
 void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
 	u64 seq, uint32_t flags)
Signature · 1 line
2.25.1
Reviewed-by on v3 1/1
#5 lore raw

Re: [PATCH v3] drm/amdgpu/vcn: include header for vcn_dec_sw_ring_emit_fence

Quoted 8 lines · James Zhu

Fixed warning: no previous prototype for 'vcn_dec_sw_ring_emit_fence'.

v2: regenerate patch after git rebase.
v3: update commit message.

Quoted 19 lines
---
 drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/vcn_sw_ring.c +1 -1
index f4f97f0f5c64..1ceda3d0cd5b 100644
@@ -22,6 +22,7 @@
  */
 
 #include "amdgpu.h"
+#include "vcn_sw_ring.h"
 
 void vcn_dec_sw_ring_emit_fence(struct amdgpu_ring *ring, u64 addr,
        u64 seq, uint32_t flags)
--

2.25.1