Skip to contentSkip to conversation

damon-vaddr-test-tweak-code-to-make-the-logic-clearer.patch removed from -mm tree

merged mm-stable Andrew Morton 1 participant 1 message May 10, 2022

lore
Share & tools
lore

Andrew Morton

author tree notice Applied
#0 lore raw

The quilt patch titled
Subject: damon: vaddr-test: tweak code to make the logic clearer
has been removed from the -mm tree. Its filename was
damon-vaddr-test-tweak-code-to-make-the-logic-clearer.patch

This patch was dropped because it was merged into mm-stable

------------------------------------------------------
From: Xiaomeng Tong <[email protected]>
Subject: damon: vaddr-test: tweak code to make the logic clearer

Move these two lines into the damon_for_each_region loop, it is always for testing the last region. And also avoid to use a list iterator 'r' outside the loop which is considered harmful[1].

[1]: https://lkml.org/lkml/2022/2/17/1032

---

 mm/damon/vaddr-test.h |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
mm/damon/vaddr-test.h renamed from mm/damon/vaddr-test.h~damon-vaddr-test-tweak-code-to-make-the-logic-clearer +5 -3
@@ -281,14 +281,16 @@ static void damon_test_split_evenly_succ
 	KUNIT_EXPECT_EQ(test, damon_nr_regions(t), nr_pieces);
 
 	damon_for_each_region(r, t) {
-		if (i == nr_pieces - 1)
+		if (i == nr_pieces - 1) {
+			KUNIT_EXPECT_EQ(test,
+				r->ar.start, start + i * expected_width);
+			KUNIT_EXPECT_EQ(test, r->ar.end, end);
 			break;
+		}
 		KUNIT_EXPECT_EQ(test,
 				r->ar.start, start + i++ * expected_width);
 		KUNIT_EXPECT_EQ(test, r->ar.end, start + i * expected_width);
 	}
-	KUNIT_EXPECT_EQ(test, r->ar.start, start + i * expected_width);
-	KUNIT_EXPECT_EQ(test, r->ar.end, end);
 	damon_free_target(t);
 }
 

_

Patches currently in -mm which might be from [email protected] are