mm-gup-disallow-follow_pagefoll_pin.patch removed from -mm tree
The quilt patch titled
Subject: mm/gup: disallow follow_page(FOLL_PIN)
has been removed from the -mm tree. Its filename was
mm-gup-disallow-follow_pagefoll_pin.patch
This patch was dropped because it was merged into mm-stable
------------------------------------------------------
From: David Hildenbrand <[email protected]>
Subject: mm/gup: disallow follow_page(FOLL_PIN)
We want to change the way we handle R/O pins on anonymous pages that might be shared: if we detect a possibly shared anonymous page -- mapped R/O and not !PageAnonExclusive() -- we want to trigger unsharing via a page fault, resulting in an exclusive anonymous page that can be pinned reliably without getting replaced via COW on the next write fault.
However, the required page fault will be problematic for follow_page(): in contrast to ordinary GUP, follow_page() doesn't trigger faults internally. So we would have to end up failing a R/O pin via follow_page(), although there is something mapped R/O into the page table, which might be rather surprising.
We don't seem to have follow_page(FOLL_PIN) users, and it's a purely internal MM function. Let's just make our life easier and the semantics of follow_page() clearer by just disallowing FOLL_PIN for follow_page() completely.
---
mm/gup.c | 3 +++ mm/hugetlb.c | 8 +++++--- 2 files changed, 8 insertions(+), 3 deletions(-)
mm/gup.c renamed from mm/gup.c~mm-gup-disallow-follow_pagefoll_pin +3 -0
@@ -787,6 +787,9 @@ struct page *follow_page(struct vm_area_if (vma_is_secretmem (vma))return NULL ; +if (foll_flags &FOLL_PIN ) +return NULL ; + page =follow_page_mask (vma, address, foll_flags, &ctx);if (ctx.pgmap)put_dev_pagemap (ctx.pgmap);
mm/hugetlb.c renamed from mm/hugetlb.c~mm-gup-disallow-follow_pagefoll_pin +5 -3
@@ -6719,9 +6719,11 @@ follow_huge_pmd(struct mm_struct *mm, unspinlock_t *ptl;pte_t pte; -/* FOLL_GET and FOLL_PIN are mutually exclusive. */ -if (WARN_ON_ONCE ((flags & (FOLL_PIN |FOLL_GET )) == - (FOLL_PIN |FOLL_GET ))) +/* +* FOLL_PIN is not supported for follow_page(). Ordinary GUP goes via +* follow_hugetlb_page(). +*/ +if (WARN_ON_ONCE (flags &FOLL_PIN ))return NULL ; retry:
_
Patches currently in -mm which might be from [email protected] are