media: TDA1997x: Fix the error handling in tda1997x_probe()
Subsystems (2)
PATCH 1/1 media: TDA1997x: Fix the error handling in tda1997x_probe()
The driver should disable the regulator when failing to probe.
Signed-off-by Zheyu Ma <[email protected]>
--- drivers/media/i2c/tda1997x.c | 1 + 1 file changed, 1 insertion(+)
drivers/media/i2c/tda1997x.c +1 -0
@@ -2798,6 +2798,7 @@ static int tda1997x_probe(struct i2c_client *client,cancel_delayed_work (&state->delayed_work_enable_hpd);mutex_destroy (&state->page_lock);mutex_destroy (&state->lock); +tda1997x_set_power (state,0 ); err_free_state:kfree (state);dev_err (&client->dev,"%s failed: %d\n" , __func__, ret);
Signature · 1 line
2.25.1
Quoted 21 lines · Zheyu Ma
The driver should disable the regulator when failing to probe.
Signed-off-by Zheyu Ma <[email protected]>--- drivers/media/i2c/tda1997x.c | 1 + 1 file changed, 1 insertion(+)drivers/media/i2c/tda1997x.c +1
-1@@ -2798,6 +2798,7 @@ static int tda1997x_probe(struct i2c_client *client,cancel_delayed_work (&state->delayed_work_enable_hpd);mutex_destroy (&state->page_lock);mutex_destroy (&state->lock); +tda1997x_set_power (state,0 ); err_free_state:kfree (state);dev_err (&client->dev,"%s failed: %d\n" , __func__, ret); --
Quoted 2 lines
2.25.1
Acked-by Tim Harvey <[email protected]>
Best Regards,
Tim