Skip to contentSkip to conversation

ASoC: wm2000: Remove redundant endianness flag

PATCH In review Charles Keepax 2 participants 3 messages May 10, 2022 – May 12, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ASoC: wm2000: Remove redundant endianness flag

The endianness flag is used on the CODEC side to specify an ambivalence to endian, typically because it is lost over the hardware link. This device has no DAI links and as such the flag would have no effect, remove the redundant flag.

---
 sound/soc/codecs/wm2000.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/codecs/wm2000.c +0 -1
index 075ee852eb724..6a86ce3fb182d 100644
@@ -803,7 +803,6 @@ static const struct snd_soc_component_driver soc_component_dev_wm2000 = {
 	.num_dapm_routes	= ARRAY_SIZE(wm2000_audio_map),
 	.idle_bias_on		= 1,
 	.use_pmdown_time	= 1,
-	.endianness		= 1,
 	.non_legacy_dai_naming	= 1,
 };
 
Signature · 1 line
2.30.2
#1 lore raw

PATCH 2/2 ASoC: wm9090: Remove redundant endianness flag

The endianness flag is used on the CODEC side to specify an ambivalence to endian, typically because it is lost over the hardware link. This device has no DAI links and as such the flag would have no effect, remove the redundant flag.

---
 sound/soc/codecs/wm9090.c | 1 -
 1 file changed, 1 deletion(-)
sound/soc/codecs/wm9090.c +0 -1
index 1bae81a7d3908..f7d80f1e37a80 100644
@@ -543,7 +543,6 @@ static const struct snd_soc_component_driver soc_component_dev_wm9090 = {
 	.suspend_bias_off	= 1,
 	.idle_bias_on		= 1,
 	.use_pmdown_time	= 1,
-	.endianness		= 1,
 	.non_legacy_dai_naming	= 1,
 };
 
Signature · 1 line
2.30.2
maintainer
#2 lore raw
In reply to Charles Keepax
Quoted 6 lines · Charles Keepax

The endianness flag is used on the CODEC side to specify an ambivalence to endian, typically because it is lost over the hardware link. This device has no DAI links and as such the flag would have no effect, remove the redundant flag.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: wm2000: Remove redundant endianness flag

      commit: 69b53a097d9984d93448b021e0d422f2803310bd
[2/2] ASoC: wm9090: Remove redundant endianness flag
      commit: de2427207d13d7fe1882cd1772d66e33debf999e

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark