Skip to contentSkip to conversation

kni_net.c: use netif_rx() instead of netif_rx_ni()

PATCH In review [email protected] 2 participants 2 messages May 11, 2022 – May 31, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kni_net.c: use netif_rx() instead of netif_rx_ni()

From: Mingli Yu <[email protected]>

The netif_rx_ni is removed in below commit after kernel upgraded to 5.18, so change accordingly to fix the gap. 2655926aea9b net: Remove netif_rx_any_context() and netif_rx_ni().

---
 kernel/linux/kni/kni_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/linux/kni/kni_net.c +1 -1
index 7fcfa106cb..58e8fe5af6 100644
@@ -368,7 +368,7 @@ kni_net_rx_normal(struct kni_dev *kni)
 		skb->ip_summed = CHECKSUM_UNNECESSARY;
 
 		/* Call netif interface */
-		netif_rx_ni(skb);
+		netif_rx(skb);
 
 		/* Update statistics */
 		kni->stats.rx_bytes += len;
Signature · 1 line
2.25.1
#1 lore raw
Quoted 16 lines · On 5/11/22 14:23, [email protected] wrote:

From: Mingli Yu <[email protected]>

The netif_rx_ni is removed in below commit after kernel upgraded to 5.18, so change accordingly to fix the gap. 2655926aea9b net: Remove netif_rx_any_context() and netif_rx_ni().

---
  kernel/linux/kni/kni_net.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
kernel/linux/kni/kni_net.c +0 -0
index 7fcfa106cb..58e8fe5af6 100644

kernel/linux/kni/kni_net.c kni_net_rx_normal(struct kni_dev *kni) · line 374

Quoted 8 lines
kernel/linux/kni/kni_net.c +1 -1
@@ -368,7 +368,7 @@ kni_net_rx_normal(struct kni_dev *kni)
  		skb->ip_summed = CHECKSUM_UNNECESSARY;
 
  		/* Call netif interface */
-		netif_rx_ni(skb);
+		netif_rx(skb);
 
  		/* Update statistics */
  		kni->stats.rx_bytes += len;

There are two more patches [1] and [2] in the patchwork on the topic and it looks like the latest is the best one. Do you have any comments on [2]?

[1] https://patches.dpdk.org/project/dpdk/patch/[email protected]/
[2]https://patches.dpdk.org/project/dpdk/patch/[email protected]/