Skip to contentSkip to conversation

fsi: master-ast-cf: Fix refcount leak in fsi_master_acf_probe

PATCH New Miaoqian Lin 1 participant 1 message May 11, 2022 FSI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fsi: master-ast-cf: Fix refcount leak in fsi_master_acf_probe

of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when done.

Fixes 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
---
 drivers/fsi/fsi-master-ast-cf.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/fsi/fsi-master-ast-cf.c +2 -0
index 24292acdbaf8..3e6cacdc1bfe 100644
@@ -1326,10 +1326,12 @@ static int fsi_master_acf_probe(struct platform_device *pdev)
 		if (IS_ERR(master->cvic)) {
 			rc = PTR_ERR(master->cvic);
 			dev_err(&pdev->dev, "Error %d mapping CVIC\n", rc);
+			of_node_put(np);
 			goto err_free;
 		}
 		rc = of_property_read_u32(np, "copro-sw-interrupts",
 					  &master->cvic_sw_irq);
+		of_node_put(np);
 		if (rc) {
 			dev_err(&pdev->dev, "Can't find coprocessor SW interrupt\n");
 			goto err_free;
Signature · 1 line
2.25.1