Skip to contentSkip to conversation

Enable CONFIG_FPROBE for self tests

PATCH Applied Daniel Müller 4 participants 4 messages May 11, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Enable CONFIG_FPROBE for self tests

Some of the BPF selftests are failing when running with a rather bare bones configuration based on tools/testing/selftests/bpf/config. Specifically, we see a bunch of failures due to errno 95:

Quoted 4 lines

test_attach_api:PASS:fentry_raw_skel_load 0 nsec
libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
79 /6 kprobe_multi_test/attach_api_syms:FAIL

The cause of these is that CONFIG_FPROBE is missing. With this change we add this configuration value to the BPF selftests config.

---
 tools/testing/selftests/bpf/config | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/config +1 -0
index 763db6..08c6e5a 100644
@@ -53,3 +53,4 @@ CONFIG_NF_DEFRAG_IPV4=y
 CONFIG_NF_DEFRAG_IPV6=y
 CONFIG_NF_CONNTRACK=y
 CONFIG_USERFAULTFD=y
+CONFIG_FPROBE=y
Signature · 1 line
2.30.2
Acked-by on v1 1/1
#1 lore raw
Quoted 29 lines · Daniel Müller

Some of the BPF selftests are failing when running with a rather bare bones configuration based on tools/testing/selftests/bpf/config. Specifically, we see a bunch of failures due to errno 95:

Quoted 4 lines

test_attach_api:PASS:fentry_raw_skel_load 0 nsec
libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
79 /6 kprobe_multi_test/attach_api_syms:FAIL

The cause of these is that CONFIG_FPROBE is missing. With this change we add this configuration value to the BPF selftests config.

---
 tools/testing/selftests/bpf/config | 1 +
 1 file changed, 1 insertion(+)
tools/testing/selftests/bpf/config +1 -0
index 763db6..08c6e5a 100644
@@ -53,3 +53,4 @@ CONFIG_NF_DEFRAG_IPV4=y
 CONFIG_NF_DEFRAG_IPV6=y
 CONFIG_NF_CONNTRACK=y
 CONFIG_USERFAULTFD=y
+CONFIG_FPROBE=y
Signature · 1 line
2.30.2

Looks good, thanks Daniel.

#2 lore raw
In reply to Daniel Müller
Quoted 10 lines · Daniel Müller

Some of the BPF selftests are failing when running with a rather bare bones configuration based on tools/testing/selftests/bpf/config. Specifically, we see a bunch of failures due to errno 95:

Quoted 4 lines

test_attach_api:PASS:fentry_raw_skel_load 0 nsec
libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
79 /6 kprobe_multi_test/attach_api_syms:FAIL

Quoted 4 lines

The cause of these is that CONFIG_FPROBE is missing. With this change we add this configuration value to the BPF selftests config.

Please use 'selftests/bpf: ' prefix in the patch subj in the future.
I've fixed it up while applying this time.

#3 lore raw
In reply to Daniel Müller
This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Hello:

This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov <[email protected]>:

Quoted 10 lines · On Wed, 11 May 2022 17:22:49 +0000 you wrote:

Some of the BPF selftests are failing when running with a rather bare bones configuration based on tools/testing/selftests/bpf/config. Specifically, we see a bunch of failures due to errno 95:

Quoted 4 lines

test_attach_api:PASS:fentry_raw_skel_load 0 nsec
libbpf: prog 'test_kprobe_manual': failed to attach: Operation not supported test_attach_api:FAIL:bpf_program__attach_kprobe_multi_opts unexpected error: -95
79 /6 kprobe_multi_test/attach_api_syms:FAIL

[...]

Here is the summary with links:
- [bpf-next] Enable CONFIG_FPROBE for self tests

    https://git.kernel.org/bpf/bpf-next/c/998e1869de1b

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html