Skip to contentSkip to conversation

package/wpa_supplicant: wired driver needs headers >= 4.6

PATCH Applied Sergey Matyukevich 3 participants 3 messages May 11, 2022 – May 14, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/wpa_supplicant: wired driver needs headers >= 4.6

Wired driver enables macsec support which depends on if_macsec.h. That header has only been exported since kernel v4.6, see commit:
https://github.com/torvalds/linux/commit/dece8d2b78d19df7fe5e4e965f1f0d1a3e188d1b

Fixes:
- http://autobuild.buildroot.net/results/6bb619eb7fdecf7824fcc549c4ccb8e487665d10/

---
 package/wpa_supplicant/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/wpa_supplicant/Config.in +4 -0
index 7e2432985c..92953f69f0 100644
@@ -42,6 +42,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
 config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
 	bool "Enable wired support"
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
 	select BR2_PACKAGE_LIBNL
 	select BR2_PACKAGE_WPA_SUPPLICANT_EAP
 	help
@@ -49,6 +50,9 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
 	  supplicant can be used with Ethernet.  This also enables
 	  support for MACSEC.
 
+comment "wired macsec support needs a toolchain w/ headers >= 4.6"
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
+
 comment "wired support needs a toolchain w/ threads"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Reviewed-by Yegor Yefremov on v1 1/1
#1 lore raw

Hi Sergey,

Quoted 9 lines · Sergey Matyukevich

Wired driver enables macsec support which depends on if_macsec.h. That header has only been exported since kernel v4.6, see commit:
https://github.com/torvalds/linux/commit/dece8d2b78d19df7fe5e4e965f1f0d1a3e188d1b

Fixes:
- http://autobuild.buildroot.net/results/6bb619eb7fdecf7824fcc549c4ccb8e487665d10/

Regards,
Yegor

Quoted 27 lines
---
 package/wpa_supplicant/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/wpa_supplicant/Config.in +4 -1
index 7e2432985c..92953f69f0 100644
@@ -42,6 +42,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
 config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
        bool "Enable wired support"
        depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+       depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
        select BR2_PACKAGE_LIBNL
        select BR2_PACKAGE_WPA_SUPPLICANT_EAP
        help
@@ -49,6 +50,9 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
          supplicant can be used with Ethernet.  This also enables
          support for MACSEC.
 
+comment "wired macsec support needs a toolchain w/ headers >= 4.6"
+       depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
+
 comment "wired support needs a toolchain w/ threads"
        depends on !BR2_TOOLCHAIN_HAS_THREADS
 
--
Quoted 2 lines

2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#2 lore raw
In reply to Sergey Matyukevich
Quoted 8 lines · Sergey Matyukevich

Wired driver enables macsec support which depends on if_macsec.h. That header has only been exported since kernel v4.6, see commit:
https://github.com/torvalds/linux/commit/dece8d2b78d19df7fe5e4e965f1f0d1a3e188d1b

Fixes:
- http://autobuild.buildroot.net/results/6bb619eb7fdecf7824fcc549c4ccb8e487665d10/

Applied to master, thanks.

Regards,
Arnout

Quoted 17 lines
---
  package/wpa_supplicant/Config.in | 4 ++++
  1 file changed, 4 insertions(+)
package/wpa_supplicant/Config.in +1 -0
index 7e2432985c..92953f69f0 100644
@@ -42,6 +42,7 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WEXT
  config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
  	bool "Enable wired support"
  	depends on BR2_TOOLCHAIN_HAS_THREADS # libnl
+	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
  	select BR2_PACKAGE_LIBNL
  	select BR2_PACKAGE_WPA_SUPPLICANT_EAP
  	help

package/wpa_supplicant/Config.in config BR2_PACKAGE_WPA_SUPPLICANT_WIRED · line 58

Quoted 9 lines
package/wpa_supplicant/Config.in +3 -0
@@ -49,6 +50,9 @@ config BR2_PACKAGE_WPA_SUPPLICANT_WIRED
  	  supplicant can be used with Ethernet.  This also enables
  	  support for MACSEC.
 
+comment "wired macsec support needs a toolchain w/ headers >= 4.6"
+	depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_6
+
  comment "wired support needs a toolchain w/ threads"
  	depends on !BR2_TOOLCHAIN_HAS_THREADS
 

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot