pinctrl: ast2400: add support for RGMII1 and RGMII2
Subsystems (3)
PATCH v2 1/1 pinctrl: ast2400: add support for RGMII1 and RGMII2
The bits configured by these pinctrl groups are set to the same values as their reset defaults, so RGMII functionality would likely work anyway, but it seems good to make it explicit instead of relying on that.
Signed-off-by Zev Weiss <[email protected]>
---
Changes since v1 [0]:
- Added RGMII1 group [Joel]
[0] https://lore.kernel.org/openbmc/[email protected]/
drivers/pinctrl/aspeed/pinctrl_ast2400.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/pinctrl/aspeed/pinctrl_ast2400.c +10 -0
@@ -133,6 +133,14 @@ static struct aspeed_sig_desc rxd3_link[] = { { 0x80, BIT(23), 0}, }; +static struct aspeed_sig_desc rgmii1_link[] = { + {0xa0 ,GENMASK (17 ,12 ) |GENMASK (5 ,0 ),1 }, +}; + +static struct aspeed_sig_desc rgmii2_link[] = { + {0xa0 ,GENMASK (23 ,18 ) |GENMASK (11 ,6 ),1 }, +}; +static const struct aspeed_group_config ast2400_groups[] = { {"MAC1LINK" ,1 , mac1_link }, { "MAC2LINK", 1, mac2_link },
@@ -156,6 +164,8 @@ static const struct aspeed_group_config ast2400_groups[] = { { "SPI1CS1", 1, spi1cs1_link}, { "TXD3", 1, txd3_link }, { "RXD3", 1, rxd3_link }, + { "RGMII1", 1, rgmii1_link }, + { "RGMII2", 1, rgmii2_link }, };static int ast2400_pinctrl_get_groups_count (struct udevice *dev)
Signature · 1 line
2.35.3
Quoted 11 lines · Zev Weiss
The bits configured by these pinctrl groups are set to the same values as their reset defaults, so RGMII functionality would likely work anyway, but it seems good to make it explicit instead of relying on that.
Signed-off-by Zev Weiss <[email protected]>---
Changes since v1 [0]:
- Added RGMII1 group [Joel]
Thanks, applied.
Quoted 37 lines
[0] https://lore.kernel.org/openbmc/[email protected]/
drivers/pinctrl/aspeed/pinctrl_ast2400.c | 10 ++++++++++ 1 file changed, 10 insertions(+)drivers/pinctrl/aspeed/pinctrl_ast2400.c +10
-1@@ -133,6 +133,14 @@ static struct aspeed_sig_desc rxd3_link[] = { { 0x80, BIT(23), 0}, }; +static struct aspeed_sig_desc rgmii1_link[] = { + {0xa0 ,GENMASK (17 ,12 ) |GENMASK (5 ,0 ),1 }, +}; + +static struct aspeed_sig_desc rgmii2_link[] = { + {0xa0 ,GENMASK (23 ,18 ) |GENMASK (11 ,6 ),1 }, +}; +static const struct aspeed_group_config ast2400_groups[] = { {"MAC1LINK" ,1 , mac1_link }, { "MAC2LINK", 1, mac2_link },@@ -156,6 +164,8 @@ static const struct aspeed_group_config ast2400_groups[] = { { "SPI1CS1", 1, spi1cs1_link}, { "TXD3", 1, txd3_link }, { "RXD3", 1, rxd3_link }, + { "RGMII1", 1, rgmii1_link }, + { "RGMII2", 1, rgmii2_link }, };static int ast2400_pinctrl_get_groups_count (struct udevice *dev) --2.35.3