powerpc/fsl_rio: Fix refcount leak in fsl_rio_setup
PATCH 1/1 powerpc/fsl_rio: Fix refcount leak in fsl_rio_setup
of_parse_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
Fixes abc3aeae3aaa ("fsl-rio: Add two ports and rapidio message units support")
Signed-off-by Miaoqian Lin <[email protected]>
--- arch/powerpc/sysdev/fsl_rio.c | 2 ++ 1 file changed, 2 insertions(+)
arch/powerpc/sysdev/fsl_rio.c +2 -0
@@ -505,8 +505,10 @@ int fsl_rio_setup(struct platform_device *dev)if (rc) {dev_err (&dev->dev,"Can't get %pOF property 'reg'\n" , rmu_node); +of_node_put (rmu_node); goto err_rmu; } +of_node_put (rmu_node); rmu_regs_win =ioremap (rmu_regs.start,resource_size (&rmu_regs));if (!rmu_regs_win) {dev_err (&dev->dev,"Unable to map rmu register window\n" );
Signature · 1 line
2.25.1
Michael Ellerman
AppliedQuoted 5 lines · Miaoqian Lin
of_parse_phandle()returns a node pointer with refcount incremented, we should useof_node_put()on it when not need anymore. Add missingof_node_put()to avoid refcount leak.
Applied to powerpc/next.
[1/1] powerpc/fsl_rio: Fix refcount leak in fsl_rio_setup
https://git.kernel.org/powerpc/c/fcee96924ba1596ca80a6770b2567ca546f9a482
cheers