iguanair: no superfluous usb_unlink_urb()
PATCH 1/1 iguanair: no superfluous usb_unlink_urb()
Unlinking yourself while the completion handler
is running is a NOP. Drop it.
Signed-off-by Oliver Neukum <[email protected]>
--- drivers/media/rc/iguanair.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/media/rc/iguanair.c +1 -4
@@ -149,10 +149,8 @@ static void iguanair_rx(struct urb *urb)return ; ir = urb->context; -if (!ir) { -usb_unlink_urb (urb); +if (!ir)return ; - }switch (urb->status) {case 0 :
@@ -161,7 +159,6 @@ static void iguanair_rx(struct urb *urb)case -ECONNRESET :case -ENOENT :case -ESHUTDOWN : -usb_unlink_urb (urb);return ;case -EPIPE :default :
Signature · 1 line
2.35.3
Quoted 2 lines · Oliver Neukum
Unlinking yourself while the completion handler
is running is a NOP. Drop it.
Applied, thanks!
Sean
Quoted 32 lines
Signed-off-by Oliver Neukum <[email protected]>--- drivers/media/rc/iguanair.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)drivers/media/rc/iguanair.c +1
-4@@ -149,10 +149,8 @@ static void iguanair_rx(struct urb *urb)return ; ir = urb->context; -if (!ir) { -usb_unlink_urb (urb); +if (!ir)return ; - }switch (urb->status) {case 0 :@@ -161,7 +159,6 @@ static void iguanair_rx(struct urb *urb)case -ECONNRESET :case -ENOENT :case -ESHUTDOWN : -usb_unlink_urb (urb);return ;case -EPIPE :default :Signature · 1 line
2.35.3