Skip to contentSkip to conversation

Microchip LAN966x USB device support

PATCH In review Herve Codina 4 participants 18 messages May 13, 2022 – May 20, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

cover Microchip LAN966x USB device support

Hi,

This series add support for the USB device controller available on the Microchip LAN966x SOCs.

This controller is the same as the one present on the SAMAD3 SOC.

Regards,
Herve

Herve Codina (3):
clk: lan966x: Fix the lan966x clock gate register address
dt-bindings: usb: atmel: Add Microchip LAN966x compatible string
ARM: dts: lan966x: Add UDPHS support

 Documentation/devicetree/bindings/usb/atmel-usb.txt |  3 +++
 arch/arm/boot/dts/lan966x.dtsi                      | 11 +++++++++++
 drivers/clk/clk-lan966x.c                           |  2 +-
 3 files changed, 15 insertions(+), 1 deletion(-)
Signature · 1 line
2.35.1
#1 lore raw

PATCH 1/3 clk: lan966x: Fix the lan966x clock gate register address

The register address used for the clock gate register is the base register address coming from first reg map (ie. the generic clock registers) instead of the second reg map defining the clock gate register.

Use the correct clock gate register address.

Fixes 5ad5915dea00 ("clk: lan966x: Extend lan966x clock driver for clock gating support")
---
 drivers/clk/clk-lan966x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clk-lan966x.c +1 -1
index d1535ac13e89..81cb90955d68 100644
@@ -213,7 +213,7 @@ static int lan966x_gate_clk_register(struct device *dev,
 
 		hw_data->hws[i] =
 			devm_clk_hw_register_gate(dev, clk_gate_desc[idx].name,
-						  "lan966x", 0, base,
+						  "lan966x", 0, gate_base,
 						  clk_gate_desc[idx].bit_idx,
 						  0, &clk_gate_lock);
 
Signature · 1 line
2.35.1
#2 lore raw

PATCH 2/3 dt-bindings: usb: atmel: Add Microchip LAN966x compatible string

In reply to Herve Codina

The USB device controller available in the Microchip LAN966x SOC is the same IP as the one present in the SAMA5D3 SOC.

Add the LAN966x compatible string and set the SAMA5D3 compatible string as a fallback for the LAN966x.

---
 Documentation/devicetree/bindings/usb/atmel-usb.txt | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/usb/atmel-usb.txt +3 -0
index f512f0290728..a6fab7d63f37 100644
@@ -87,6 +87,9 @@ Required properties:
 	       "atmel,at91sam9g45-udc"
 	       "atmel,sama5d3-udc"
 	       "microchip,sam9x60-udc"
+	       "microchip,lan996x-udc"
+	       For "microchip,lan996x-udc", the fallback "atmel,sama5d3-udc"
+	       is required.
  - reg: Address and length of the register set for the device
  - interrupts: Should contain usba interrupt
  - clocks: Should reference the peripheral and host clocks
Signature · 1 line
2.35.1
#3 lore raw

Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string

Quoted 16 lines · Herve Codina

The USB device controller available in the Microchip LAN966x SOC is the same IP as the one present in the SAMA5D3 SOC.

Add the LAN966x compatible string and set the SAMA5D3 compatible string as a fallback for the LAN966x.

---
 Documentation/devicetree/bindings/usb/atmel-usb.txt | 3 +++
 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/usb/atmel-usb.txt +0 -0
index f512f0290728..a6fab7d63f37 100644

Documentation/devicetree/bindings/usb/atmel-usb.txt Required properties: · line 90

Quoted 4 lines
Documentation/devicetree/bindings/usb/atmel-usb.txt +1 -0
@@ -87,6 +87,9 @@ Required properties:
 	       "atmel,at91sam9g45-udc"
 	       "atmel,sama5d3-udc"
 	       "microchip,sam9x60-udc"
+	       "microchip,lan996x-udc"

No wildcards please, especially that it closely fits previous wildcard (lan996x includes lan9960 which looks a lot like sam9x60...)

Best regards,
Krzysztof

#4 lore raw

Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string

Quoted 12 lines · On Fri, 13 May 2022 14:57:55 +0200 Krzysztof Kozlowski…
Quoted 11 lines · Herve Codina

The USB device controller available in the Microchip LAN966x SOC is the same IP as the one present in the SAMA5D3 SOC.

Add the LAN966x compatible string and set the SAMA5D3 compatible string as a fallback for the LAN966x.

---
 Documentation/devicetree/bindings/usb/atmel-usb.txt | 3 +++
 1 file changed, 3 insertions(+)
Quoted 13 lines

Documentation/devicetree/bindings/usb/atmel-usb.txt Required properties: · line 90

Quoted 9 lines
Documentation/devicetree/bindings/usb/atmel-usb.txt +1 -0
index f512f0290728..a6fab7d63f37 100644
@@ -87,6 +87,9 @@ Required properties:
 	       "atmel,at91sam9g45-udc"
 	       "atmel,sama5d3-udc"
 	       "microchip,sam9x60-udc"
+	       "microchip,lan996x-udc"  

No wildcards please, especially that it closely fits previous wildcard (lan996x includes lan9960 which looks a lot like sam9x60...)

Well, first, I made a mistake. It should be lan966x instead of lan996x.

This family is composed of the LAN9662 and the LAN9668 SOCs.

Related to the wilcard, lan966x is used in several bindings for common parts used by both SOCs:
- microchip,lan966x-gck
- microchip,lan966x-cpu-syscon
- microchip,lan966x-switch
- microchip,lan966x-miim
- microchip,lan966x-serdes
- microchip,lan966x-pinctrl

I think it makes sense to keep 'microchip,lan966x-udc' for the USB device controller (same controller on LAN9662 and LAN9668) and so keeping the same rules as for other common parts.

Regards,
Hervé

Quoted 3 lines

Best regards,
Krzysztof

Signature · 3 lines
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#5 lore raw

Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string

Quoted 33 lines · Herve Codina
Quoted 12 lines · On Fri, 13 May 2022 14:57:55 +0200 Krzysztof Kozlowski…
Quoted 11 lines · Herve Codina

The USB device controller available in the Microchip LAN966x SOC is the same IP as the one present in the SAMA5D3 SOC.

Add the LAN966x compatible string and set the SAMA5D3 compatible string as a fallback for the LAN966x.

---
 Documentation/devicetree/bindings/usb/atmel-usb.txt | 3 +++
 1 file changed, 3 insertions(+)
Quoted 13 lines

Documentation/devicetree/bindings/usb/atmel-usb.txt Required properties: · line 90

Quoted 9 lines
Documentation/devicetree/bindings/usb/atmel-usb.txt +1 -0
index f512f0290728..a6fab7d63f37 100644
@@ -87,6 +87,9 @@ Required properties:
 	       "atmel,at91sam9g45-udc"
 	       "atmel,sama5d3-udc"
 	       "microchip,sam9x60-udc"
+	       "microchip,lan996x-udc"  

No wildcards please, especially that it closely fits previous wildcard (lan996x includes lan9960 which looks a lot like sam9x60...)

Well, first, I made a mistake. It should be lan966x instead of lan996x.

This family is composed of the LAN9662 and the LAN9668 SOCs.

Quoted 8 lines

Related to the wilcard, lan966x is used in several bindings for common parts used by both SOCs:
- microchip,lan966x-gck
- microchip,lan966x-cpu-syscon
- microchip,lan966x-switch
- microchip,lan966x-miim
- microchip,lan966x-serdes
- microchip,lan966x-pinctrl

And for new bindings I pointed that it is not preferred, so already few other started using specific compatible.

Quoted 4 lines

I think it makes sense to keep 'microchip,lan966x-udc' for the USB device controller (same controller on LAN9662 and LAN9668) and so keeping the same rules as for other common parts.

Having wildcard was rather a mistake and we already started correcting it, so keeping the "mistake" neither gives you consistency, nor correctness...

Best regards,
Krzysztof

#6 lore raw

Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string

Hi Krzysztof,

Quoted 47 lines · On Fri, 20 May 2022 13:40:13 +0200 Krzysztof Kozlowski…
Quoted 33 lines · Herve Codina
Quoted 12 lines · On Fri, 13 May 2022 14:57:55 +0200 Krzysztof Kozlowski…
Quoted 11 lines · Herve Codina

The USB device controller available in the Microchip LAN966x SOC is the same IP as the one present in the SAMA5D3 SOC.

Add the LAN966x compatible string and set the SAMA5D3 compatible string as a fallback for the LAN966x.

---
 Documentation/devicetree/bindings/usb/atmel-usb.txt | 3 +++
 1 file changed, 3 insertions(+)
Quoted 13 lines

Documentation/devicetree/bindings/usb/atmel-usb.txt Required properties: · line 90

Quoted 9 lines
Documentation/devicetree/bindings/usb/atmel-usb.txt +1 -0
index f512f0290728..a6fab7d63f37 100644
@@ -87,6 +87,9 @@ Required properties:
 	       "atmel,at91sam9g45-udc"
 	       "atmel,sama5d3-udc"
 	       "microchip,sam9x60-udc"
+	       "microchip,lan996x-udc"    

No wildcards please, especially that it closely fits previous wildcard (lan996x includes lan9960 which looks a lot like sam9x60...)

Well, first, I made a mistake. It should be lan966x instead of lan996x.

This family is composed of the LAN9662 and the LAN9668 SOCs.

Quoted 8 lines

Related to the wilcard, lan966x is used in several bindings for common parts used by both SOCs:
- microchip,lan966x-gck
- microchip,lan966x-cpu-syscon
- microchip,lan966x-switch
- microchip,lan966x-miim
- microchip,lan966x-serdes
- microchip,lan966x-pinctrl

And for new bindings I pointed that it is not preferred, so already few other started using specific compatible.

Quoted 1 line
Quoted 8 lines
Quoted 3 lines

I think it makes sense to keep 'microchip,lan966x-udc' for the USB device controller (same controller on LAN9662 and LAN9668) and so keeping the same rules as for other common parts.

Having wildcard was rather a mistake and we already started correcting it, so keeping the "mistake" neither gives you consistency, nor correctness...

I think that the "family" compatible should be present. This one allows to define the common parts in the common .dtsi file (lan966x.dtsi in our case).

What do you think about:
- microchip,lan9662-udc
- microchip,lan9668-udc
- microchip,lan966-udc <-- Family

lan966 is defined as the family compatible string since (1) in bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst

(1) https://lore.kernel.org/all/[email protected]/

Regards,
Herve

Signature · 3 lines
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#7 lore raw

Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string

Quoted 13 lines · Herve Codina
Quoted 8 lines
Quoted 3 lines

I think it makes sense to keep 'microchip,lan966x-udc' for the USB device controller (same controller on LAN9662 and LAN9668) and so keeping the same rules as for other common parts.

Having wildcard was rather a mistake and we already started correcting it, so keeping the "mistake" neither gives you consistency, nor correctness...

I think that the "family" compatible should be present. This one allows to define the common parts in the common .dtsi file (lan966x.dtsi in our case).

Quoted 8 lines

What do you think about:
- microchip,lan9662-udc
- microchip,lan9668-udc
- microchip,lan966-udc <-- Family

lan966 is defined as the family compatible string since (1) in bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst

You can add some family compatible, if it makes sense. I don't get why do you mention it - we did not discuss family names, but using wildcards... Just please do not add wildcards.

Best regards,
Krzysztof

#8 lore raw

Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string

Quoted 19 lines · On Fri, 20 May 2022 14:50:24 +0200 Krzysztof Kozlowski…
Quoted 18 lines · Herve Codina
Quoted 8 lines
Quoted 3 lines

I think it makes sense to keep 'microchip,lan966x-udc' for the USB device controller (same controller on LAN9662 and LAN9668) and so keeping the same rules as for other common parts.

Having wildcard was rather a mistake and we already started correcting it, so keeping the "mistake" neither gives you consistency, nor correctness...

I think that the "family" compatible should be present. This one allows to define the common parts in the common .dtsi file (lan966x.dtsi in our case).

What do you think about:
- microchip,lan9662-udc
- microchip,lan9668-udc
- microchip,lan966-udc <-- Family

Quoted 7 lines
Quoted 3 lines

lan966 is defined as the family compatible string since (1) in bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst

You can add some family compatible, if it makes sense. I don't get why do you mention it - we did not discuss family names, but using wildcards... Just please do not add wildcards.

Well, I mentioned it as I will only use the family compatible string and not the SOC (lan9662 or lan9668) compatible string in lan966x.dtsi. In this case, the family compatible string can be seen as a kind of "wildcard".

Regards,
Hervé

Signature · 3 lines
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#9 lore raw

Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string

Quoted 26 lines · Herve Codina
Quoted 23 lines · On Fri, 20 May 2022 14:50:24 +0200 Krzysztof Kozlowski…
Quoted 21 lines · Herve Codina
Quoted 8 lines
Quoted 3 lines

I think it makes sense to keep 'microchip,lan966x-udc' for the USB device controller (same controller on LAN9662 and LAN9668) and so keeping the same rules as for other common parts.

Having wildcard was rather a mistake and we already started correcting it, so keeping the "mistake" neither gives you consistency, nor correctness...

I think that the "family" compatible should be present. This one allows to define the common parts in the common .dtsi file (lan966x.dtsi in our case).

What do you think about:
- microchip,lan9662-udc
- microchip,lan9668-udc
- microchip,lan966-udc <-- Family

lan966 is defined as the family compatible string since (1) in bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst

Quoted 8 lines
Quoted 3 lines

You can add some family compatible, if it makes sense. I don't get why do you mention it - we did not discuss family names, but using wildcards... Just please do not add wildcards.

Well, I mentioned it as I will only use the family compatible string and not the SOC (lan9662 or lan9668) compatible string in lan966x.dtsi. In this case, the family compatible string can be seen as a kind of "wildcard".

I understood as "the "family" compatible should be present" as you want to add it as a fallback. It would be okay (assuming devices indeed share family design). If you want to use it as the only one, then it is again not a recommended approach. Please use specific compatibles.

I mean, why do we have this discussion? What is the benefit for you to implement something not-recommended by Devicetree spec and style?

Best regards,
Krzysztof

#10 lore raw

Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string

Hello,

Quoted 36 lines · Krzysztof Kozlowski
Quoted 26 lines · Herve Codina
Quoted 23 lines · On Fri, 20 May 2022 14:50:24 +0200 Krzysztof Kozlowski…
Quoted 21 lines · Herve Codina
Quoted 8 lines
Quoted 3 lines

I think it makes sense to keep 'microchip,lan966x-udc' for the USB device controller (same controller on LAN9662 and LAN9668) and so keeping the same rules as for other common parts.

Having wildcard was rather a mistake and we already started correcting it, so keeping the "mistake" neither gives you consistency, nor correctness...

I think that the "family" compatible should be present. This one allows to define the common parts in the common .dtsi file (lan966x.dtsi in our case).

What do you think about:
- microchip,lan9662-udc
- microchip,lan9668-udc
- microchip,lan966-udc <-- Family

lan966 is defined as the family compatible string since (1) in bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst

Quoted 8 lines
Quoted 3 lines

You can add some family compatible, if it makes sense. I don't get why do you mention it - we did not discuss family names, but using wildcards... Just please do not add wildcards.

Well, I mentioned it as I will only use the family compatible string and not the SOC (lan9662 or lan9668) compatible string in lan966x.dtsi. In this case, the family compatible string can be seen as a kind of "wildcard".

Quoted 8 lines

I understood as "the "family" compatible should be present" as you want to add it as a fallback. It would be okay (assuming devices indeed share family design). If you want to use it as the only one, then it is again not a recommended approach. Please use specific compatibles.

I mean, why do we have this discussion? What is the benefit for you to implement something not-recommended by Devicetree spec and style?

Honestly, I would just go for microchip,lan9662-udc. There is no difference between lan9662 and lan9668 apart from the number of switch ports.

Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#11 lore raw

Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string

Quoted 44 lines · Alexandre Belloni

Hello,

Quoted 41 lines · Krzysztof Kozlowski
Quoted 26 lines · Herve Codina
Quoted 23 lines · On Fri, 20 May 2022 14:50:24 +0200 Krzysztof Kozlowski…
Quoted 21 lines · Herve Codina
Quoted 8 lines
Quoted 3 lines

I think it makes sense to keep 'microchip,lan966x-udc' for the USB device controller (same controller on LAN9662 and LAN9668) and so keeping the same rules as for other common parts.

Having wildcard was rather a mistake and we already started correcting it, so keeping the "mistake" neither gives you consistency, nor correctness...

I think that the "family" compatible should be present. This one allows to define the common parts in the common .dtsi file (lan966x.dtsi in our case).

What do you think about:
- microchip,lan9662-udc
- microchip,lan9668-udc
- microchip,lan966-udc <-- Family

lan966 is defined as the family compatible string since (1) in bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst

Quoted 8 lines
Quoted 3 lines

You can add some family compatible, if it makes sense. I don't get why do you mention it - we did not discuss family names, but using wildcards... Just please do not add wildcards.

Well, I mentioned it as I will only use the family compatible string and not the SOC (lan9662 or lan9668) compatible string in lan966x.dtsi. In this case, the family compatible string can be seen as a kind of "wildcard".

I understood as "the "family" compatible should be present" as you want to add it as a fallback. It would be okay (assuming devices indeed share family design). If you want to use it as the only one, then it is again not a recommended approach. Please use specific compatibles.

Quoted 7 lines
Quoted 3 lines

I mean, why do we have this discussion? What is the benefit for you to implement something not-recommended by Devicetree spec and style?

Honestly, I would just go for microchip,lan9662-udc. There is no difference between lan9662 and lan9668 apart from the number of switch ports.

Thank you, and maybe that was misunderstanding - I do not propose to add additional lan9668 compatible, if it is not actually needed.

Best regards,
Krzysztof

#12 lore raw

Re: [PATCH 2/3] dt-bindings: usb: atmel: Add Microchip LAN966x compatible string

In reply to Alexandre Belloni

Hi Alexandre,

Quoted 44 lines · On Fri, 20 May 2022 15:52:22 +0200 Alexandre Belloni…

Hello,

Quoted 41 lines · Krzysztof Kozlowski
Quoted 26 lines · Herve Codina
Quoted 23 lines · On Fri, 20 May 2022 14:50:24 +0200 Krzysztof Kozlowski…
Quoted 21 lines · Herve Codina
Quoted 8 lines
Quoted 3 lines

I think it makes sense to keep 'microchip,lan966x-udc' for the USB device controller (same controller on LAN9662 and LAN9668) and so keeping the same rules as for other common parts.

Having wildcard was rather a mistake and we already started correcting it, so keeping the "mistake" neither gives you consistency, nor correctness...

I think that the "family" compatible should be present. This one allows to define the common parts in the common .dtsi file (lan966x.dtsi in our case).

What do you think about:
- microchip,lan9662-udc
- microchip,lan9668-udc
- microchip,lan966-udc <-- Family

lan966 is defined as the family compatible string since (1) in bindings/arm/atmel-at91.yaml and in Documentation/arm/microchip.rst

Quoted 8 lines
Quoted 3 lines

You can add some family compatible, if it makes sense. I don't get why do you mention it - we did not discuss family names, but using wildcards... Just please do not add wildcards.

Well, I mentioned it as I will only use the family compatible string and not the SOC (lan9662 or lan9668) compatible string in lan966x.dtsi. In this case, the family compatible string can be seen as a kind of "wildcard".

I understood as "the "family" compatible should be present" as you want to add it as a fallback. It would be okay (assuming devices indeed share family design). If you want to use it as the only one, then it is again not a recommended approach. Please use specific compatibles.

Quoted 8 lines
Quoted 3 lines

I mean, why do we have this discussion? What is the benefit for you to implement something not-recommended by Devicetree spec and style?

Honestly, I would just go for microchip,lan9662-udc. There is no difference between lan9662 and lan9668 apart from the number of switch ports.

Sounds good.
I will do that.

Thanks,
Hervé

Signature · 3 lines
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#13 lore raw

PATCH 3/3 ARM: dts: lan966x: Add UDPHS support

In reply to Herve Codina

Add UDPHS (the USB High Speed Device Port controller) support. The UDPHS IP present in the lan966x SOC is the same as the one present in the SAMA5D3 SOC

---
 arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/lan966x.dtsi +11 -0
index 7d2869648050..4c09f3166d27 100644
@@ -211,6 +211,17 @@ can0: can@e081c000 {
 			status = "disabled";
 		};
 
+		udc: udphs@e0808000 {
+			compatible = "microchip,lan996x-udc",
+				     "atmel,sama5d3-udc";
+			reg = <0x00200000 0x80000>,
+			      <0xe0808000 0x400>;
+			interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&clks GCK_GATE_UDPHS>, <&nic_clk>;
+			clock-names = "pclk", "hclk";
+			status = "disabled";
+		};
+
 		gpio: pinctrl@e2004064 {
 			compatible = "microchip,lan966x-pinctrl";
 			reg = <0xe2004064 0xb4>,
Signature · 1 line
2.35.1
#14 lore raw

Re: [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support

Quoted 14 lines · Herve Codina

Add UDPHS (the USB High Speed Device Port controller) support. The UDPHS IP present in the lan966x SOC is the same as the one present in the SAMA5D3 SOC

---
 arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/lan966x.dtsi +0 -0
index 7d2869648050..4c09f3166d27 100644

arch/arm/boot/dts/lan966x.dtsi can0: can@e081c000 { · line 214

Quoted 4 lines
arch/arm/boot/dts/lan966x.dtsi +1 -0
@@ -211,6 +211,17 @@ can0: can@e081c000 {
 			status = "disabled";
 		};
 
+		udc: udphs@e0808000 {

Generic node names, so it looks like usb. For example HCD schema requires it. I am not sure which bindings are used here, but anyway once they might require usb...

Best regards,
Krzysztof

#15 lore raw

Re: [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support

Hi Krzysztof, Sergei

Quoted 18 lines · On Fri, 13 May 2022 14:54:26 +0200 Krzysztof Kozlowski…
Quoted 17 lines · Herve Codina

Add UDPHS (the USB High Speed Device Port controller) support. The UDPHS IP present in the lan966x SOC is the same as the one present in the SAMA5D3 SOC

---
 arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/lan966x.dtsi +0 -0
index 7d2869648050..4c09f3166d27 100644
@@ -211,6 +211,17 @@ can0: can@e081c000 {
 			status = "disabled";
 		};
 
Quoted 6 lines

arch/arm/boot/dts/lan966x.dtsi can0: can@e081c000 { · line 214

Quoted 1 line
arch/arm/boot/dts/lan966x.dtsi +1 -0
+		udc: udphs@e0808000 {  

Generic node names, so it looks like usb. For example HCD schema requires it. I am not sure which bindings are used here, but anyway once they might require usb...

HCD are related to the Host controller.
Here we are talking about a device.

In existing bindings related to USB device (or OTG as an OTG can be a host or a device) on several SOCs, we can find:
- usb1: gadget@fffa4000
- usb_otg: usb@1c13000
- usb: usb@47400000
- udc: usb@13040000
- usb_otg_hs: usb_otg_hs@4a0ab000

So I will change to
udc: usb@e0808000

Is that ok for you ?

Regards,
Herve

Signature · 3 lines
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#16 lore raw

Re: [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support

Quoted 17 lines · Herve Codina
Quoted 4 lines

Generic node names, so it looks like usb. For example HCD schema requires it. I am not sure which bindings are used here, but anyway once they might require usb...

HCD are related to the Host controller.
Here we are talking about a device.

In existing bindings related to USB device (or OTG as an OTG can be a host or a device) on several SOCs, we can find:
- usb1: gadget@fffa4000
- usb_otg: usb@1c13000
- usb: usb@47400000
- udc: usb@13040000
- usb_otg_hs: usb_otg_hs@4a0ab000

Quoted 4 lines

So I will change to
udc: usb@e0808000

Is that ok for you ?

Yes, I proposed usb.

Best regards,
Krzysztof

#17 lore raw

Re: [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support

In reply to Herve Codina

Hello!

Quoted 14 lines · Herve Codina

Add UDPHS (the USB High Speed Device Port controller) support. The UDPHS IP present in the lan966x SOC is the same as the one present in the SAMA5D3 SOC

---
 arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)
arch/arm/boot/dts/lan966x.dtsi +0 -0
index 7d2869648050..4c09f3166d27 100644

arch/arm/boot/dts/lan966x.dtsi can0: can@e081c000 { · line 214

Quoted 4 lines
arch/arm/boot/dts/lan966x.dtsi +1 -0
@@ -211,6 +211,17 @@ can0: can@e081c000 {
 			status = "disabled";
 		};
 
+		udc: udphs@e0808000 {

Shouldn't it be:

		udphs: udc@e0808000 {

(as the node names should be generic)?

[...]

MBR, Sergey