Skip to contentSkip to conversation

drm/i915: individualize fences before adding

PATCH In review Nirmoy Das 4 participants 4 messages May 13, 2022 – May 16, 2022

Subsystems (2)
lore
Share & tools
lore

Nirmoy Das

author
#0 lore raw

PATCH 1/1 drm/i915: individualize fences before adding

_i915_vma_move_to_active() can receive > 1 fence for multiple batch buffer submission so make sure to individualize fences before adding to dma_resv obj

---
 drivers/gpu/drm/i915/i915_vma.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_vma.c +13 -4
index 4f6db539571a..f987fc1264c0 100644
@@ -23,6 +23,7 @@
  */
 
 #include <linux/sched/mm.h>
+#include <linux/dma-fence-array.h>
 #include <drm/drm_gem.h>
 
 #include "display/intel_frontbuffer.h"
@@ -1840,8 +1841,12 @@ int _i915_vma_move_to_active(struct i915_vma *vma,
 		}
 
 		if (fence) {
-			dma_resv_add_fence(vma->obj->base.resv, fence,
-					   DMA_RESV_USAGE_WRITE);
+			int idx;
+			struct dma_fence *curr;
+
+			dma_fence_array_for_each(curr, idx, fence)
+				dma_resv_add_fence(vma->obj->base.resv, curr,
+						   DMA_RESV_USAGE_WRITE);
 			obj->write_domain = I915_GEM_DOMAIN_RENDER;
 			obj->read_domains = 0;
 		}
@@ -1853,8 +1858,12 @@ int _i915_vma_move_to_active(struct i915_vma *vma,
 		}
 
 		if (fence) {
-			dma_resv_add_fence(vma->obj->base.resv, fence,
-					   DMA_RESV_USAGE_READ);
+			int idx;
+			struct dma_fence *curr;
+
+			dma_fence_array_for_each(curr, idx, fence)
+				dma_resv_add_fence(vma->obj->base.resv, curr,
+						   DMA_RESV_USAGE_READ);
 			obj->write_domain = 0;
 		}
 	}
Signature · 1 line
2.35.1
#1 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: individualize fences before adding

== Series Details ==

== Series Details ==

Series: drm/i915: individualize fences before adding
URL : https://patchwork.freedesktop.org/series/103981/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11649 -> Patchwork_103981v1
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_103981v1 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_103981v1, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/index.html

Participating hosts (39 -> 40)
------------------------------

Additional (3): fi-blb-e6850 fi-icl-u2 bat-dg1-5
Missing (2): bat-adlm-1 bat-jsl-2

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_103981v1:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@gem:
- fi-blb-e6850: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-blb-e6850/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in Patchwork_103981v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@fbdev@write:
- bat-dg1-5: NOTRUN -> [SKIP][2] ([i915#2582]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]

* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][4] ([i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]

* igt@gem_mmap@basic:
- bat-dg1-5: NOTRUN -> [SKIP][5] ([i915#4083])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@gem_tiled_fence_blits@basic:
- bat-dg1-5: NOTRUN -> [SKIP][6] ([i915#4077]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@gem_tiled_pread_basic:
- bat-dg1-5: NOTRUN -> [SKIP][7] ([i915#4079]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@gem_tiled_pread_basic.html

* igt@i915_pm_backlight@basic-brightness:
- bat-dg1-5: NOTRUN -> [SKIP][8] ([i915#1155])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: NOTRUN -> [INCOMPLETE][9] ([i915#4418])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@i915_selftest@live@gt_engines.html

* igt@i915_selftest@live@gtt:
- fi-bdw-5557u: [PASS][10] -> [INCOMPLETE][11] ([i915#5685])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/fi-bdw-5557u/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-bdw-5557u/igt@i915_selftest@[email protected]

* igt@kms_addfb_basic@basic-y-tiled-legacy:
- bat-dg1-5: NOTRUN -> [SKIP][12] ([i915#4215])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@kms_addfb_basic@tile-pitch-mismatch:
- bat-dg1-5: NOTRUN -> [SKIP][13] ([i915#4212]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@kms_busy@basic:
- bat-dg1-5: NOTRUN -> [SKIP][14] ([i915#4303])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][15] ([fdo#109271] / [fdo#111827])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-hsw-4770/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][16] ([fdo#111827]) +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][17] ([fdo#111827]) +7 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][18] ([fdo#109278]) +2 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][19] ([i915#4103] / [i915#4213]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@kms_flip@basic-flip-vs-dpms:
- bat-dg1-5: NOTRUN -> [SKIP][20] ([i915#4078]) +23 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- bat-dg1-5: NOTRUN -> [SKIP][21] ([fdo#109285])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]
- fi-icl-u2: NOTRUN -> [SKIP][22] ([fdo#109285])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]

* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-blb-e6850: NOTRUN -> [SKIP][23] ([fdo#109271]) +39 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-blb-e6850/igt@[email protected]

* igt@kms_psr@primary_page_flip:
- bat-dg1-5: NOTRUN -> [SKIP][24] ([i915#1072] / [i915#4078]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@kms_psr@primary_page_flip.html

* igt@kms_setmode@basic-clone-single-crtc:
- fi-icl-u2: NOTRUN -> [SKIP][25] ([i915#3555])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][26] ([i915#3555])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@prime_vgem@basic-fence-mmap:
- bat-dg1-5: NOTRUN -> [SKIP][27] ([i915#3708] / [i915#4077]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][28] ([i915#3301])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][29] ([i915#3708] / [i915#4873])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@prime_vgem@basic-write:
- bat-dg1-5: NOTRUN -> [SKIP][30] ([i915#3708]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]

* igt@runner@aborted:
- bat-dg1-5: NOTRUN -> [FAIL][31] ([i915#4312] / [i915#5257])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]
- fi-blb-e6850: NOTRUN -> [FAIL][32] ([fdo#109271] / [i915#2403] / [i915#4312])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-blb-e6850/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0@smem:
- {fi-ehl-2}: [DMESG-WARN][33] ([i915#5122]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/fi-ehl-2/igt@gem_exec_suspend@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-ehl-2/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@gt_heartbeat:
- {fi-jsl-1}: [DMESG-FAIL][35] ([i915#5334]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/fi-jsl-1/igt@i915_selftest@live@gt_heartbeat.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-jsl-1/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][37] ([i915#4785]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/fi-hsw-4770/igt@i915_selftest@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@i915_suspend@system-suspend-without-i915:
- {bat-dg2-9}: [DMESG-WARN][39] ([i915#5763]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/bat-dg2-9/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg2-9/igt@[email protected]

* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- {bat-adlp-6}: [DMESG-WARN][41] ([i915#3576]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/bat-adlp-6/igt@kms_flip@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-adlp-6/igt@kms_flip@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4303]: https://gitlab.freedesktop.org/drm/intel/issues/4303
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5685]: https://gitlab.freedesktop.org/drm/intel/issues/5685
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5879]: https://gitlab.freedesktop.org/drm/intel/issues/5879
[i915#5950]: https://gitlab.freedesktop.org/drm/intel/issues/5950

Build changes
-------------

* Linux: CI_DRM_11649 -> Patchwork_103981v1

CI-20190529: 20190529
CI_DRM_11649: 41053495dd77aa5604144477ef59334a9492a169 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6472: c815c94f0ceb33ae852622538f0136cf44c5725d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103981v1: 41053495dd77aa5604144477ef59334a9492a169 @ git://anongit.freedesktop.org/gfx-ci/linux

### Linux commits

4a604aeca9d8 drm/i915: individualize fences before adding

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/index.html

#2 lore raw

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: individualize fences before adding

Quoted 35 lines · Patchwork

Project List - Patchwork *Patch Details*
*Series:* drm/i915: individualize fences before adding
*URL:* https://patchwork.freedesktop.org/series/103981/
*State:* failure
*Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/index.html

CI Bug Log - changes from CI_DRM_11649 -> Patchwork_103981v1

Summary

*FAILURE*

Serious unknown changes coming with Patchwork_103981v1 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_103981v1, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/index.html

    Participating hosts (39 -> 40)

Additional (3): fi-blb-e6850 fi-icl-u2 bat-dg1-5
Missing (2): bat-adlm-1 bat-jsl-2

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_103981v1:

Quoted 9 lines

IGT changes

Possible regressions

* igt@i915_selftest@live@gem:
o fi-blb-e6850: NOTRUN -> INCOMPLETE
<https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-blb-e6850/igt@i915_selftest@[email protected]>

Unrelated and this test on blb is failing for a while https://intel-gfx-ci.01.org/tree/drm-tip/fi-blb-e6850.html

Nirmoy

Quoted 353 lines

*

Known issues

Here are the changes found in Patchwork_103981v1 that come from known issues:

IGT changes

Issues hit

*

    igt@fbdev@write:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#2582
        <https://gitlab.freedesktop.org/drm/intel/issues/2582>) +4
        similar issues

*

    igt@gem_huc_copy@huc-copy:

      o fi-icl-u2: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]>
        (i915#2190 <https://gitlab.freedesktop.org/drm/intel/issues/2190>)

*

    igt@gem_lmem_swapping@parallel-random-engines:

      o fi-icl-u2: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]>
        (i915#4613
        <https://gitlab.freedesktop.org/drm/intel/issues/4613>) +3
        similar issues

*

    igt@gem_mmap@basic:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#4083 <https://gitlab.freedesktop.org/drm/intel/issues/4083>)

*

    igt@gem_tiled_fence_blits@basic:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#4077
        <https://gitlab.freedesktop.org/drm/intel/issues/4077>) +2
        similar issues

*

    igt@gem_tiled_pread_basic:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@gem_tiled_pread_basic.html>
        (i915#4079
        <https://gitlab.freedesktop.org/drm/intel/issues/4079>) +1
        similar issue

*

    igt@i915_pm_backlight@basic-brightness:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#1155 <https://gitlab.freedesktop.org/drm/intel/issues/1155>)

*

    igt@i915_selftest@live@gt_engines:

      o bat-dg1-5: NOTRUN -> INCOMPLETE
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@i915_selftest@live@gt_engines.html>
        (i915#4418 <https://gitlab.freedesktop.org/drm/intel/issues/4418>)

*

    igt@i915_selftest@live@gtt:

      o fi-bdw-5557u: PASS
        <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/fi-bdw-5557u/igt@i915_selftest@[email protected]>
        -> INCOMPLETE
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-bdw-5557u/igt@i915_selftest@[email protected]>
        (i915#5685 <https://gitlab.freedesktop.org/drm/intel/issues/5685>)

*

    igt@kms_addfb_basic@basic-y-tiled-legacy:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#4215 <https://gitlab.freedesktop.org/drm/intel/issues/4215>)

*

    igt@kms_addfb_basic@tile-pitch-mismatch:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#4212
        <https://gitlab.freedesktop.org/drm/intel/issues/4212>) +7
        similar issues

*

    igt@kms_busy@basic:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#4303 <https://gitlab.freedesktop.org/drm/intel/issues/4303>)

*

    igt@kms_chamelium@common-hpd-after-suspend:

      o fi-hsw-4770: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-hsw-4770/igt@[email protected]>
        (fdo#109271
        <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
        fdo#111827 <https://bugs.freedesktop.org/show_bug.cgi?id=111827>)

*

    igt@kms_chamelium@hdmi-hpd-fast:

     o

        fi-icl-u2: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]>
        (fdo#111827
        <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +8
        similar issues

     o

        bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (fdo#111827
        <https://bugs.freedesktop.org/show_bug.cgi?id=111827>) +7
        similar issues

*

    igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:

     o

        fi-icl-u2: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]>
        (fdo#109278
        <https://bugs.freedesktop.org/show_bug.cgi?id=109278>) +2
        similar issues

     o

        bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#4103
        <https://gitlab.freedesktop.org/drm/intel/issues/4103> /
        i915#4213
        <https://gitlab.freedesktop.org/drm/intel/issues/4213>) +1
        similar issue

*

    igt@kms_flip@basic-flip-vs-dpms:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#4078
        <https://gitlab.freedesktop.org/drm/intel/issues/4078>) +23
        similar issues

*

    igt@kms_force_connector_basic@force-load-detect:

     o

        bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (fdo#109285 <https://bugs.freedesktop.org/show_bug.cgi?id=109285>)

     o

        fi-icl-u2: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]>
        (fdo#109285 <https://bugs.freedesktop.org/show_bug.cgi?id=109285>)

*

    igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:

      o fi-blb-e6850: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-blb-e6850/igt@[email protected]>
        (fdo#109271
        <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +39
        similar issues

*

    igt@kms_psr@primary_page_flip:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@kms_psr@primary_page_flip.html>
        (i915#1072
        <https://gitlab.freedesktop.org/drm/intel/issues/1072> /
        i915#4078
        <https://gitlab.freedesktop.org/drm/intel/issues/4078>) +3
        similar issues

*

    igt@kms_setmode@basic-clone-single-crtc:

     o

        fi-icl-u2: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]>
        (i915#3555 <https://gitlab.freedesktop.org/drm/intel/issues/3555>)

     o

        bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#3555 <https://gitlab.freedesktop.org/drm/intel/issues/3555>)

*

    igt@prime_vgem@basic-fence-mmap:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#3708
        <https://gitlab.freedesktop.org/drm/intel/issues/3708> /
        i915#4077
        <https://gitlab.freedesktop.org/drm/intel/issues/4077>) +1
        similar issue

*

    igt@prime_vgem@basic-userptr:

     o

        fi-icl-u2: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-icl-u2/igt@[email protected]>
        (i915#3301 <https://gitlab.freedesktop.org/drm/intel/issues/3301>)

     o

        bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#3708
        <https://gitlab.freedesktop.org/drm/intel/issues/3708> /
        i915#4873 <https://gitlab.freedesktop.org/drm/intel/issues/4873>)

*

    igt@prime_vgem@basic-write:

      o bat-dg1-5: NOTRUN -> SKIP
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#3708
        <https://gitlab.freedesktop.org/drm/intel/issues/3708>) +3
        similar issues

*

    igt@runner@aborted:

     o

        bat-dg1-5: NOTRUN -> FAIL
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg1-5/igt@[email protected]>
        (i915#4312
        <https://gitlab.freedesktop.org/drm/intel/issues/4312> /
        i915#5257 <https://gitlab.freedesktop.org/drm/intel/issues/5257>)

     o

        fi-blb-e6850: NOTRUN -> FAIL
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-blb-e6850/igt@[email protected]>
        (fdo#109271
        <https://bugs.freedesktop.org/show_bug.cgi?id=109271> /
        i915#2403
        <https://gitlab.freedesktop.org/drm/intel/issues/2403> /
        i915#4312 <https://gitlab.freedesktop.org/drm/intel/issues/4312>)


        Possible fixes

*

    igt@gem_exec_suspend@basic-s0@smem:

      o {fi-ehl-2}: DMESG-WARN
        <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/fi-ehl-2/igt@gem_exec_suspend@[email protected]>
        (i915#5122
        <https://gitlab.freedesktop.org/drm/intel/issues/5122>) ->
        PASS
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-ehl-2/igt@gem_exec_suspend@[email protected]>

*

    igt@i915_selftest@live@gt_heartbeat:

      o {fi-jsl-1}: DMESG-FAIL
        <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/fi-jsl-1/igt@i915_selftest@live@gt_heartbeat.html>
        (i915#5334
        <https://gitlab.freedesktop.org/drm/intel/issues/5334>) ->
        PASS
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-jsl-1/igt@i915_selftest@live@gt_heartbeat.html>

*

    igt@i915_selftest@live@hangcheck:

      o fi-hsw-4770: INCOMPLETE
        <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/fi-hsw-4770/igt@i915_selftest@[email protected]>
        (i915#4785
        <https://gitlab.freedesktop.org/drm/intel/issues/4785>) ->
        PASS
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/fi-hsw-4770/igt@i915_selftest@[email protected]>

*

    igt@i915_suspend@system-suspend-without-i915:

      o {bat-dg2-9}: DMESG-WARN
        <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/bat-dg2-9/igt@[email protected]>
        (i915#5763
        <https://gitlab.freedesktop.org/drm/intel/issues/5763>) ->
        PASS
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-dg2-9/igt@[email protected]>

*

    igt@kms_flip@basic-flip-vs-modeset@a-edp1:

      o {bat-adlp-6}: DMESG-WARN
        <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11649/bat-adlp-6/igt@kms_flip@[email protected]>
        (i915#3576
        <https://gitlab.freedesktop.org/drm/intel/issues/3576>) ->
        PASS
        <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103981v1/bat-adlp-6/igt@kms_flip@[email protected]>

{name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE).

Build changes

* Linux: CI_DRM_11649 -> Patchwork_103981v1

CI-20190529: 20190529
CI_DRM_11649: 41053495dd77aa5604144477ef59334a9492a169 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6472: c815c94f0ceb33ae852622538f0136cf44c5725d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103981v1: 41053495dd77aa5604144477ef59334a9492a169 @ git://anongit.freedesktop.org/gfx-ci/linux

Linux commits

4a604aeca9d8 drm/i915: individualize fences before adding

Reviewed-by Thomas Hellström on v1 1/1
#3 lore raw
In reply to Nirmoy Das

Hi Nirmoy.

Quoted 6 lines · Nirmoy Das

_i915_vma_move_to_active() can receive > 1 fence for multiple batch buffer submission so make sure to individualize fences before adding to dma_resv obj

LGTM.

Quoted 55 lines

---
 drivers/gpu/drm/i915/i915_vma.c | 17 +++++++++++++----

 1 file changed, 13 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_vma.c +0 -0
index 4f6db539571a..f987fc1264c0 100644
@@ -23,6 +23,7 @@
   */


 #include <linux/sched/mm.h>
+#include <linux/dma-fence-array.h>
 #include <drm/drm_gem.h>

 #include "display/intel_frontbuffer.h"

drivers/gpu/drm/i915/i915_vma.c +0 -0
@@ -1840,8 +1841,12 @@ int _i915_vma_move_to_active(struct i915_vma
 *vma,
                 }


                if (fence) {
-                       dma_resv_add_fence(vma->obj->base.resv, fence,
-                                          DMA_RESV_USAGE_WRITE); +                       int idx;
+                       struct dma_fence *curr;
+
+                       dma_fence_array_for_each(curr, idx, fence) +                               dma_resv_add_fence(vma->obj-

Quoted 1 line

base.resv, curr,

+
DMA_RESV_USAGE_WRITE);
                        obj->write_domain = I915_GEM_DOMAIN_RENDER; obj->read_domains = 0;
                }

drivers/gpu/drm/i915/i915_vma.c +0 -0
@@ -1853,8 +1858,12 @@ int _i915_vma_move_to_active(struct i915_vma
 *vma,
                 }


                if (fence) {
-                       dma_resv_add_fence(vma->obj->base.resv, fence,
-                                          DMA_RESV_USAGE_READ); +                       int idx;
+                       struct dma_fence *curr;
+
+                       dma_fence_array_for_each(curr, idx, fence) +                               dma_resv_add_fence(vma->obj-

Quoted 1 line

base.resv, curr,

+
DMA_RESV_USAGE_READ);
                        obj->write_domain = 0;
                }
        }