Skip to contentSkip to conversation

scripts: kconfig: nconf: make nconfig accept jk keybindings

PATCH In review Isak Ellmer 2 participants 2 messages May 16, 2022 – May 23, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scripts: kconfig: nconf: make nconfig accept jk keybindings

Make nconfig accept jk keybindings for movement in addition to arrow keys.

---
 scripts/kconfig/nconf.c | 4 ++++
 1 file changed, 4 insertions(+)
scripts/kconfig/nconf.c +4 -0
index 7b371bd7fb36..ded40e5aabf8 100644
@@ -1105,9 +1105,11 @@ static void conf(struct menu *menu)
 				break;
 			switch (res) {
 			case KEY_DOWN:
+			case 'j':
 				menu_driver(curses_menu, REQ_DOWN_ITEM);
 				break;
 			case KEY_UP:
+			case 'k':
 				menu_driver(curses_menu, REQ_UP_ITEM);
 				break;
 			case KEY_NPAGE:
@@ -1287,9 +1289,11 @@ static void conf_choice(struct menu *menu)
 				break;
 			switch (res) {
 			case KEY_DOWN:
+			case 'j':
 				menu_driver(curses_menu, REQ_DOWN_ITEM);
 				break;
 			case KEY_UP:
+			case 'k':
 				menu_driver(curses_menu, REQ_UP_ITEM);
 				break;
 			case KEY_NPAGE:
Signature · 1 line
2.35.1
#1 lore raw
Quoted 5 lines · Isak Ellmer

Make nconfig accept jk keybindings for movement in addition to arrow keys.

---

I am fine with this.

Can you update the help message?

Around line 55:

"Linewise up <Up>\n"
"Linewise down <Down>\n"

Quoted 34 lines
 scripts/kconfig/nconf.c | 4 ++++
 1 file changed, 4 insertions(+)
scripts/kconfig/nconf.c +4 -1
index 7b371bd7fb36..ded40e5aabf8 100644
@@ -1105,9 +1105,11 @@ static void conf(struct menu *menu)
                                break;
                        switch (res) {
                        case KEY_DOWN:
+                       case 'j':
                                menu_driver(curses_menu, REQ_DOWN_ITEM);
                                break;
                        case KEY_UP:
+                       case 'k':
                                menu_driver(curses_menu, REQ_UP_ITEM);
                                break;
                        case KEY_NPAGE:
@@ -1287,9 +1289,11 @@ static void conf_choice(struct menu *menu)
                                break;
                        switch (res) {
                        case KEY_DOWN:
+                       case 'j':
                                menu_driver(curses_menu, REQ_DOWN_ITEM);
                                break;
                        case KEY_UP:
+                       case 'k':
                                menu_driver(curses_menu, REQ_UP_ITEM);
                                break;
                        case KEY_NPAGE:
--

2.35.1

Signature · 2 lines
Best Regards
Masahiro Yamada