nvme: split the enum used for various register constants
Christoph Hellwig
maintainerPATCH 1/1 nvme: split the enum used for various register constants
Instead of having one big enum add one for each register or field.
Signed-off-by Christoph Hellwig <[email protected]>
--- include/linux/nvme.h | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)
include/linux/nvme.h +11 -2
@@ -204,8 +204,9 @@ enum {NVME_CC_SHN_MASK =3 <<NVME_CC_SHN_SHIFT ,NVME_CC_IOSQES =NVME_NVM_IOSQES <<NVME_CC_IOSQES_SHIFT , NVME_CC_IOCQES = NVME_NVM_IOCQES << NVME_CC_IOCQES_SHIFT, -NVME_CAP_CSS_NVM =1 <<0 , -NVME_CAP_CSS_CSI =1 <<6 , +}; + +enum {NVME_CSTS_RDY =1 <<0 ,NVME_CSTS_CFS =1 <<1 , NVME_CSTS_NSSRO = 1 << 4,
@@ -214,10 +215,18 @@ enum {NVME_CSTS_SHST_OCCUR =1 <<2 ,NVME_CSTS_SHST_CMPLT =2 <<2 , NVME_CSTS_SHST_MASK = 3 << 2, +}; + +enum {NVME_CMBMSC_CRE =1 <<0 ,NVME_CMBMSC_CMSE =1 <<1 , }; +enum { +NVME_CAP_CSS_NVM =1 <<0 , +NVME_CAP_CSS_CSI =1 <<6 , +}; +struct nvme_id_power_state {__le16 max_power;/* centiwatts */ __u8 rsvd2;
Signature · 1 line
2.30.2
Quoted 4 lines · Christoph Hellwig
Instead of having one big enum add one for each register or field.
Signed-off-by Christoph Hellwig <[email protected]>---
Looks good.
Reviewed-by Chaitanya Kulkarni <[email protected]>
-ck
Quoted 3 lines · Christoph Hellwig
Instead of having one big enum add one for each register or field.
Signed-off-by Christoph Hellwig <[email protected]>
Looks good.
Reviewed-by Keith Busch <[email protected]>