Skip to contentSkip to conversation

media: Kconfig: Make DVB_CORE=m possible when MEDIA_SUPPORT=y

PATCH New Lecopzer Chen 1 participant 3 messages May 16, 2022 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

v3 cover media: Kconfig: Make DVB_CORE=m possible when MEDIA_SUPPORT=y

A case that CONFIG_MEDIA_SUPPORT is y but we need DVB_CORE=m, and this doesn't work since DVB_CORE is default MEDIA_DIGITAL_TV_SUPPORT and then follows MEDIA_SUPPORT.

After DVB_CORE can change manually, following patches fix the cases with new combination of media config.

Lecopzer Chen (2):
media: mantis: Kconfig: add depends on DVB_CORE for MANTIS_CORE
media: Kconfig: Make DVB_CORE=m possible when MEDIA_SUPPORT=y

 drivers/media/Kconfig            | 2 +-
 drivers/media/pci/mantis/Kconfig | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.18.0
#1 lore raw

PATCH v3 1/2 media: mantis: Kconfig: add depends on DVB_CORE for MANTIS_CORE

MANTIS_CORE needs DVB_CORE, set 'depends on' explicitly

ERROR: modpost: "dvb_dmx_init" [drivers/media/pci/mantis/mantis_core.ko] undefined!
ERROR: modpost: "dvb_unregister_adapter" [drivers/media/pci/mantis/mantis_core.ko] undefined!
ERROR: modpost: "dvb_register_frontend" [drivers/media/pci/mantis/mantis_core.ko] undefined!
ERROR: modpost: "dvb_ca_en50221_camchange_irq" [drivers/media/pci/mantis/mantis_core.ko] undefined!
ERROR: modpost: "dvb_unregister_frontend" [drivers/media/pci/mantis/mantis_core.ko] undefined!

Quoted 4 lines
Quoted 4 lines

ERROR: modpost: "dvb_ca_en50221_camready_irq" [drivers/media/pci/mantis/mantis_core.ko] undefined!
ERROR: modpost: "dvb_frontend_detach" [drivers/media/pci/mantis/mantis_core.ko] undefined!
ERROR: modpost: "dvb_dmxdev_release" [drivers/media/pci/mantis/mantis_core.ko] undefined!
ERROR: modpost: "dvb_dmx_swfilter" [drivers/media/pci/mantis/mantis_core.ko] undefined!

---
 drivers/media/pci/mantis/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/pci/mantis/Kconfig +1 -1
index 9dfaf2c9a7b3..374b8f382f62 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config MANTIS_CORE
 	tristate "Mantis/Hopper PCI bridge based devices"
-	depends on PCI && I2C && INPUT && RC_CORE
+	depends on PCI && I2C && INPUT && RC_CORE && DVB_CORE
 
 	help
 	  Support for PCI cards based on the Mantis and Hopper PCi bridge.
Signature · 1 line
2.18.0
#2 lore raw

PATCH v3 2/2 media: Kconfig: Make DVB_CORE=m possible when MEDIA_SUPPORT=y

In reply to Lecopzer Chen

A case that CONFIG_MEDIA_SUPPORT is y but we need DVB_CORE=m, and this doesn't work since DVB_CORE is default MEDIA_DIGITAL_TV_SUPPORT and then follows MEDIA_SUPPORT.

---
 drivers/media/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/Kconfig +1 -1
index ba6592b3dab2..c64bba94f950 100644
@@ -182,7 +182,7 @@ config MEDIA_CONTROLLER
 #
 
 config DVB_CORE
-	tristate
+	tristate "DVB Core"
 	depends on MEDIA_DIGITAL_TV_SUPPORT
 	depends on (I2C || I2C=n)
 	default MEDIA_DIGITAL_TV_SUPPORT
Signature · 1 line
2.18.0