Skip to contentSkip to conversation

fstests: add a btrfs read_repair group

PATCH In review Christoph Hellwig 3 participants 3 messages May 17, 2022 Btrfs file system

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fstests: add a btrfs read_repair group

Add a new group to run all tests the exercise the btrfs read_repair code.

---
 doc/group-names.txt | 1 +
 tests/btrfs/140     | 2 +-
 tests/btrfs/141     | 2 +-
 tests/btrfs/142     | 2 +-
 tests/btrfs/143     | 2 +-
 tests/btrfs/150     | 2 +-
 tests/btrfs/157     | 2 +-
 tests/btrfs/215     | 2 +-
 8 files changed, 8 insertions(+), 7 deletions(-)
doc/group-names.txt +1 -0
index e8e3477e..ef411b5e 100644
@@ -88,6 +88,7 @@ punch			fallocate FALLOC_FL_PUNCH_HOLE
 qgroup			btrfs qgroup feature
 quota			filesystem usage quotas
 raid			btrfs RAID
+read_repair		btrfs error correction on read failure
 realtime		XFS realtime volumes
 recoveryloop		crash recovery loops
 redirect		overlayfs redirect_dir feature
tests/btrfs/140 +1 -1
index 66efc126..c680fe0a 100755
@@ -12,7 +12,7 @@
 #	commit 2e949b0a5592 ("Btrfs: fix invalid dereference in btrfs_retry_endio")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/141 +1 -1
index ca164fdc..9fdcb2ab 100755
@@ -13,7 +13,7 @@
 #	Commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/142 +1 -1
index c88cace9..58d01add 100755
@@ -13,7 +13,7 @@
 #	commit 97bf5a5589aa ("Btrfs: fix segmentation fault when doing dio read")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/143 +1 -1
index 8f086ee8..71db861d 100755
@@ -20,7 +20,7 @@
 #	commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/150 +1 -1
index 986c8069..c5e9c709 100755
@@ -11,7 +11,7 @@
 #	Btrfs: fix kernel oops while reading compressed data
 #
 . ./common/preamble
-_begin_fstest auto quick dangerous
+_begin_fstest auto quick dangerous read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/157 +1 -1
index ae56f3e1..343178b7 100755
@@ -21,7 +21,7 @@
 # Btrfs: make raid6 rebuild retry more
 #
 . ./common/preamble
-_begin_fstest auto quick raid
+_begin_fstest auto quick raid read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/215 +1 -1
index cbcd60e0..0dcbce2a 100755
@@ -9,7 +9,7 @@
 # 814723e0a55a ("btrfs: increment device corruption error in case of checksum error")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Christoph Hellwig

Add a new group to run all tests the exercise the btrfs read_repair code.

---

There's not objection from me to add this new group for btrfs. If btrfs forks have more review points, feel free to point out.

Quoted 116 lines
 doc/group-names.txt | 1 +
 tests/btrfs/140     | 2 +-
 tests/btrfs/141     | 2 +-
 tests/btrfs/142     | 2 +-
 tests/btrfs/143     | 2 +-
 tests/btrfs/150     | 2 +-
 tests/btrfs/157     | 2 +-
 tests/btrfs/215     | 2 +-
 8 files changed, 8 insertions(+), 7 deletions(-)
doc/group-names.txt +1 -0
index e8e3477e..ef411b5e 100644
@@ -88,6 +88,7 @@ punch			fallocate FALLOC_FL_PUNCH_HOLE
 qgroup			btrfs qgroup feature
 quota			filesystem usage quotas
 raid			btrfs RAID
+read_repair		btrfs error correction on read failure
 realtime		XFS realtime volumes
 recoveryloop		crash recovery loops
 redirect		overlayfs redirect_dir feature
tests/btrfs/140 +1 -1
index 66efc126..c680fe0a 100755
@@ -12,7 +12,7 @@
 #	commit 2e949b0a5592 ("Btrfs: fix invalid dereference in btrfs_retry_endio")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/141 +1 -1
index ca164fdc..9fdcb2ab 100755
@@ -13,7 +13,7 @@
 #	Commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/142 +1 -1
index c88cace9..58d01add 100755
@@ -13,7 +13,7 @@
 #	commit 97bf5a5589aa ("Btrfs: fix segmentation fault when doing dio read")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/143 +1 -1
index 8f086ee8..71db861d 100755
@@ -20,7 +20,7 @@
 #	commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/150 +1 -1
index 986c8069..c5e9c709 100755
@@ -11,7 +11,7 @@
 #	Btrfs: fix kernel oops while reading compressed data
 #
 . ./common/preamble
-_begin_fstest auto quick dangerous
+_begin_fstest auto quick dangerous read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/157 +1 -1
index ae56f3e1..343178b7 100755
@@ -21,7 +21,7 @@
 # Btrfs: make raid6 rebuild retry more
 #
 . ./common/preamble
-_begin_fstest auto quick raid
+_begin_fstest auto quick raid read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/215 +1 -1
index cbcd60e0..0dcbce2a 100755
@@ -9,7 +9,7 @@
 # 814723e0a55a ("btrfs: increment device corruption error in case of checksum error")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#2 lore raw
In reply to Christoph Hellwig
Quoted 3 lines · Christoph Hellwig

Add a new group to run all tests the exercise the btrfs read_repair code.

Looks good to me as well, thanks.

Quoted 117 lines
---
 doc/group-names.txt | 1 +
 tests/btrfs/140     | 2 +-
 tests/btrfs/141     | 2 +-
 tests/btrfs/142     | 2 +-
 tests/btrfs/143     | 2 +-
 tests/btrfs/150     | 2 +-
 tests/btrfs/157     | 2 +-
 tests/btrfs/215     | 2 +-
 8 files changed, 8 insertions(+), 7 deletions(-)
doc/group-names.txt +1 -0
index e8e3477e..ef411b5e 100644
@@ -88,6 +88,7 @@ punch			fallocate FALLOC_FL_PUNCH_HOLE
 qgroup			btrfs qgroup feature
 quota			filesystem usage quotas
 raid			btrfs RAID
+read_repair		btrfs error correction on read failure
 realtime		XFS realtime volumes
 recoveryloop		crash recovery loops
 redirect		overlayfs redirect_dir feature
tests/btrfs/140 +1 -1
index 66efc126..c680fe0a 100755
@@ -12,7 +12,7 @@
 #	commit 2e949b0a5592 ("Btrfs: fix invalid dereference in btrfs_retry_endio")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/141 +1 -1
index ca164fdc..9fdcb2ab 100755
@@ -13,7 +13,7 @@
 #	Commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/142 +1 -1
index c88cace9..58d01add 100755
@@ -13,7 +13,7 @@
 #	commit 97bf5a5589aa ("Btrfs: fix segmentation fault when doing dio read")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/143 +1 -1
index 8f086ee8..71db861d 100755
@@ -20,7 +20,7 @@
 #	commit 9d0d1c8b1c9d ("Btrfs: bring back repair during read")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/150 +1 -1
index 986c8069..c5e9c709 100755
@@ -11,7 +11,7 @@
 #	Btrfs: fix kernel oops while reading compressed data
 #
 . ./common/preamble
-_begin_fstest auto quick dangerous
+_begin_fstest auto quick dangerous read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/157 +1 -1
index ae56f3e1..343178b7 100755
@@ -21,7 +21,7 @@
 # Btrfs: make raid6 rebuild retry more
 #
 . ./common/preamble
-_begin_fstest auto quick raid
+_begin_fstest auto quick raid read_repair
 
 # Import common functions.
 . ./common/filter
tests/btrfs/215 +1 -1
index cbcd60e0..0dcbce2a 100755
@@ -9,7 +9,7 @@
 # 814723e0a55a ("btrfs: increment device corruption error in case of checksum error")
 #
 . ./common/preamble
-_begin_fstest auto quick
+_begin_fstest auto quick read_repair
 
 # Import common functions.
 . ./common/filter
Signature · 1 line
2.30.2