fs/ntfs: remove redundant variable idx
Subsystems (2)
PATCH 1/1 fs/ntfs: remove redundant variable idx
The variable idx is assigned a value and is never read. The variable is not used and is redundant, remove it.
Cleans up clang scan build warning:
warning: Although the value stored to 'idx' is used in the enclosing expression, the value is never actually read from 'idx' [deadcode.DeadStores]
--- fs/ntfs/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ntfs/file.c +2 -2
@@ -1772,11 +1772,11 @@ static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i, last_vcn =-1 ; do { VCN vcn; - pgoff_t idx, start_idx; + pgoff_t start_idx; unsigned ofs, do_pages, u; size_t copied; - start_idx = idx = pos >> PAGE_SHIFT; + start_idx = pos >> PAGE_SHIFT; ofs = pos & ~PAGE_MASK; bytes = PAGE_SIZE - ofs; do_pages = 1;
Signature · 1 line
2.35.1
PATCH 1/1 fs/ntfs: remove redundant variable idx
The variable idx is assigned a value and is never read. The variable is not used and is redundant, remove it.
Cleans up clang scan build warning:
warning: Although the value stored to 'idx' is used in the enclosing expression, the value is never actually read from 'idx' [deadcode.DeadStores]
--- fs/ntfs/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ntfs/file.c +2 -2
@@ -1772,11 +1772,11 @@ static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i, last_vcn =-1 ; do { VCN vcn; - pgoff_t idx, start_idx; + pgoff_t start_idx; unsigned ofs, do_pages, u; size_t copied; - start_idx = idx = pos >> PAGE_SHIFT; + start_idx = pos >> PAGE_SHIFT; ofs = pos & ~PAGE_MASK; bytes = PAGE_SIZE - ofs; do_pages = 1;
Signature · 1 line
2.35.1
Hi Andrew,
Please could you merge this? Thanks a lot!
Best regards,
Anton
Quoted 11 lines · Colin Ian King
The variable idx is assigned a value and is never read. The variable is not used and is redundant, remove it.
Cleans up clang scan build warning:
warning: Although the value stored to 'idx' is used in the enclosing expression, the value is never actually read from 'idx' [deadcode.DeadStores]Signed-off-by Colin Ian King <[email protected]>
Quoted 25 lines
---
fs/ntfs/file.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)fs/ntfs/file.c +2
-2@@ -1772,11 +1772,11 @@ static ssize_t ntfs_perform_write(struct file *file, struct iov_iter *i, last_vcn =-1 ; do { VCN vcn; - pgoff_t idx, start_idx; + pgoff_t start_idx; unsigned ofs, do_pages, u; size_t copied; - start_idx = idx = pos >> PAGE_SHIFT; + start_idx = pos >> PAGE_SHIFT; ofs = pos & ~PAGE_MASK; bytes = PAGE_SIZE - ofs; do_pages = 1;Signature · 1 line
2.35.1