net: fec: Avoid to allocate rx buffer using ATOMIC in ndo_open
Subsystems (3)
RFC PATCH 1/1 net: fec: Avoid to allocate rx buffer using ATOMIC in ndo_open
Signed-off-by Michael Trimarchi <[email protected]>
--- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/freescale/fec_main.c +1 -1
@@ -3076,7 +3076,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue) rxq = fep->rx_queue[queue]; bdp = rxq->bd.base;for (i =0 ; i < rxq->bd.ring_size; i++) { - skb =netdev_alloc_skb (ndev,FEC_ENET_RX_FRSIZE ); + skb =__netdev_alloc_skb (ndev,FEC_ENET_RX_FRSIZE ,GFP_KERNEL );if (!skb) goto err_alloc;
Signature · 1 line
2.25.1
Jakub Kicinski
maintainerQuoted 1 line · On Tue, 17 May 2022 12:05:44 +0200 Michael Trimarchi wrote:
Subject: [RFC PATCH] net: fec: Avoid to allocate rx buffer using ATOMIC in
ndo_open
nit: "Avoid allocating"
We need a commit message, guessing your motivation something like this would be enough IMHO:
Make ndo_open less sensitive to memory pressure.
Quoted 10 lines
Signed-off-by Michael Trimarchi <[email protected]>--- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/net/ethernet/freescale/fec_main.c +0
-0
drivers/net/ethernet/freescale/fec_main.c fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue) · line 3082
Quoted 8 lines
drivers/net/ethernet/freescale/fec_main.c +1
-1@@ -3076,7 +3076,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue) rxq = fep->rx_queue[queue]; bdp = rxq->bd.base;for (i =0 ; i < rxq->bd.ring_size; i++) { - skb =netdev_alloc_skb (ndev,FEC_ENET_RX_FRSIZE ); + skb =__netdev_alloc_skb (ndev,FEC_ENET_RX_FRSIZE ,GFP_KERNEL );if (!skb) goto err_alloc;
The patch LGTM, feel free to repost as non-RFC.