Skip to contentSkip to conversation

binder: convert `BINDER_*` ioctl `#define`s into an `enum`

PATCH In review Miguel Ojeda 3 participants 3 messages May 17, 2022 – May 19, 2022 Rust

lore
Share & tools
lore

Miguel Ojeda

author maintainer
#0 lore raw

PATCH v2 1/1 binder: convert `BINDER_*` ioctl `#define`s into an `enum`

bindgen (a tool which generates the "raw" C bindings for Rust) only works (so far) with "simple" C #defines. In order to avoid having to manually maintain these constants in the (potential) Rust side, this patch converts them into an enum.

There may be support in the future for expanding macros that end up in a "numeric" one: https://github.com/rust-lang/rust-bindgen/issues/753.

---
v2:
- Rebased on top of Greg's char-misc-next.
- Added Link tag for future reference.

v1: https://lore.kernel.org/lkml/[email protected]/

 include/uapi/linux/android/binder.h | 30 +++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)
include/uapi/linux/android/binder.h +16 -14
index e6ee8cae303b..a4c3e750168a 100644
@@ -251,20 +251,22 @@ struct binder_extended_error {
 	__s32	param;
 };
 
-#define BINDER_WRITE_READ		_IOWR('b', 1, struct binder_write_read)
-#define BINDER_SET_IDLE_TIMEOUT		_IOW('b', 3, __s64)
-#define BINDER_SET_MAX_THREADS		_IOW('b', 5, __u32)
-#define BINDER_SET_IDLE_PRIORITY	_IOW('b', 6, __s32)
-#define BINDER_SET_CONTEXT_MGR		_IOW('b', 7, __s32)
-#define BINDER_THREAD_EXIT		_IOW('b', 8, __s32)
-#define BINDER_VERSION			_IOWR('b', 9, struct binder_version)
-#define BINDER_GET_NODE_DEBUG_INFO	_IOWR('b', 11, struct binder_node_debug_info)
-#define BINDER_GET_NODE_INFO_FOR_REF	_IOWR('b', 12, struct binder_node_info_for_ref)
-#define BINDER_SET_CONTEXT_MGR_EXT	_IOW('b', 13, struct flat_binder_object)
-#define BINDER_FREEZE			_IOW('b', 14, struct binder_freeze_info)
-#define BINDER_GET_FROZEN_INFO		_IOWR('b', 15, struct binder_frozen_status_info)
-#define BINDER_ENABLE_ONEWAY_SPAM_DETECTION	_IOW('b', 16, __u32)
-#define BINDER_GET_EXTENDED_ERROR	_IOWR('b', 17, struct binder_extended_error)
+enum {
+	BINDER_WRITE_READ			= _IOWR('b', 1, struct binder_write_read),
+	BINDER_SET_IDLE_TIMEOUT			= _IOW('b', 3, __s64),
+	BINDER_SET_MAX_THREADS			= _IOW('b', 5, __u32),
+	BINDER_SET_IDLE_PRIORITY		= _IOW('b', 6, __s32),
+	BINDER_SET_CONTEXT_MGR			= _IOW('b', 7, __s32),
+	BINDER_THREAD_EXIT			= _IOW('b', 8, __s32),
+	BINDER_VERSION				= _IOWR('b', 9, struct binder_version),
+	BINDER_GET_NODE_DEBUG_INFO		= _IOWR('b', 11, struct binder_node_debug_info),
+	BINDER_GET_NODE_INFO_FOR_REF		= _IOWR('b', 12, struct binder_node_info_for_ref),
+	BINDER_SET_CONTEXT_MGR_EXT		= _IOW('b', 13, struct flat_binder_object),
+	BINDER_FREEZE				= _IOW('b', 14, struct binder_freeze_info),
+	BINDER_GET_FROZEN_INFO			= _IOWR('b', 15, struct binder_frozen_status_info),
+	BINDER_ENABLE_ONEWAY_SPAM_DETECTION	= _IOW('b', 16, __u32),
+	BINDER_GET_EXTENDED_ERROR		= _IOWR('b', 17, struct binder_extended_error),
+};
 
 /*
  * NOTE: Two special error codes you should check for when calling

base-commit: 33a1c6618677fe33f8e84cb7bedc45abbce89a50

Signature · 1 line
2.36.1
#1 lore raw

Hi Greg,

Quoted 5 lines · Miguel Ojeda

bindgen (a tool which generates the "raw" C bindings for Rust) only works (so far) with "simple" C #defines. In order to avoid having to manually maintain these constants in the (potential) Rust side, this patch converts them into an enum.

Given the discussion in v1's thread [0], I think we should hold on applying the patch (just letting you know here in v2).

[0] https://lore.kernel.org/lkml/CANiq72=_UAF5DRHCmW4qNt-Wi3yV6vPEjdLhBTijG_ZGgfpaTA@mail.gmail.com/

Cheers,
Miguel

#2 lore raw
Quoted 9 lines · Miguel Ojeda

Hi Greg,

Quoted 5 lines · Miguel Ojeda

bindgen (a tool which generates the "raw" C bindings for Rust) only works (so far) with "simple" C #defines. In order to avoid having to manually maintain these constants in the (potential) Rust side, this patch converts them into an enum.

Quoted 7 lines

Given the discussion in v1's thread [0], I think we should hold on applying the patch (just letting you know here in v2).

[0] https://lore.kernel.org/lkml/CANiq72=_UAF5DRHCmW4qNt-Wi3yV6vPEjdLhBTijG_ZGgfpaTA@mail.gmail.com/

Cheers,
Miguel

Yeah, I'll drop this from my queue, sorry.

greg k-h