Skip to contentSkip to conversation

tests/i915/kms_legacy_colorkey: Create dynamic subtests

PATCH New Mohammed Thasleem 2 participants 2 messages May 17, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/i915/kms_legacy_colorkey: Create dynamic subtests

Modified kms_legacy_colorkey to include dynamic test cases.

---
 tests/i915/kms_legacy_colorkey.c | 50 ++++++++++++++++++++++----------
 1 file changed, 35 insertions(+), 15 deletions(-)
tests/i915/kms_legacy_colorkey.c +35 -15
index de9610a7..8c609d4f 100644
@@ -38,33 +38,53 @@ static void test_plane(uint32_t plane_id, int expected_ret)
 	struct drm_intel_sprite_colorkey ckey = {
 		.plane_id = plane_id,
 	};
-
 	igt_assert(drmCommandWrite(drm_fd, DRM_I915_SET_SPRITE_COLORKEY, &ckey,
 				   sizeof(ckey)) == expected_ret);
 }
 
-igt_simple_main
+igt_main
 {
-	drm_fd = drm_open_driver_master(DRIVER_INTEL);
 
-	kmstest_set_vt_graphics_mode();
+	igt_fixture {
 
-	igt_display_require(&display, drm_fd);
+		drm_fd = drm_open_driver_master(DRIVER_INTEL);
 
-	for_each_pipe(&display, p) {
-		for_each_plane_on_pipe(&display, p, plane) {
-			bool is_valid = (plane->type == DRM_PLANE_TYPE_PRIMARY ||
-			                 plane->type == DRM_PLANE_TYPE_CURSOR);
-			test_plane(plane->drm_plane->plane_id,
-				   is_valid ? -ENOENT : 0);
+		kmstest_set_vt_graphics_mode();
 
-			max_id = max(max_id, plane->drm_plane->plane_id);
+		igt_display_require(&display, drm_fd);
+		for_each_pipe(&display, p) {
+			for_each_plane_on_pipe(&display, p, plane) {
+				max_id = max(max_id, plane->drm_plane->plane_id);
+			}
 		}
+
 	}
+	igt_describe("check valid and invalid plane ID's\n");
 
+	igt_subtest_with_dynamic("basic") {
+		for_each_pipe(&display, p) {
+			igt_dynamic_f("pipe-%s", kmstest_pipe_name(p)) {
+				for_each_plane_on_pipe(&display, p, plane) {
+					bool is_valid = (plane->type == DRM_PLANE_TYPE_PRIMARY ||
+							 plane->type == DRM_PLANE_TYPE_CURSOR);
+
+					test_plane(plane->drm_plane->plane_id,
+						   is_valid ? -ENOENT : 0);
+				}
+			}
+		}
+	}
 	/* try some invalid IDs too */
-	test_plane(0, -ENOENT);
-	test_plane(max_id + 1, -ENOENT);
+	igt_describe("check invalid plane id's zero and outrange\n");
+	igt_subtest_with_dynamic("invalid") {
+		igt_dynamic("zero")
+			test_plane(0, -ENOENT);
+		igt_dynamic("outrange")
+			test_plane(max_id + 1, -ENOENT);
+	}
 
-	igt_display_fini(&display);
+	igt_fixture {
+		igt_display_fini(&display);
+		close(drm_fd);
+	}
 }
Signature · 1 line
2.25.1
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/i915/kms_legacy_colorkey: Create dynamic subtests

== Series Details ==

== Series Details ==

Series: tests/i915/kms_legacy_colorkey: Create dynamic subtests
URL : https://patchwork.freedesktop.org/series/104072/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6476 -> IGTPW_7117
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_7117 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_7117, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/index.html

Participating hosts (43 -> 39)
------------------------------

Missing (4): bat-dg2-8 fi-rkl-11600 bat-adlm-1 bat-adlp-4

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_7117:

### IGT changes ###

#### Possible regressions ####

* igt@kms_flip@basic-flip-vs-wf_vblank@a-vga1:
- fi-bwr-2160: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6476/fi-bwr-2160/igt@kms_flip@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/fi-bwr-2160/igt@kms_flip@[email protected]

Known issues
------------

Here are the changes found in IGTPW_7117 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@i915_selftest@live@hangcheck:
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][3] ([i915#3921])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/fi-bdw-5557u/igt@i915_selftest@[email protected]
- bat-dg1-6: [PASS][4] -> [DMESG-FAIL][5] ([i915#4494] / [i915#4957])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6476/bat-dg1-6/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/bat-dg1-6/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][6] -> [DMESG-FAIL][7] ([i915#4528])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6476/fi-pnv-d510/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/fi-pnv-d510/igt@i915_selftest@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-bsw-n3050: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/fi-bsw-n3050/igt@[email protected]
- fi-snb-2600: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/fi-snb-2600/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-bsw-n3050: NOTRUN -> [SKIP][10] ([fdo#109271])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/fi-bsw-n3050/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s0@smem:
- {fi-ehl-2}: [DMESG-WARN][11] ([i915#5122]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6476/fi-ehl-2/igt@gem_exec_suspend@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/fi-ehl-2/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@gt_lrc:
- fi-bsw-n3050: [DMESG-FAIL][13] -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6476/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/fi-bsw-n3050/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][15] ([i915#3921]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6476/fi-snb-2600/igt@i915_selftest@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/fi-snb-2600/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@hugepages:
- fi-bdw-5557u: [INCOMPLETE][17] -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6476/fi-bdw-5557u/igt@i915_selftest@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/fi-bdw-5557u/igt@i915_selftest@[email protected]

* igt@kms_flip@basic-flip-vs-modeset@b-edp1:
- {bat-adlp-6}: [DMESG-WARN][19] ([i915#3576]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_6476/bat-adlp-6/igt@kms_flip@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/bat-adlp-6/igt@kms_flip@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6476 -> IGTPW_7117

CI-20190529: 20190529
CI_DRM_11663: 369f5a5daf29d74c920f418bc73c3eb5b97ddf44 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7117: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/index.html
IGT_6476: 08aa9296163b94cf4c529fc890ae3e90e21c3cdb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

Testlist changes
----------------

+igt@kms_legacy_colorkey@basic
+igt@kms_legacy_colorkey@invalid
-igt@kms_legacy_colorkey

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7117/index.html