Skip to contentSkip to conversation

irqchip/apple-aic: Fix refcount leak in build_fiq_affinity

PATCH New Miaoqian Lin 1 participant 1 message May 17, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 irqchip/apple-aic: Fix refcount leak in build_fiq_affinity

of_find_node_by_phandle() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes a5e8801202b3 ("irqchip/apple-aic: Parse FIQ affinities from device-tree")
---
 drivers/irqchip/irq-apple-aic.c | 1 +
 1 file changed, 1 insertion(+)
drivers/irqchip/irq-apple-aic.c +1 -0
index 12dd48727a15..478d0af16d9f 100644
@@ -1035,6 +1035,7 @@ static void build_fiq_affinity(struct aic_irq_chip *ic, struct device_node *aff)
 			continue;
 
 		cpu = of_cpu_node_to_id(cpu_node);
+		of_node_put(cpu_node);
 		if (WARN_ON(cpu < 0))
 			continue;
 
Signature · 1 line
2.25.1