package/pinentry: add missing !BR2_ARM_CPU_ARMV4 dependency
PATCH 1/1 package/pinentry: add missing !BR2_ARM_CPU_ARMV4 dependency
Propagate this missing BR2_PACKAGE_QT5 dependency.
Fixes:
WARNING: unmet direct dependencies detected for BR2_PACKAGE_QT5
Depends on [n]: BR2_INSTALL_LIBSTDCPP [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && BR2_HOST_GCC_AT_LEAST_5 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_5 [=y] && !BR2_ARM_CPU_ARMV4 [=y] && !BR2_STATIC_LIBS [=n] Selected by [y]:
- BR2_PACKAGE_PINENTRY_QT5 [=y] && BR2_PACKAGE_PINENTRY [=y] && BR2_INSTALL_LIBSTDCPP [=y] && BR2_USE_WCHAR [=y] && BR2_TOOLCHAIN_HAS_THREADS_NPTL [=y] && BR2_HOST_GCC_AT_LEAST_5 [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_5 [=y] && !BR2_arc [=n] && !BR2_STATIC_LIBS [=n]
--- package/pinentry/Config.in | 1 + 1 file changed, 1 insertion(+)
package/pinentry/Config.in +1 -0
@@ -74,6 +74,7 @@ config BR2_PACKAGE_PINENTRY_QT5 depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL depends on BR2_HOST_GCC_AT_LEAST_5 depends on BR2_TOOLCHAIN_GCC_AT_LEAST_5 + depends on !BR2_ARM_CPU_ARMV4 depends on !BR2_arc depends on !BR2_STATIC_LIBS select BR2_PACKAGE_QT5
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Hello James,
Quoted 9 lines · On Sat, 14 May 2022 16:42:00 -0600 James Hilliard <[email protected]>…
Propagate this missing
BR2_PACKAGE_QT5dependency.Fixes:
WARNING: unmet direct dependencies detected forBR2_PACKAGE_QT5
Depends on [n]:BR2_INSTALL_LIBSTDCPP[=y] &&BR2_USE_WCHAR[=y] &&BR2_TOOLCHAIN_HAS_THREADS_NPTL[=y] &&BR2_HOST_GCC_AT_LEAST_5[=y] &&BR2_TOOLCHAIN_GCC_AT_LEAST_5[=y] && !BR2_ARM_CPU_ARMV4 [=y] && !BR2_STATIC_LIBS [=n] Selected by [y]:
-BR2_PACKAGE_PINENTRY_QT5[=y] &&BR2_PACKAGE_PINENTRY[=y] &&BR2_INSTALL_LIBSTDCPP[=y] &&BR2_USE_WCHAR[=y] &&BR2_TOOLCHAIN_HAS_THREADS_NPTL[=y] &&BR2_HOST_GCC_AT_LEAST_5[=y] &&BR2_TOOLCHAIN_GCC_AT_LEAST_5[=y] && !BR2_arc [=n] && !BR2_STATIC_LIBS [=n]Signed-off-by James Hilliard <[email protected]>
I have applied, but after also updating the Config.in comment with this new dependency:
comment "pinentry-qt5 needs a host gcc >= 5.0, and a toolchain w/ wchar, NPTL, gcc >= 5.0, C++, dynamic library"
depends on !BR2_arc
depends on !BR2_ARM_CPU_ARMV4
depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
!BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_TOOLCHAIN_GCC_AT_LEAST_5 || \
BR2_STATIC_LIBS || !BR2_HOST_GCC_AT_LEAST_5However, I noticed that the !BR2_arc dependency no longer makes sense. It was dropped from Qt5 in commit 16ffc6549465cb5d68b751f10603e8b0363bf9b0.
This means that commit 16ffc6549465cb5d68b751f10603e8b0363bf9b0 did not properly drop this !BR2_arc dependency from reverse dependencies of Qt5. Reviewing this shows that package/wireshark also had a !BR2_arc dependency due to Qt5, which probably should be dropped.
It would be good to fix that as well.
Thanks!
Thomas
Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin Embedded Linux and Kernel engineering and training https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"James" == James Hilliard <[email protected]> writes:
Propagate this missing
BR2_PACKAGE_QT5dependency.
Fixes:
WARNING: unmet direct dependencies detected forBR2_PACKAGE_QT5
Depends on [n]:BR2_INSTALL_LIBSTDCPP[=y] &&BR2_USE_WCHAR[=y] &&BR2_TOOLCHAIN_HAS_THREADS_NPTL[=y] &&BR2_HOST_GCC_AT_LEAST_5[=y] &&BR2_TOOLCHAIN_GCC_AT_LEAST_5[=y] && !BR2_ARM_CPU_ARMV4 [=y] && !BR2_STATIC_LIBS [=n] Selected by [y]:
-BR2_PACKAGE_PINENTRY_QT5[=y] &&BR2_PACKAGE_PINENTRY[=y] &&BR2_INSTALL_LIBSTDCPP[=y] &&BR2_USE_WCHAR[=y] &&BR2_TOOLCHAIN_HAS_THREADS_NPTL[=y] &&BR2_HOST_GCC_AT_LEAST_5[=y] &&BR2_TOOLCHAIN_GCC_AT_LEAST_5[=y] && !BR2_arc [=n] && !BR2_STATIC_LIBS [=n]Signed-off-by James Hilliard <[email protected]>
Committed to 2022.02.x, thanks.
Signature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot