Skip to contentSkip to conversation

clk: ux500: fix a possible off-by-one in u8500_prcc_reset_base()

PATCH Applied Hangyu Hua 3 participants 3 messages May 18, 2022

Subsystems (2)
lore
Share & tools
lore

Hangyu Hua

author
#0 lore raw

PATCH 1/1 clk: ux500: fix a possible off-by-one in u8500_prcc_reset_base()

Off-by-one will happen when index == ARRAY_SIZE(ur->base).

Fixes b14cbdfd467d ("clk: ux500: Add driver for the reset portions of PRCC")
---
 drivers/clk/ux500/reset-prcc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/ux500/reset-prcc.c +1 -1
index fcd5d042806a..f7e48941fbc7 100644
@@ -58,7 +58,7 @@ static void __iomem *u8500_prcc_reset_base(struct u8500_prcc_reset *ur,
 	prcc_num = id / PRCC_PERIPHS_PER_CLUSTER;
 	index = prcc_num_to_index(prcc_num);
 
-	if (index > ARRAY_SIZE(ur->base))
+	if (index >= ARRAY_SIZE(ur->base))
 		return NULL;
 
 	return ur->base[index];
Signature · 1 line
2.25.1