clk: ux500: fix a possible off-by-one in u8500_prcc_reset_base()
Subsystems (2)
PATCH 1/1 clk: ux500: fix a possible off-by-one in u8500_prcc_reset_base()
Off-by-one will happen when index == ARRAY_SIZE(ur->base).
Fixes b14cbdfd467d ("clk: ux500: Add driver for the reset portions of PRCC")
Signed-off-by Hangyu Hua <[email protected]>
--- drivers/clk/ux500/reset-prcc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/ux500/reset-prcc.c +1 -1
@@ -58,7 +58,7 @@ static void __iomem *u8500_prcc_reset_base(struct u8500_prcc_reset *ur, prcc_num = id /PRCC_PERIPHS_PER_CLUSTER ; index =prcc_num_to_index (prcc_num); -if (index >ARRAY_SIZE (ur->base)) +if (index >=ARRAY_SIZE (ur->base))return NULL ;return ur->base[index];
Signature · 1 line
2.25.1
Quoted 4 lines · Hangyu Hua
Off-by-one will happen when index ==
ARRAY_SIZE(ur->base).Fixes b14cbdfd467d ("clk: ux500: Add driver for the reset portions of PRCC")Signed-off-by Hangyu Hua <[email protected]>
Good catch!
Reviewed-by Linus Walleij <[email protected]>
Yours,
Linus Walleij
Quoting Hangyu Hua (2022-05-17 23:25:37)
Quoted 5 lines
Off-by-one will happen when index ==
ARRAY_SIZE(ur->base).Fixes b14cbdfd467d ("clk: ux500: Add driver for the reset portions of PRCC")Signed-off-by Hangyu Hua <[email protected]>---
Applied to clk-next