Skip to contentSkip to conversation

selftests: netdevsim: Increase sleep time in hw_stats_l3.sh test

PATCH Applied Danielle Ratson 2 participants 2 messages May 18, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 selftests: netdevsim: Increase sleep time in hw_stats_l3.sh test

hw_stats_l3.sh test is failing often for l3 stats shows less than 20 packets after 2 seconds sleep.

This is happening since there is a race between the 2 seconds sleep and the netdevsim actually delivering the packets.

Increase the sleep time so the packets will be delivered successfully on time.

---
 tools/testing/selftests/drivers/net/netdevsim/hw_stats_l3.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
tools/testing/selftests/drivers/net/netdevsim/hw_stats_l3.sh +2 -2
index fe1898402987..cba5ac08426b 100755
@@ -319,11 +319,11 @@ counter_test()
 	((pkts < 10))
 	check_err $? "$type stats show >= 10 packets after first enablement"
 
-	sleep 2
+	sleep 2.5
 
 	local pkts=$(get_hwstat dummy1 l3 rx.packets)
 	((pkts >= 20))
-	check_err $? "$type stats show < 20 packets after 2s passed"
+	check_err $? "$type stats show < 20 packets after 2.5s passed"
 
 	$IP stats set dev dummy1 ${type}_stats off
 
Signature · 1 line
2.31.1
#1 lore raw
This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Hello:

This patch was applied to netdev/net-next.git (master) by David S. Miller <[email protected]>:

Quoted 10 lines · On Wed, 18 May 2022 10:27:26 +0300 you wrote:

hw_stats_l3.sh test is failing often for l3 stats shows less than 20 packets after 2 seconds sleep.

This is happening since there is a race between the 2 seconds sleep and the netdevsim actually delivering the packets.

Increase the sleep time so the packets will be delivered successfully on time.

[...]

Here is the summary with links:
- [net-next] selftests: netdevsim: Increase sleep time in hw_stats_l3.sh test

    https://git.kernel.org/netdev/net-next/c/7ba106fcd4b4

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html