Skip to contentSkip to conversation

rtc: rzn1: initialize val in rzn1_rtc_set_offset

PATCH In review Tom Rix 2 participants 2 messages May 18, 2022

Subsystems (2)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 rtc: rzn1: initialize val in rzn1_rtc_set_offset

The clang build fails with
rtc-rzn1.c:291:3: error: variable 'val' is uninitialized when used here [-Werror,-Wuninitialized]
val |= RZN1_RTC_SUBU_DEV;
^~~

The val variable in rzn1_rtc_set_offset() is never initialized so the series of |= operations in the function will start with a garbage value. So initialize val to 0.

Fixes be4a11cf98af ("rtc: rzn1: Add oscillator offset support")
---
 drivers/rtc/rtc-rzn1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-rzn1.c +1 -1
index 980ade8c9601..0b4bf6e43464 100644
@@ -272,7 +272,7 @@ static int rzn1_rtc_set_offset(struct device *dev, long offset)
 	struct rzn1_rtc *rtc = dev_get_drvdata(dev);
 	unsigned int steps;
 	int stepsh, stepsl;
-	u32 val;
+	u32 val = 0;
 	int ret;
 
 	/*
Signature · 1 line
2.27.0
maintainer
#1 lore raw

Hi,

[email protected] wrote on Wed, 18 May 2022 09:47:47 -0400:

Quoted 20 lines

The clang build fails with
rtc-rzn1.c:291:3: error: variable 'val' is uninitialized when used here [-Werror,-Wuninitialized]
val |= RZN1_RTC_SUBU_DEV;
^~~

The val variable in rzn1_rtc_set_offset() is never initialized so the series of |= operations in the function will start with a garbage value. So initialize val to 0.

Fixes be4a11cf98af ("rtc: rzn1: Add oscillator offset support")
---
 drivers/rtc/rtc-rzn1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-rzn1.c +0 -0
index 980ade8c9601..0b4bf6e43464 100644

drivers/rtc/rtc-rzn1.c static int rzn1_rtc_set_offset(struct device *dev, long offset) · line 275

Quoted 5 lines
drivers/rtc/rtc-rzn1.c +1 -1
@@ -272,7 +272,7 @@ static int rzn1_rtc_set_offset(struct device *dev, long offset)
 	struct rzn1_rtc *rtc = dev_get_drvdata(dev);
 	unsigned int steps;
 	int stepsh, stepsl;
-	u32 val;
+	u32 val = 0;

Actually reviewing this makes me realize I mixed two variables together:
- val here and below should be renamed to something like "subu" or and indeed initialized to 0 here.
- a "ctl2" u32 should be introduced and be used instead of "val" in the readl_poll_timeout() call.

Thanks,
Miquèl