Skip to contentSkip to conversation

dhcp: CLIENT_ENTER_STATE should log as INFO

PATCH In review Michael Johnson 2 participants 2 messages May 18, 2022

lore
Share & tools
lore

Michael Johnson

author
#0 lore raw

PATCH 1/1 dhcp: CLIENT_ENTER_STATE should log as INFO

This was missed in the d5377c6. Now the state will only log when INFO or above is enabled.

---
 ell/dhcp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
ell/dhcp.c +1 -3
index 8ff5594..4e66faa 100644
@@ -56,9 +56,7 @@
 #define CLIENT_WARN(fmt, args...)					\
 	CLIENT_LOG(L_LOG_WARNING, fmt, ## args)
 #define CLIENT_ENTER_STATE(s)						\
-	l_util_debug(client->debug_handler, client->debug_data,		\
-			"%s:%i Entering state: " #s,			\
-			__func__, __LINE__);				\
+	CLIENT_INFO("Entering state: " #s);				\
 	client->state = (s)
 
 #define BITS_PER_LONG (sizeof(unsigned long) * 8)
Signature · 1 line
2.25.1
#1 lore raw

Hi Michael,

Quoted 6 lines · Michael Johnson

This was missed in the d5377c6. Now the state will only log when INFO or above is enabled.

---
  ell/dhcp.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

Applied with a slight rewording of the commit description.

Regards,
-Denis