Skip to contentSkip to conversation

xtensa: Return true/false (not 1/0) from bool function

PATCH Applied Yang Li 2 participants 2 messages May 18, 2022 – May 23, 2022 Tensilica Xtensa port (xtensa)

lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 xtensa: Return true/false (not 1/0) from bool function

Return boolean values ("true" or "false") instead of 1 or 0 from bool function. This fixes the following warnings from coccicheck:

./arch/xtensa/kernel/traps.c:304:10-11: WARNING: return of 0/1 in function 'check_div0' with return type bool

---
 arch/xtensa/kernel/traps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/xtensa/kernel/traps.c +1 -1
index f97d43a8d13d..0c25e035ff10 100644
@@ -301,7 +301,7 @@ static bool check_div0(struct pt_regs *regs)
 
 	if (user_mode(regs)) {
 		if (copy_from_user(buf, (void __user *)regs->pc + 2, 5))
-			return 0;
+			return false;
 		p = buf;
 	} else {
 		p = (const u8 *)regs->pc + 2;
Signature · 1 line
2.20.1.7.g153144c
maintainer Applied
#1 lore raw
Quoted 4 lines · Yang Li

Return boolean values ("true" or "false") instead of 1 or 0 from bool function. This fixes the following warnings from coccicheck:

Quoted 8 lines

./arch/xtensa/kernel/traps.c:304:10-11: WARNING: return of 0/1 in function 'check_div0' with return type bool

---
 arch/xtensa/kernel/traps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks! Applied to my xtensa tree.

-- Max