sched/clock: Use try_cmpxchg64 in sched_clock_{local,remote}
PATCH 1/1 sched/clock: Use try_cmpxchg64 in sched_clock_{local,remote}
Use try_cmpxchg64 instead of cmpxchg64 (*ptr, old, new) != old in sched_clock_{local,remote}. x86 cmpxchg returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg).
---
Patch requires commits 0aa7be05d83cc584da0782405e8007e351dfb6cc and c2df0a6af177b6c06a859806a876f92b072dc624 from tip.git
--- kernel/sched/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/sched/clock.c +2 -2
@@ -287,7 +287,7 @@ notrace static u64 sched_clock_local(struct sched_clock_data *scd) clock =wrap_max (clock, min_clock); clock =wrap_min (clock, max_clock); -if (cmpxchg64 (&scd->clock, old_clock, clock) != old_clock) +if (!try_cmpxchg64 (&scd->clock, &old_clock, clock)) goto again;return clock;
@@ -349,7 +349,7 @@ notrace static u64 sched_clock_remote(struct sched_clock_data *scd) val = remote_clock; } -if (cmpxchg64 (ptr, old_val, val) != old_val) +if (!try_cmpxchg64 (ptr, &old_val, val)) goto again;return val;
Signature · 1 line
2.35.1
Peter Zijlstra
maintainerQuoted 6 lines · Uros Bizjak
Use
try_cmpxchg64instead of cmpxchg64 (*ptr, old, new) != old in sched_clock_{local,remote}. x86 cmpxchg returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg).Signed-off-by Uros Bizjak <[email protected]>
Thanks!
The following commit has been merged into the locking/core branch of tip:
The following commit has been merged into the locking/core branch of tip:
Commit-ID: 8491d1bdf5de152f27fc941e2dcdc4e66c950542 Gitweb: https://git.kernel.org/tip/8491d1bdf5de152f27fc941e2dcdc4e66c950542 Author: Uros Bizjak <[email protected]> AuthorDate: Wed, 18 May 2022 20:49:53 +02:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Thu, 19 May 2022 23:46:09 +02:00
sched/clock: Use try_cmpxchg64 in sched_clock_{local,remote}
Use try_cmpxchg64 instead of cmpxchg64 (*ptr, old, new) != old in sched_clock_{local,remote}. x86 cmpxchg returns success in ZF flag, so this change saves a compare after cmpxchg (and related move instruction in front of cmpxchg).
--- kernel/sched/clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/sched/clock.c +2 -2
@@ -287,7 +287,7 @@ again: clock =wrap_max (clock, min_clock); clock =wrap_min (clock, max_clock); -if (cmpxchg64 (&scd->clock, old_clock, clock) != old_clock) +if (!try_cmpxchg64 (&scd->clock, &old_clock, clock)) goto again;return clock;
@@ -349,7 +349,7 @@ again: val = remote_clock; } -if (cmpxchg64 (ptr, old_val, val) != old_val) +if (!try_cmpxchg64 (ptr, &old_val, val)) goto again;return val;