f2fs: make f2fs_read_inline_data() more readable
PATCH RESEND 1/1 f2fs: make f2fs_read_inline_data() more readable
From: Chao Liu <[email protected]>
In f2fs_read_inline_data(), it is confused with checking of inline_data flag, as we checked it before calling. So this patch add some comments for f2fs_has_inline_data().
Signed-off-by Chao Liu <[email protected]>
--- fs/f2fs/f2fs.h | 4 ++++ 1 file changed, 4 insertions(+)
fs/f2fs/f2fs.h +4 -0
@@ -3167,6 +3167,10 @@ static inline int inline_xattr_size(struct inode *inode)return 0 ; } +/* +* Notice: check inline_data flag without inode page lock is unsafe. +* It could change at any time by f2fs_convert_inline_page(). +*/ static inline int f2fs_has_inline_data (struct inode *inode) {return is_inode_flag_set (inode,FI_INLINE_DATA );
Signature · 1 line
2.36.1
Quoted 7 lines · Chao Liu
From: Chao Liu <[email protected]>
In
f2fs_read_inline_data(), it is confused with checking ofinline_dataflag, as we checked it before calling. So this patch add some comments forf2fs_has_inline_data().Signed-off-by Chao Liu <[email protected]>
Reviewed-by Chao Yu <[email protected]>
Thanks,