Skip to contentSkip to conversation

tools/perf/test: Fix perf all PMU test to skip hv_24x7/hv_gpci tests on powerpc

PATCH Superseded Athira Rajeev 3 participants 5 messages May 19, 2022 – May 20, 2022 perf events

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 tools/perf/test: Fix perf all PMU test to skip hv_24x7/hv_gpci tests on powerpc

"perf all PMU test" picks the input events from "perf list --raw-dump pmu" list and runs "perf stat -e" for each of the event in the list. In case of powerpc, the PowerVM environment supports events from hv_24x7 and hv_gpci PMU which is of example format like below:
- hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/
- hv_gpci/event,partition_id=?/

The value for "?" needs to be filled in depending on system and respective event. CPM_ADJUNCT_INST needs have core value and domain value. hv_gpci event needs partition_id. Similarly, there are other events for hv_24x7 and hv_gpci having "?" in event format. Hence skip these events on powerpc platform since values like partition_id, domain is specific to system and event.

Fixes 3d5ac9effcc6 ("perf test: Workload test of all PMUs")

---
Changelog:
v1 -> v2:
Instead of checking for platform, used the pmu name ie, hv_24x7 and hv_gpci to skip the test since this pmu name is specific to powerpc as suggested by Michael Ellerman.

 tools/perf/tests/shell/stat_all_pmu.sh | 10 ++++++++++
 1 file changed, 10 insertions(+)
tools/perf/tests/shell/stat_all_pmu.sh +10 -0
index b30dba455f36..7d046bb8a7b9 100755
@@ -5,6 +5,16 @@
 set -e
 
 for p in $(perf list --raw-dump pmu); do
+  # In powerpc, skip the events for hv_24x7 and hv_gpci.
+  # These events needs input values to be filled in for
+  # core, chip, patition id based on system.
+  # Example: hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/
+  # hv_gpci/event,partition_id=?/
+  # Hence skip these events for ppc.
+  if echo "$p" |grep -Eq 'hv_24x7|hv_gpci' ; then
+    echo "Skipping: Event '$p' in powerpc"
+    continue
+  fi
   echo "Testing $p"
   result=$(perf stat -e "$p" true 2>&1)
   if ! echo "$result" | grep -q "$p" && ! echo "$result" | grep -q "<not supported>" ; then
Signature · 1 line
2.35.1
reviewer
#1 lore raw
Quoted 35 lines · Athira Rajeev

"perf all PMU test" picks the input events from "perf list --raw-dump pmu" list and runs "perf stat -e" for each of the event in the list. In case of powerpc, the PowerVM environment supports events from hv_24x7 and hv_gpci PMU which is of example format like below:
- hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/
- hv_gpci/event,partition_id=?/

The value for "?" needs to be filled in depending on system and respective event. CPM_ADJUNCT_INST needs have core value and domain value. hv_gpci event needs partition_id. Similarly, there are other events for hv_24x7 and hv_gpci having "?" in event format. Hence skip these events on powerpc platform since values like partition_id, domain is specific to system and event.

Fixes 3d5ac9effcc6 ("perf test: Workload test of all PMUs")

---
Changelog:
v1 -> v2:
Instead of checking for platform, used the pmu name ie, hv_24x7 and hv_gpci to skip the test since this pmu name is specific to powerpc as suggested by Michael Ellerman.

 tools/perf/tests/shell/stat_all_pmu.sh | 10 ++++++++++
 1 file changed, 10 insertions(+)
tools/perf/tests/shell/stat_all_pmu.sh +0 -0
index b30dba455f36..7d046bb8a7b9 100755

tools/perf/tests/shell/stat_all_pmu.sh line 10

Quoted 6 lines
tools/perf/tests/shell/stat_all_pmu.sh +3 -0
@@ -5,6 +5,16 @@
 set -e
 
 for p in $(perf list --raw-dump pmu); do
+  # In powerpc, skip the events for hv_24x7 and hv_gpci.
+  # These events needs input values to be filled in for
+  # core, chip, patition id based on system.

nit: s/patition/partition/

tools/perf/tests/shell/stat_all_pmu.sh line 11

Quoted 1 line
tools/perf/tests/shell/stat_all_pmu.sh +1 -0
+  # Example: hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/

I've no problem with this patch, we may need to do similar for other architectures. For this specific problem I wonder if rather than skipping the event the event can be fixed with domain and core set to 1 ? This would provide a little additional coverage.

Thanks,
Ian

Quoted 12 lines
tools/perf/tests/shell/stat_all_pmu.sh +6 -1
+  # hv_gpci/event,partition_id=?/
+  # Hence skip these events for ppc.
+  if echo "$p" |grep -Eq 'hv_24x7|hv_gpci' ; then
+    echo "Skipping: Event '$p' in powerpc"
+    continue
+  fi
   echo "Testing $p"
   result=$(perf stat -e "$p" true 2>&1)
   if ! echo "$result" | grep -q "$p" && ! echo "$result" | grep -q "<not supported>" ; then
--

2.35.1

#2 lore raw
Quoted 48 lines · Ian Rogers
Quoted 38 lines · Athira Rajeev

"perf all PMU test" picks the input events from "perf list --raw-dump pmu" list and runs "perf stat -e" for each of the event in the list. In case of powerpc, the PowerVM environment supports events from hv_24x7 and hv_gpci PMU which is of example format like below:
- hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/
- hv_gpci/event,partition_id=?/

The value for "?" needs to be filled in depending on system and respective event. CPM_ADJUNCT_INST needs have core value and domain value. hv_gpci event needs partition_id. Similarly, there are other events for hv_24x7 and hv_gpci having "?" in event format. Hence skip these events on powerpc platform since values like partition_id, domain is specific to system and event.

Fixes 3d5ac9effcc6 ("perf test: Workload test of all PMUs")

---
Changelog:
v1 -> v2:
Instead of checking for platform, used the pmu name ie, hv_24x7 and hv_gpci to skip the test since this pmu name is specific to powerpc as suggested by Michael Ellerman.

tools/perf/tests/shell/stat_all_pmu.sh | 10 ++++++++++

1 file changed, 10 insertions(+)
tools/perf/tests/shell/stat_all_pmu.sh +0 -0
index b30dba455f36..7d046bb8a7b9 100755
@@ -5,6 +5,16 @@

set -e

for p in $(perf list --raw-dump pmu); do

tools/perf/tests/shell/stat_all_pmu.sh line 10

Quoted 3 lines
tools/perf/tests/shell/stat_all_pmu.sh +3 -0
+  # In powerpc, skip the events for hv_24x7 and hv_gpci.
+  # These events needs input values to be filled in for
+  # core, chip, patition id based on system.

nit: s/patition/partition/

Quoted 6 lines
Quoted 1 line

+ # Example: hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/

I've no problem with this patch, we may need to do similar for other architectures. For this specific problem I wonder if rather than skipping the event the event can be fixed with domain and core set to 1 ? This would provide a little additional coverage.

Hi Ian,

Thanks for review. Yeah, we looked at the option of having default value of 0.
But then we could still fail due to the partition privilege. These PMU counters expose per-core and per-chip data and partition needs additional privileges to get these pmu data.
Hence the skip :)

Thanks
Athira

Quoted 15 lines

Thanks,
Ian

Quoted 11 lines
tools/perf/tests/shell/stat_all_pmu.sh +6 -1
+  # hv_gpci/event,partition_id=?/
+  # Hence skip these events for ppc.
+  if echo "$p" |grep -Eq 'hv_24x7|hv_gpci' ; then
+    echo "Skipping: Event '$p' in powerpc"
+    continue
+  fi
  echo "Testing $p"
  result=$(perf stat -e "$p" true 2>&1)
  if ! echo "$result" | grep -q "$p" && ! echo "$result" | grep -q "<not supported>" ; then
--

2.35.1

#3 lore raw
In reply to Ian Rogers

Em Thu, May 19, 2022 at 11:45:07AM -0700, Ian Rogers escreveu:

Quoted 39 lines
Quoted 37 lines · Athira Rajeev

"perf all PMU test" picks the input events from "perf list --raw-dump pmu" list and runs "perf stat -e" for each of the event in the list. In case of powerpc, the PowerVM environment supports events from hv_24x7 and hv_gpci PMU which is of example format like below:
- hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/
- hv_gpci/event,partition_id=?/

The value for "?" needs to be filled in depending on system and respective event. CPM_ADJUNCT_INST needs have core value and domain value. hv_gpci event needs partition_id. Similarly, there are other events for hv_24x7 and hv_gpci having "?" in event format. Hence skip these events on powerpc platform since values like partition_id, domain is specific to system and event.

Fixes 3d5ac9effcc6 ("perf test: Workload test of all PMUs")

---
Changelog:
v1 -> v2:
Instead of checking for platform, used the pmu name ie, hv_24x7 and hv_gpci to skip the test since this pmu name is specific to powerpc as suggested by Michael Ellerman.

 tools/perf/tests/shell/stat_all_pmu.sh | 10 ++++++++++
 1 file changed, 10 insertions(+)
tools/perf/tests/shell/stat_all_pmu.sh +0 -0
index b30dba455f36..7d046bb8a7b9 100755
@@ -5,6 +5,16 @@
 set -e
 
Quoted 8 lines

tools/perf/tests/shell/stat_all_pmu.sh line 10

Quoted 4 lines
tools/perf/tests/shell/stat_all_pmu.sh +3 -0
 for p in $(perf list --raw-dump pmu); do
+  # In powerpc, skip the events for hv_24x7 and hv_gpci.
+  # These events needs input values to be filled in for
+  # core, chip, patition id based on system.

nit: s/patition/partition/

tools/perf/tests/shell/stat_all_pmu.sh line 11

Quoted 1 line
tools/perf/tests/shell/stat_all_pmu.sh +1 -0
+  # Example: hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/

I've no problem with this patch, we may need to do similar for other

Can I take this as an Acked-by?

- Arnaldo

Quoted 19 lines

architectures. For this specific problem I wonder if rather than skipping the event the event can be fixed with domain and core set to 1 ? This would provide a little additional coverage.

Thanks,
Ian

Quoted 12 lines
tools/perf/tests/shell/stat_all_pmu.sh +6 -1
+  # hv_gpci/event,partition_id=?/
+  # Hence skip these events for ppc.
+  if echo "$p" |grep -Eq 'hv_24x7|hv_gpci' ; then
+    echo "Skipping: Event '$p' in powerpc"
+    continue
+  fi
   echo "Testing $p"
   result=$(perf stat -e "$p" true 2>&1)
   if ! echo "$result" | grep -q "$p" && ! echo "$result" | grep -q "<not supported>" ; then
--

2.35.1

Signature · 1 line
- Arnaldo
reviewer Acked-by
#4 lore raw
Quoted 46 lines · Arnaldo Carvalho de Melo

Em Thu, May 19, 2022 at 11:45:07AM -0700, Ian Rogers escreveu:

Quoted 44 lines
Quoted 35 lines · Athira Rajeev

"perf all PMU test" picks the input events from "perf list --raw-dump pmu" list and runs "perf stat -e" for each of the event in the list. In case of powerpc, the PowerVM environment supports events from hv_24x7 and hv_gpci PMU which is of example format like below:
- hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/
- hv_gpci/event,partition_id=?/

The value for "?" needs to be filled in depending on system and respective event. CPM_ADJUNCT_INST needs have core value and domain value. hv_gpci event needs partition_id. Similarly, there are other events for hv_24x7 and hv_gpci having "?" in event format. Hence skip these events on powerpc platform since values like partition_id, domain is specific to system and event.

Fixes 3d5ac9effcc6 ("perf test: Workload test of all PMUs")

---
Changelog:
v1 -> v2:
Instead of checking for platform, used the pmu name ie, hv_24x7 and hv_gpci to skip the test since this pmu name is specific to powerpc as suggested by Michael Ellerman.

 tools/perf/tests/shell/stat_all_pmu.sh | 10 ++++++++++
 1 file changed, 10 insertions(+)
tools/perf/tests/shell/stat_all_pmu.sh +0 -0
index b30dba455f36..7d046bb8a7b9 100755

tools/perf/tests/shell/stat_all_pmu.sh line 10

Quoted 6 lines
tools/perf/tests/shell/stat_all_pmu.sh +3 -0
@@ -5,6 +5,16 @@
 set -e
 
 for p in $(perf list --raw-dump pmu); do
+  # In powerpc, skip the events for hv_24x7 and hv_gpci.
+  # These events needs input values to be filled in for
+  # core, chip, patition id based on system.

nit: s/patition/partition/

Quoted 7 lines
Quoted 3 lines

tools/perf/tests/shell/stat_all_pmu.sh line 11

Quoted 1 line
tools/perf/tests/shell/stat_all_pmu.sh +1 -0
+  # Example: hv_24x7/CPM_ADJUNCT_INST,domain=?,core=?/

I've no problem with this patch, we may need to do similar for other

Can I take this as an Acked-by?

- Arnaldo

Thanks,
Ian

Quoted 23 lines
Quoted 4 lines

architectures. For this specific problem I wonder if rather than skipping the event the event can be fixed with domain and core set to 1 ? This would provide a little additional coverage.

Quoted 15 lines

Thanks,
Ian

Quoted 12 lines
tools/perf/tests/shell/stat_all_pmu.sh +6 -1
+  # hv_gpci/event,partition_id=?/
+  # Hence skip these events for ppc.
+  if echo "$p" |grep -Eq 'hv_24x7|hv_gpci' ; then
+    echo "Skipping: Event '$p' in powerpc"
+    continue
+  fi
   echo "Testing $p"
   result=$(perf stat -e "$p" true 2>&1)
   if ! echo "$result" | grep -q "$p" && ! echo "$result" | grep -q "<not supported>" ; then
--

2.35.1

--

- Arnaldo