Skip to contentSkip to conversation

package/python-orjson: bump version to 3.6.8.

PATCH Applied Graeme Smecher 4 participants 9 messages May 9, 2022 – Feb 7, 2023

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/python-orjson: bump version to 3.6.8.

---
 package/python-orjson/python-orjson.hash | 2 +-
 package/python-orjson/python-orjson.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/python-orjson/python-orjson.hash +1 -1
index 5ef2726d82..2c00164702 100644
@@ -1,4 +1,4 @@
 # Locally calculated
-sha256  4713b120ad86b1b273f5952cbf9578c13d0f453064bd26d823e04a10c84824e6  python-orjson-3.6.7.tar.gz
+sha256  2b0259ff26455c4f9ad2290b49ba184a35e98eea4839f0d6d5c2b7d91383b3d9  python-orjson-3.6.8.tar.gz
 sha256  a60eea817514531668d7e00765731449fe14d059d3249e0bc93b36de45f759f2  LICENSE-APACHE
 sha256  23f18e03dc49df91622fe2a76176497404e46ced8a715d9d2b67a7446571cca3  LICENSE-MIT
package/python-orjson/python-orjson.mk +1 -1
index 5de4b2c5fa..cfcaedc280 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PYTHON_ORJSON_VERSION = 3.6.7
+PYTHON_ORJSON_VERSION = 3.6.8
 PYTHON_ORJSON_SITE = $(call github,ijl,orjson,$(PYTHON_ORJSON_VERSION))
 PYTHON_ORJSON_LICENSE = Apache-2.0 or MIT
 PYTHON_ORJSON_LICENSE_FILES = LICENSE-APACHE LICENSE-MIT
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/2 package/python-orjson: disallow build when using musl.

The python-orjson build bails as follows when using musl libc:

error: cannot produce cdylib for orjson v3.6.7 (...) as the target i586-unknown-linux-musl does not support these crate types

It's not machine-specific (it occurs on i586, s389x, and arm platforms), and is tied to what appears to be relatively arcane details for rust/musl:

	https://github.com/rust-lang/rust/issues/59302

At some point, it will be possible to remove this restriction - but not yet.

---
 package/python-orjson/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/python-orjson/Config.in +5 -0
index 420e023b0a..b2ad9062cc 100644
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_PYTHON_ORJSON
 	bool "python-orjson"
 	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
+	# doesn't build with musl until rust's cdylib targets work with it
+	depends on !BR2_TOOLCHAIN_USES_MUSL
 	select BR2_PACKAGE_PYTHON_CFFI # runtime
 	help
 	  orjson is a fast, correct JSON library for Python. It
@@ -10,3 +12,6 @@ config BR2_PACKAGE_PYTHON_ORJSON
 	  instances natively.
 
 	  https://github.com/ijl/orjson
+
+comment "python-orjson requires rust cdylib support, which musl doesn't have yet"
+	depends on BR2_TOOLCHAIN_USES_MUSL
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

PATCH v2 1/1 package/python-orjson: disallow build when using musl.

The python-orjson build bails as follows when using musl libc:

error: cannot produce cdylib for orjson v3.6.7 (...) as the target i586-unknown-linux-musl does not support these crate types

It's not machine-specific (it occurs on i586, s389x, and arm platforms), and is tied to what appears to be relatively arcane details for rust/musl:

	https://github.com/rust-lang/rust/issues/59302

At some point, it will be possible to remove this restriction - but not yet.

---
 package/python-orjson/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/python-orjson/Config.in +5 -0
index 420e023b0a..b2ad9062cc 100644
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_PYTHON_ORJSON
 	bool "python-orjson"
 	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
+	# doesn't build with musl until rust's cdylib targets work with it
+	depends on !BR2_TOOLCHAIN_USES_MUSL
 	select BR2_PACKAGE_PYTHON_CFFI # runtime
 	help
 	  orjson is a fast, correct JSON library for Python. It
@@ -10,3 +12,6 @@ config BR2_PACKAGE_PYTHON_ORJSON
 	  instances natively.
 
 	  https://github.com/ijl/orjson
+
+comment "python-orjson requires rust cdylib support, which musl doesn't have yet"
+	depends on BR2_TOOLCHAIN_USES_MUSL
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw

Re: [Buildroot] [PATCH v2] package/python-orjson: disallow build when using musl.

Graeme, All,

On 2022-05-19 09:02 -0700, Graeme Smecher spake thusly:

Quoted 4 lines

The python-orjson build bails as follows when using musl libc:

error: cannot produce cdylib for orjson v3.6.7 (...) as the target i586-unknown-linux-musl does not support these crate types

I could not reproduce such an error wit the following defconfig:

BR2_TOOLCHAIN_BUILDROOT_MUSL=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PER_PACKAGE_DIRECTORIES=y
BR2_PACKAGE_PYTHON3=y
BR2_PACKAGE_PYTHON_ORJSON=y

Since you submitted this patch, pythn-orjson was bumped multiple times, and we've also bumped rust to 1.66.1, so maybe that was fixed now.

Could you have a further look into this, please?

Regards,
Yann E. MORIN.

Quoted 41 lines

It's not machine-specific (it occurs on i586, s389x, and arm platforms), and is tied to what appears to be relatively arcane details for rust/musl:

	https://github.com/rust-lang/rust/issues/59302

At some point, it will be possible to remove this restriction - but not yet.

---
 package/python-orjson/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/python-orjson/Config.in +5 -0
index 420e023b0a..b2ad9062cc 100644
@@ -1,6 +1,8 @@
 config BR2_PACKAGE_PYTHON_ORJSON
 	bool "python-orjson"
 	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
+	# doesn't build with musl until rust's cdylib targets work with it
+	depends on !BR2_TOOLCHAIN_USES_MUSL
 	select BR2_PACKAGE_PYTHON_CFFI # runtime
 	help
 	  orjson is a fast, correct JSON library for Python. It
@@ -10,3 +12,6 @@ config BR2_PACKAGE_PYTHON_ORJSON
 	  instances natively.
 
 	  https://github.com/ijl/orjson
+
+comment "python-orjson requires rust cdylib support, which musl doesn't have yet"
+	depends on BR2_TOOLCHAIN_USES_MUSL
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#4 lore raw

Re: [Buildroot] [PATCH v2] package/python-orjson: disallow build when using musl.

Hi Yann,

Quoted 16 lines · Yann E. MORIN

Graeme, All,

On 2022-05-19 09:02 -0700, Graeme Smecher spake thusly:

Quoted 4 lines

The python-orjson build bails as follows when using musl libc:

error: cannot produce cdylib for orjson v3.6.7 (...) as the target i586-unknown-linux-musl does not support these crate types

I could not reproduce such an error wit the following defconfig:

BR2_TOOLCHAIN_BUILDROOT_MUSL=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
BR2_PER_PACKAGE_DIRECTORIES=y
BR2_PACKAGE_PYTHON3=y
BR2_PACKAGE_PYTHON_ORJSON=y

Quoted 4 lines

Since you submitted this patch, pythn-orjson was bumped multiple times, and we've also bumped rust to 1.66.1, so maybe that was fixed now.

Could you have a further look into this, please?

This patch is obsolete. I used to receive orjson build failures associated with musl on a regular basis - they have tapered off since mid-2022.

Over the past ~6 months or so, only the mips autobuilds have failed with the following message:

- maturin failed
Caused by: The architecture mips is not supported

http://autobuild.buildroot.net/results/7291d123479411e632b8380f0045a18814dc23ae

I am happy to drop the patch.

best,
Graeme

Quoted 41 lines

Regards,
Yann E. MORIN.

Quoted 37 lines

It's not machine-specific (it occurs on i586, s389x, and arm platforms), and is tied to what appears to be relatively arcane details for rust/musl:

	https://github.com/rust-lang/rust/issues/59302

At some point, it will be possible to remove this restriction - but not yet.

---
  package/python-orjson/Config.in | 5 +++++
  1 file changed, 5 insertions(+)
package/python-orjson/Config.in +5 -0
index 420e023b0a..b2ad9062cc 100644
@@ -1,6 +1,8 @@
  config BR2_PACKAGE_PYTHON_ORJSON
  	bool "python-orjson"
  	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
+	# doesn't build with musl until rust's cdylib targets work with it
+	depends on !BR2_TOOLCHAIN_USES_MUSL
  	select BR2_PACKAGE_PYTHON_CFFI # runtime
  	help
  	  orjson is a fast, correct JSON library for Python. It
@@ -10,3 +12,6 @@ config BR2_PACKAGE_PYTHON_ORJSON
  	  instances natively.
 
  	  https://github.com/ijl/orjson
+
+comment "python-orjson requires rust cdylib support, which musl doesn't have yet"
+	depends on BR2_TOOLCHAIN_USES_MUSL
Signature · 1 line
2.35.1
Quoted 5 lines
Quoted 4 lines

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#5 lore raw

Re: [Buildroot] [PATCH v2] package/python-orjson: disallow build when using musl.

Graeme, All,

On 2023-02-07 09:14 -0800, Graeme Smecher spake thusly:

Quoted 4 lines · Yann E. MORIN
Quoted 3 lines

On 2022-05-19 09:02 -0700, Graeme Smecher spake thusly:

Quoted 1 line

The python-orjson build bails as follows when using musl libc:

I could not reproduce such an error wit the following defconfig:

[--SNIP--]

Quoted 3 lines

This patch is obsolete. I used to receive orjson build failures associated with musl on a regular basis - they have tapered off since mid-2022.

In the meantime, Thomas has bisected the resolution to that commit from James:

2cbf1e4d3a1a package/python-orjson: convert to use the python-package infrastructure

The commit before, it fails to build; with that commit, the build succeeds.

Regards,
Yann E. MORIN.

Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#6 lore raw

Re: [Buildroot] [PATCH v2] package/python-orjson: disallow build when using musl.

Hi Yann,

Quoted 12 lines · Yann E. MORIN

Graeme, All,

On 2023-02-07 09:14 -0800, Graeme Smecher spake thusly:

Quoted 4 lines · Yann E. MORIN
Quoted 3 lines

On 2022-05-19 09:02 -0700, Graeme Smecher spake thusly:

Quoted 1 line

The python-orjson build bails as follows when using musl libc:

I could not reproduce such an error wit the following defconfig:

[--SNIP--]

Quoted 3 lines

This patch is obsolete. I used to receive orjson build failures associated with musl on a regular basis - they have tapered off since mid-2022.

Quoted 7 lines

In the meantime, Thomas has bisected the resolution to that commit from James:

2cbf1e4d3a1a package/python-orjson: convert to use the python-package infrastructure

The commit before, it fails to build; with that commit, the build succeeds.

Excellent - two birds, one stone. Thanks again for all your work.

best,
Graeme
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#7 lore raw
In reply to Graeme Smecher
Quoted 22 lines · Graeme Smecher
---
 package/python-orjson/python-orjson.hash | 2 +-
 package/python-orjson/python-orjson.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/python-orjson/python-orjson.hash +1 -1
index 5ef2726d82..2c00164702 100644
@@ -1,4 +1,4 @@
 # Locally calculated
-sha256  4713b120ad86b1b273f5952cbf9578c13d0f453064bd26d823e04a10c84824e6  python-orjson-3.6.7.tar.gz
+sha256  2b0259ff26455c4f9ad2290b49ba184a35e98eea4839f0d6d5c2b7d91383b3d9  python-orjson-3.6.8.tar.gz
 sha256  a60eea817514531668d7e00765731449fe14d059d3249e0bc93b36de45f759f2  LICENSE-APACHE
 sha256  23f18e03dc49df91622fe2a76176497404e46ced8a715d9d2b67a7446571cca3  LICENSE-MIT
package/python-orjson/python-orjson.mk +0 -0
index 5de4b2c5fa..cfcaedc280 100644

package/python-orjson/python-orjson.mk line 8

Quoted 6 lines
package/python-orjson/python-orjson.mk +1 -1
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-PYTHON_ORJSON_VERSION = 3.6.7
+PYTHON_ORJSON_VERSION = 3.6.8
 PYTHON_ORJSON_SITE = $(call github,ijl,orjson,$(PYTHON_ORJSON_VERSION))

This package should be using the python package infrastructure instead of cargo, I went ahead and converted it here:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

I just needed to add the maturin pep517 backend here:
https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

Quoted 9 lines
package/python-orjson/python-orjson.mk +0 -1
 PYTHON_ORJSON_LICENSE = Apache-2.0 or MIT
 PYTHON_ORJSON_LICENSE_FILES = LICENSE-APACHE LICENSE-MIT
--

2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#8 lore raw
In reply to Graeme Smecher
Quoted 5 lines · On Mon, 9 May 2022 12:06:49 -0700 Graeme Smecher…
---
 package/python-orjson/python-orjson.hash | 2 +-
 package/python-orjson/python-orjson.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot