Skip to contentSkip to conversation

ARM: Silence proc-v7-bugs.c spam about disabled Spectre workarounds

PATCH In review Dmitry Osipenko 2 participants 3 messages May 19, 2022 – Jun 28, 2022 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: Silence proc-v7-bugs.c spam about disabled Spectre workarounds

Print message about disabled Spectre workarounds only once to stop endless spam into KSMG each time CPU goes out from idling state. This spam makes system unusable with CONFIG_HARDEN_BRANCH_PREDICTOR=n for those who don't care about security and wants maximum performance.

---
 arch/arm/mm/proc-v7-bugs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/mm/proc-v7-bugs.c +1 -2
index fb9f3eb6bf48..f9730eba0632 100644
@@ -108,8 +108,7 @@ static unsigned int spectre_v2_install_workaround(unsigned int method)
 #else
 static unsigned int spectre_v2_install_workaround(unsigned int method)
 {
-	pr_info("CPU%u: Spectre V2: workarounds disabled by configuration\n",
-		smp_processor_id());
+	pr_info_once("Spectre V2: workarounds disabled by configuration\n");
 
 	return SPECTRE_VULNERABLE;
 }
Signature · 1 line
2.35.3
#1 lore raw
Quoted 15 lines · Dmitry Osipenko

Print message about disabled Spectre workarounds only once to stop endless spam into KSMG each time CPU goes out from idling state. This spam makes system unusable with CONFIG_HARDEN_BRANCH_PREDICTOR=n for those who don't care about security and wants maximum performance.

---
 arch/arm/mm/proc-v7-bugs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/mm/proc-v7-bugs.c +0 -0
index fb9f3eb6bf48..f9730eba0632 100644

arch/arm/mm/proc-v7-bugs.c static unsigned int spectre_v2_install_workaround(unsigned int method) · line 114

Quoted 9 lines
arch/arm/mm/proc-v7-bugs.c +1 -2
@@ -108,8 +108,7 @@ static unsigned int spectre_v2_install_workaround(unsigned int method)
 #else
 static unsigned int spectre_v2_install_workaround(unsigned int method)
 {
-	pr_info("CPU%u: Spectre V2: workarounds disabled by configuration\n",
-		smp_processor_id());
+	pr_info_once("Spectre V2: workarounds disabled by configuration\n");
 
 	return SPECTRE_VULNERABLE;
 }

Hello Russell,

Could you please apply this patch? I tried to use yours patch tracker today and it doesn't allow me to recover my password (server error: MAIL FROM command failed Detail: Space shortage).

Thanks!

Signature · 2 lines
Best regards,
Dmitry
#2 lore raw
Quoted 23 lines · Dmitry Osipenko
Quoted 22 lines · Dmitry Osipenko

Print message about disabled Spectre workarounds only once to stop endless spam into KSMG each time CPU goes out from idling state. This spam makes system unusable with CONFIG_HARDEN_BRANCH_PREDICTOR=n for those who don't care about security and wants maximum performance.

---
 arch/arm/mm/proc-v7-bugs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
arch/arm/mm/proc-v7-bugs.c +1 -2
index fb9f3eb6bf48..f9730eba0632 100644
@@ -108,8 +108,7 @@ static unsigned int spectre_v2_install_workaround(unsigned int method)
 #else
 static unsigned int spectre_v2_install_workaround(unsigned int method)
 {
-	pr_info("CPU%u: Spectre V2: workarounds disabled by configuration\n",
-		smp_processor_id());
+	pr_info_once("Spectre V2: workarounds disabled by configuration\n");
 
Quoted 8 lines

arch/arm/mm/proc-v7-bugs.c static unsigned int spectre_v2_install_workaround(unsigned int method) · line 114

Quoted 2 lines
arch/arm/mm/proc-v7-bugs.c +0 -0
 	return SPECTRE_VULNERABLE;
 }

Hello Russell,

Could you please apply this patch? I tried to use yours patch tracker today and it doesn't allow me to recover my password (server error: MAIL FROM command failed Detail: Space shortage).

That should now be working - thanks to apt needlessly consuming 200MB of space. Please use the patch system, thanks.

Signature · 2 lines
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!