Skip to contentSkip to conversation

ASoC: rt1308-sdw: add the default value of register 0xc320

PATCH In review [email protected] 3 participants 3 messages May 20, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: rt1308-sdw: add the default value of register 0xc320

From: Shuming Fan <[email protected]>

The driver missed the default value of register 0xc320. This patch adds that default value to avoid the error messages when the driver went to suspend mode already.

---
 sound/soc/codecs/rt1308-sdw.h | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/rt1308-sdw.h +1 -0
index c5ce75666dcc..6668e19d85d4 100644
@@ -140,6 +140,7 @@ static const struct reg_default rt1308_reg_defaults[] = {
 	{ 0x3008, 0x02 },
 	{ 0x300a, 0x00 },
 	{ 0xc003 | (RT1308_DAC_SET << 4), 0x00 },
+	{ 0xc000 | (RT1308_POWER << 4), 0x00 },
 	{ 0xc001 | (RT1308_POWER << 4), 0x00 },
 	{ 0xc002 | (RT1308_POWER << 4), 0x00 },
 };
Signature · 1 line
2.35.3
Tested-by on v1 1/1
#1 lore raw
Quoted 8 lines · On 5/20/22 04:02, [email protected] wrote:

From: Shuming Fan <[email protected]>

The driver missed the default value of register 0xc320. This patch adds that default value to avoid the error messages when the driver went to suspend mode already.

Quoted 16 lines
---
 sound/soc/codecs/rt1308-sdw.h | 1 +
 1 file changed, 1 insertion(+)
sound/soc/codecs/rt1308-sdw.h +1 -0
index c5ce75666dcc..6668e19d85d4 100644
@@ -140,6 +140,7 @@ static const struct reg_default rt1308_reg_defaults[] = {
 	{ 0x3008, 0x02 },
 	{ 0x300a, 0x00 },
 	{ 0xc003 | (RT1308_DAC_SET << 4), 0x00 },
+	{ 0xc000 | (RT1308_POWER << 4), 0x00 },
 	{ 0xc001 | (RT1308_POWER << 4), 0x00 },
 	{ 0xc002 | (RT1308_POWER << 4), 0x00 },
 };
maintainer
#2 lore raw
In reply to [email protected]
Quoted 8 lines · On Fri, 20 May 2022 17:02:05 +0800, [email protected] wrote:

From: Shuming Fan <[email protected]>

The driver missed the default value of register 0xc320. This patch adds that default value to avoid the error messages when the driver went to suspend mode already.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt1308-sdw: add the default value of register 0xc320

      commit: affa9983e7cbac8cbe2596975efacdbdf0eb18e9

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark