Skip to contentSkip to conversation

ceph/002: fix test expected output

PATCH In review Luís Henriques 3 participants 5 messages May 20, 2022 – Jun 7, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ceph/002: fix test expected output

Commit daa0c0146c7d ("fstests: replace hexdump with od command") broke ceph/002 by adding an extra '0' in the offset column. Fix it.

---
 tests/ceph/002.out | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/ceph/002.out +1 -1
index f7f1c0ba8487..4f766c257a9c 100644
@@ -5,4 +5,4 @@ QA output created by 002
 *
 800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63  >cccccccccccccccc<
 *
-c000000
+c00000
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Luís Henriques

Commit daa0c0146c7d ("fstests: replace hexdump with od command") broke ceph/002 by adding an extra '0' in the offset column. Fix it.

---

Oh, that's my bad, I changed that in daa0c014 ("fstests: replace hexdump with od command"), but write an extra '0' for ceph/002.out [1]. And due to I don't test cephfs, so missed this failure. Thanks for fixing it!

[1]
...

tests/ceph/002.out +4 -4
index 6f067250..f7f1c0ba 100644
@@ -1,8 +1,8 @@
 QA output created by 002
-0000000 6161 6161 6161 6161 6161 6161 6161 6161
+000000 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61  >aaaaaaaaaaaaaaaa<
 *
-0400000 6262 6262 6262 6262 6262 6262 6262 6262
+400000 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62  >bbbbbbbbbbbbbbbb<
 *
-0800000 6363 6363 6363 6363 6363 6363 6363 6363
+800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63  >cccccccccccccccc<
 *
-0c00000
+c000000

...

Quoted 14 lines
 tests/ceph/002.out | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/ceph/002.out +1 -1
index f7f1c0ba8487..4f766c257a9c 100644
@@ -5,4 +5,4 @@ QA output created by 002
 *
 800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63  >cccccccccccccccc<
 *
-c000000
+c00000
#2 lore raw
Quoted 4 lines · Zorro Lang
Quoted 3 lines · Luís Henriques

Commit daa0c0146c7d ("fstests: replace hexdump with od command") broke ceph/002 by adding an extra '0' in the offset column. Fix it.

Quoted 8 lines
Quoted 2 lines

---

Oh, that's my bad, I changed that in daa0c014 ("fstests: replace hexdump with od command"), but write an extra '0' for ceph/002.out [1]. And due to I don't test cephfs, so missed this failure. Thanks for fixing it!

Hi Luís,

Sorry, I just noticed that I missed this one in this week fstests release, I'll merge and push it in next weekend (05.29) :)

Thanks,
Zorro

Quoted 36 lines

[1]
...

tests/ceph/002.out +4 -4
index 6f067250..f7f1c0ba 100644
@@ -1,8 +1,8 @@
 QA output created by 002
-0000000 6161 6161 6161 6161 6161 6161 6161 6161
+000000 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61  >aaaaaaaaaaaaaaaa<
 *
-0400000 6262 6262 6262 6262 6262 6262 6262 6262
+400000 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62  >bbbbbbbbbbbbbbbb<
 *
-0800000 6363 6363 6363 6363 6363 6363 6363 6363
+800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63  >cccccccccccccccc<
 *
-0c00000
+c000000
...
Quoted 15 lines
 tests/ceph/002.out | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/ceph/002.out +1 -1
index f7f1c0ba8487..4f766c257a9c 100644
@@ -5,4 +5,4 @@ QA output created by 002
 *
 800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63  >cccccccccccccccc<
 *
-c000000
+c00000
#3 lore raw
Quoted 12 lines · Zorro Lang
Quoted 11 lines · Zorro Lang
Quoted 5 lines · Luís Henriques

Commit daa0c0146c7d ("fstests: replace hexdump with od command") broke ceph/002 by adding an extra '0' in the offset column. Fix it.

---

Oh, that's my bad, I changed that in daa0c014 ("fstests: replace hexdump with od command"), but write an extra '0' for ceph/002.out [1]. And due to I don't test cephfs, so missed this failure. Thanks for fixing it!

Quoted 6 lines
Quoted 1 line

Hi Luís,

Sorry, I just noticed that I missed this one in this week fstests release, I'll merge and push it in next weekend (05.29) :)

Sure, no worries. Thanks.

Cheers,
--
Luís

Quoted 40 lines

Thanks,
Zorro

Quoted 36 lines

[1]
...

tests/ceph/002.out +4 -4
index 6f067250..f7f1c0ba 100644
@@ -1,8 +1,8 @@
 QA output created by 002
-0000000 6161 6161 6161 6161 6161 6161 6161 6161
+000000 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61  >aaaaaaaaaaaaaaaa<
 *
-0400000 6262 6262 6262 6262 6262 6262 6262 6262
+400000 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62  >bbbbbbbbbbbbbbbb<
 *
-0800000 6363 6363 6363 6363 6363 6363 6363 6363
+800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63  >cccccccccccccccc<
 *
-0c00000
+c000000
...
Quoted 15 lines
 tests/ceph/002.out | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/ceph/002.out +1 -1
index f7f1c0ba8487..4f766c257a9c 100644
@@ -5,4 +5,4 @@ QA output created by 002
 *
 800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63  >cccccccccccccccc<
 *
-c000000
+c00000
#4 lore raw
In reply to Zorro Lang
Quoted 12 lines · Zorro Lang
Quoted 11 lines · Zorro Lang
Quoted 5 lines · Luís Henriques

Commit daa0c0146c7d ("fstests: replace hexdump with od command") broke ceph/002 by adding an extra '0' in the offset column. Fix it.

---

Oh, that's my bad, I changed that in daa0c014 ("fstests: replace hexdump with od command"), but write an extra '0' for ceph/002.out [1]. And due to I don't test cephfs, so missed this failure. Thanks for fixing it!

Quoted 7 lines
Quoted 1 line

Hi Luís,

Sorry, I just noticed that I missed this one in this week fstests release, I'll merge and push it in next weekend (05.29) :)

Ping. Looks like this hasn't yet been merged.

Cheers,
--
Luís

Quoted 39 lines

Thanks,
Zorro

Quoted 36 lines

[1]
...

tests/ceph/002.out +4 -4
index 6f067250..f7f1c0ba 100644
@@ -1,8 +1,8 @@
 QA output created by 002
-0000000 6161 6161 6161 6161 6161 6161 6161 6161
+000000 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61 61  >aaaaaaaaaaaaaaaa<
 *
-0400000 6262 6262 6262 6262 6262 6262 6262 6262
+400000 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62 62  >bbbbbbbbbbbbbbbb<
 *
-0800000 6363 6363 6363 6363 6363 6363 6363 6363
+800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63  >cccccccccccccccc<
 *
-0c00000
+c000000
...
Quoted 15 lines
 tests/ceph/002.out | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/ceph/002.out +1 -1
index f7f1c0ba8487..4f766c257a9c 100644
@@ -5,4 +5,4 @@ QA output created by 002
 *
 800000 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63 63  >cccccccccccccccc<
 *
-c000000
+c00000