Skip to contentSkip to conversation

configs: imx8mp_venice: add FEC_QUIRK_ENET_MAC

PATCH In review Tim Harvey 2 participants 3 messages Apr 29, 2022 – May 20, 2022 Arm i.MX and Layerscape

lore
Share & tools
lore

Tim Harvey

author
#0 lore raw

PATCH 1/1 configs: imx8mp_venice: add FEC_QUIRK_ENET_MAC

The IMX8MP SoC FEC needs to have the FEC_QUIRK_ENET_MAC defined.

Fixes commit 2395625209cc ("board: gateworks: venice: add imx8mp-venice-gw740x support")
---
 include/configs/imx8mp_venice.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/imx8mp_venice.h +4 -0
index aa0396db8b83..4120e4cc6bad 100644
@@ -106,4 +106,8 @@
 #define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
 #define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
 					sizeof(CONFIG_SYS_PROMPT) + 16)
+
+/* FEC */
+#define FEC_QUIRK_ENET_MAC
+
 #endif
Signature · 1 line
2.17.1
author
#1 lore raw
Quoted 23 lines · Tim Harvey

The IMX8MP SoC FEC needs to have the FEC_QUIRK_ENET_MAC defined.

Fixes commit 2395625209cc ("board: gateworks: venice: add imx8mp-venice-gw740x support")
---
 include/configs/imx8mp_venice.h | 4 ++++
 1 file changed, 4 insertions(+)
include/configs/imx8mp_venice.h +4 -1
index aa0396db8b83..4120e4cc6bad 100644
@@ -106,4 +106,8 @@
 #define CONFIG_SYS_BARGSIZE            CONFIG_SYS_CBSIZE
 #define CONFIG_SYS_PBSIZE              (CONFIG_SYS_CBSIZE + \
                                        sizeof(CONFIG_SYS_PROMPT) + 16)
+
+/* FEC */
+#define FEC_QUIRK_ENET_MAC
+
 #endif
--
Quoted 2 lines

2.17.1

Stefano,

Please drop this. FEC_QUIRK_ENET_MAC is defined in the imx-regs includes for imx8.

Regardless, it seems there are several imx8m board include files that are defining FEC_QUIRK_ENET_MAC in their include - I'll send a patch to remove those as they are unnecessary.

Best Regards,

Tim

#2 lore raw

PATCH 1/1 configs: imx8mp_venice: add FEC_QUIRK_ENET_MAC

In reply to Tim Harvey
Quoted 3 lines

The IMX8MP SoC FEC needs to have the FEC_QUIRK_ENET_MAC defined.

Fixes commit 2395625209cc ("board: gateworks: venice: add imx8mp-venice-gw740x support")

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================