Skip to contentSkip to conversation

imx8mm-cl-iot-gate: Enable cache in SPL

PATCH In review Fabio Estevam 3 participants 7 messages May 19, 2022 – May 20, 2022 Arm i.MX and Layerscape

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/3 imx8mm-cl-iot-gate: Enable cache in SPL

From: Fabio Estevam <[email protected]>

There is no reason for disabling I-cache and D-cache in SPL.

Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF options.

---
 configs/imx8mm-cl-iot-gate-optee_defconfig | 2 --
 configs/imx8mm-cl-iot-gate_defconfig       | 2 --
 2 files changed, 4 deletions(-)
configs/imx8mm-cl-iot-gate-optee_defconfig +0 -2
index 0bde51a91f53..8b3d1b3ef1a1 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SPL_GPIO=y
configs/imx8mm-cl-iot-gate_defconfig +0 -2
index d734586a60cc..b418e86248f9 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SYS_MALLOC_LEN=0x2000000
Signature · 1 line
2.25.1
author reviewer
#1 lore raw

PATCH 2/3 cgtqmx8: Enable cache in SPL

From: Fabio Estevam <[email protected]>

There is no reason for disabling I-cache and D-cache in SPL.

Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF options.

---
 configs/cgtqmx8_defconfig | 2 --
 1 file changed, 2 deletions(-)
configs/cgtqmx8_defconfig +0 -2
index 2cf882f826ab..c53fa742751a 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8=y
 CONFIG_SYS_TEXT_BASE=0x80020000
 CONFIG_SYS_MALLOC_LEN=0x2400000
Signature · 1 line
2.25.1
#2 lore raw

PATCH 2/3 cgtqmx8: Enable cache in SPL

Quoted 7 lines

From: Fabio Estevam <[email protected]>
There is no reason for disabling I-cache and D-cache in SPL.

Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF options.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
author reviewer
#3 lore raw

PATCH 3/3 imx8mp_rsb3720a1: Enable cache in SPL

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

There is no reason for disabling I-cache and D-cache in SPL.

Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF options.

---
 configs/imx8mp_rsb3720a1_4G_defconfig | 2 --
 configs/imx8mp_rsb3720a1_6G_defconfig | 2 --
 2 files changed, 4 deletions(-)
configs/imx8mp_rsb3720a1_4G_defconfig +0 -2
index a7585ba71f0f..d7f1aa0f1550 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SYS_MALLOC_LEN=0x2000000
configs/imx8mp_rsb3720a1_6G_defconfig +0 -2
index 5d06dc4a88d0..7ceac2b14e3a 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SYS_MALLOC_LEN=0x2000000
Signature · 1 line
2.25.1
#4 lore raw

PATCH 3/3 imx8mp_rsb3720a1: Enable cache in SPL

Quoted 7 lines

From: Fabio Estevam <[email protected]>
There is no reason for disabling I-cache and D-cache in SPL.

Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF options.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================
Reviewed-by on v1 1/3
#5 lore raw
In reply to Fabio Estevam

Hi Fabio

Quoted 38 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

There is no reason for disabling I-cache and D-cache in SPL.

Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF options.

---
 configs/imx8mm-cl-iot-gate-optee_defconfig | 2 --
 configs/imx8mm-cl-iot-gate_defconfig       | 2 --
 2 files changed, 4 deletions(-)
configs/imx8mm-cl-iot-gate-optee_defconfig +0 -2
index 0bde51a91f53..8b3d1b3ef1a1 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SPL_GPIO=y
configs/imx8mm-cl-iot-gate_defconfig +0 -3
index d734586a60cc..b418e86248f9 100644
@@ -1,6 +1,4 @@
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SYS_MALLOC_LEN=0x2000000
--
Quoted 2 lines

2.25.1

Michael

Signature · 11 lines
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
[email protected]
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
[email protected]
www.amarulasolutions.com
#6 lore raw

PATCH 1/3 imx8mm-cl-iot-gate: Enable cache in SPL

In reply to Fabio Estevam
Quoted 8 lines

From: Fabio Estevam <[email protected]>
There is no reason for disabling I-cache and D-cache in SPL.

Remove the unneeded CONFIG_SPL_SYS_ICACHE_OFF and
CONFIG_SPL_SYS_DCACHE_OFF options.

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: [email protected]
=====================================================================