Skip to contentSkip to conversation

QOM improvements for rtc/mc146818rtc

PATCH Superseded Bernhard Beschow 2 participants 9 messages May 20, 2022 – May 22, 2022

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

cover QOM improvements for rtc/mc146818rtc

This little series enhances QOM support for mc146818rtc:
* makes microvm-dt respect mc146818rtc's IRQ number set by QOM property and
* adds an io_base QOM property similar to other ISA devices

Bernhard Beschow (2):
hw/i386/microvm-dt: Determine mc146818rtc's IRQ number from QOM
property
rtc/mc146818rtc: QOM'ify io_base offset

 hw/i386/microvm-dt.c         | 4 ++--
 hw/rtc/mc146818rtc.c         | 7 ++++---
 include/hw/rtc/mc146818rtc.h | 2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)
Signature · 1 line
2.36.1
#1 lore raw

PATCH 1/2 hw/i386/microvm-dt: Determine mc146818rtc's IRQ number from QOM property

Since commit 3b004a16540aa41f2aa6a1ceb0bf306716766914 'hw/rtc/
mc146818rtc: QOM'ify IRQ number' mc146818rtc's IRQ number is configurable. Fix microvm-dt to respect its value.

---
 hw/i386/microvm-dt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/microvm-dt.c +1 -1
index 9c3c4995b4..a5db9e4e5a 100644
@@ -208,7 +208,7 @@ static void dt_add_isa_serial(MicrovmMachineState *mms, ISADevice *dev)
 static void dt_add_isa_rtc(MicrovmMachineState *mms, ISADevice *dev)
 {
     const char compat[] = "motorola,mc146818";
-    uint32_t irq = RTC_ISA_IRQ;
+    uint32_t irq = object_property_get_uint(OBJECT(dev), "irq", NULL);
     hwaddr base = RTC_ISA_BASE;
     hwaddr size = 8;
     char *nodename;
Signature · 1 line
2.36.1
Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] hw/i386/microvm-dt: Determine mc146818rtc's IRQ number from QOM property

Quoted 14 lines · Bernhard Beschow

Since commit 3b004a16540aa41f2aa6a1ceb0bf306716766914 'hw/rtc/
mc146818rtc: QOM'ify IRQ number' mc146818rtc's IRQ number is configurable. Fix microvm-dt to respect its value.

---
  hw/i386/microvm-dt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/microvm-dt.c +0 -0
index 9c3c4995b4..a5db9e4e5a 100644

hw/i386/microvm-dt.c static void dt_add_isa_serial(MicrovmMachineState *mms, ISADevice *dev) · line 214

Quoted 8 lines
hw/i386/microvm-dt.c +1 -1
@@ -208,7 +208,7 @@ static void dt_add_isa_serial(MicrovmMachineState *mms, ISADevice *dev)
  static void dt_add_isa_rtc(MicrovmMachineState *mms, ISADevice *dev)
  {
      const char compat[] = "motorola,mc146818";
-    uint32_t irq = RTC_ISA_IRQ;
+    uint32_t irq = object_property_get_uint(OBJECT(dev), "irq", NULL);
      hwaddr base = RTC_ISA_BASE;
      hwaddr size = 8;
      char *nodename;

Rather than using NULL as the last parameter to object_property_get_uint() I think using &error_abort to force an explicit failure if the irq property doesn't exist would be better.

Otherwise:

ATB,

Mark.

#3 lore raw

Re: [PATCH 1/2] hw/i386/microvm-dt: Determine mc146818rtc's IRQ number from QOM property

Quoted 26 lines · Mark Cave-Ayland

hw/i386/microvm-dt.c static void dt_add_isa_serial(MicrovmMachineState

Quoted 14 lines · Bernhard Beschow

Since commit 3b004a16540aa41f2aa6a1ceb0bf306716766914 'hw/rtc/
mc146818rtc: QOM'ify IRQ number' mc146818rtc's IRQ number is configurable. Fix microvm-dt to respect its value.

---
  hw/i386/microvm-dt.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
hw/i386/microvm-dt.c +0 -0
index 9c3c4995b4..a5db9e4e5a 100644
@@ -208,7 +208,7 @@ static void dt_add_isa_serial(MicrovmMachineState

*mms, ISADevice *dev)

hw/i386/microvm-dt.c static void dt_add_isa_serial(MicrovmMachineState *mms, ISADevice *dev) · line 214

Quoted 8 lines
hw/i386/microvm-dt.c +1 -1
  static void dt_add_isa_rtc(MicrovmMachineState *mms, ISADevice *dev)
  {
      const char compat[] = "motorola,mc146818";
-    uint32_t irq = RTC_ISA_IRQ;
+    uint32_t irq = object_property_get_uint(OBJECT(dev), "irq", NULL);
      hwaddr base = RTC_ISA_BASE;
      hwaddr size = 8;
      char *nodename;
Quoted 6 lines

Rather than using NULL as the last parameter to object_property_get_uint() I think
using &error_abort to force an explicit failure if the irq property doesn't exist
would be better.

Ack. I'll then also fix dt_add_isa_serial() in a dedicated commit for consistency.

Otherwise:

Quoted 8 lines

ATB,

Mark.

#4 lore raw

PATCH 2/2 rtc/mc146818rtc: QOM'ify io_base offset

In reply to Bernhard Beschow

Exposing the io_base offset as a QOM property not only allows it to be configurable but also to be displayed in HMP:

Before:

(qemu) info qtree

       ...
          dev: mc146818rtc, id ""
            gpio-out "" 1
            base_year = 0 (0x0)
            irq = 8 (0x8)
            lost_tick_policy = "discard"

After:

          dev: mc146818rtc, id ""
            gpio-out "" 1
            base_year = 0 (0x0)
            iobase = 112 (0x70)
            irq = 8 (0x8)
            lost_tick_policy = "discard"
---
 hw/i386/microvm-dt.c         | 2 +-
 hw/rtc/mc146818rtc.c         | 7 ++++---
 include/hw/rtc/mc146818rtc.h | 2 +-
 3 files changed, 6 insertions(+), 5 deletions(-)
hw/i386/microvm-dt.c +1 -1
index a5db9e4e5a..39fe425b26 100644
@@ -209,7 +209,7 @@ static void dt_add_isa_rtc(MicrovmMachineState *mms, ISADevice *dev)
 {
     const char compat[] = "motorola,mc146818";
     uint32_t irq = object_property_get_uint(OBJECT(dev), "irq", NULL);
-    hwaddr base = RTC_ISA_BASE;
+    hwaddr base = object_property_get_int(OBJECT(dev), "iobase", NULL);
     hwaddr size = 8;
     char *nodename;
 
hw/rtc/mc146818rtc.c +4 -3
index f235c2ddbe..484f91b6f8 100644
@@ -941,7 +941,7 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)
     qemu_register_suspend_notifier(&s->suspend_notifier);
 
     memory_region_init_io(&s->io, OBJECT(s), &cmos_ops, s, "rtc", 2);
-    isa_register_ioport(isadev, &s->io, RTC_ISA_BASE);
+    isa_register_ioport(isadev, &s->io, s->io_base);
 
     /* register rtc 0x70 port for coalesced_pio */
     memory_region_set_flush_coalesced(&s->io);
@@ -950,7 +950,7 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)
     memory_region_add_subregion(&s->io, 0, &s->coalesced_io);
     memory_region_add_coalescing(&s->coalesced_io, 0, 1);
 
-    qdev_set_legacy_instance_id(dev, RTC_ISA_BASE, 3);
+    qdev_set_legacy_instance_id(dev, s->io_base, 3);
 
     object_property_add_tm(OBJECT(s), "date", rtc_get_date);
 
@@ -983,6 +983,7 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)
 
 static Property mc146818rtc_properties[] = {
     DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980),
+    DEFINE_PROP_UINT32("iobase", RTCState, io_base, 0x70),
     DEFINE_PROP_UINT8("irq", RTCState, isairq, RTC_ISA_IRQ),
     DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
                                lost_tick_policy, LOST_TICK_POLICY_DISCARD),
@@ -1028,7 +1029,7 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope)
      * does, even though qemu only responds to the first two ports.
      */
     crs = aml_resource_template();
-    aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
+    aml_append(crs, aml_io(AML_DECODE16, s->io_base, s->io_base,
                            0x01, 0x08));
     aml_append(crs, aml_irq_no_flags(s->isairq));
 
include/hw/rtc/mc146818rtc.h +1 -1
index 33d85753c0..1f7942a9f8 100644
@@ -26,6 +26,7 @@ struct RTCState {
     uint8_t cmos_data[128];
     uint8_t cmos_index;
     uint8_t isairq;
+    uint32_t io_base;
     int32_t base_year;
     uint64_t base_rtc;
     uint64_t last_update;
@@ -49,7 +50,6 @@ struct RTCState {
 };
 
 #define RTC_ISA_IRQ 8
-#define RTC_ISA_BASE 0x70
 
 ISADevice *mc146818_rtc_init(ISABus *bus, int base_year,
                              qemu_irq intercept_irq);
Signature · 1 line
2.36.1
Reviewed-by on v1 2/2
#5 lore raw

Re: [PATCH 2/2] rtc/mc146818rtc: QOM'ify io_base offset

Quoted 34 lines · Bernhard Beschow

Exposing the io_base offset as a QOM property not only allows it to be configurable but also to be displayed in HMP:

Before:

(qemu) info qtree

        ...
           dev: mc146818rtc, id ""
             gpio-out "" 1
             base_year = 0 (0x0)
             irq = 8 (0x8)
             lost_tick_policy = "discard"

After:

           dev: mc146818rtc, id ""
             gpio-out "" 1
             base_year = 0 (0x0)
             iobase = 112 (0x70)
             irq = 8 (0x8)
             lost_tick_policy = "discard"
---
  hw/i386/microvm-dt.c         | 2 +-
  hw/rtc/mc146818rtc.c         | 7 ++++---
  include/hw/rtc/mc146818rtc.h | 2 +-
  3 files changed, 6 insertions(+), 5 deletions(-)
hw/i386/microvm-dt.c +0 -0
index a5db9e4e5a..39fe425b26 100644

hw/i386/microvm-dt.c static void dt_add_isa_rtc(MicrovmMachineState *mms, ISADevice *dev) · line 212

Quoted 5 lines
hw/i386/microvm-dt.c +1 -1
@@ -209,7 +209,7 @@ static void dt_add_isa_rtc(MicrovmMachineState *mms, ISADevice *dev)
  {
      const char compat[] = "motorola,mc146818";
      uint32_t irq = object_property_get_uint(OBJECT(dev), "irq", NULL);
-    hwaddr base = RTC_ISA_BASE;
+    hwaddr base = object_property_get_int(OBJECT(dev), "iobase", NULL);

Same comment here re: &error_abort.

Quoted 26 lines
hw/i386/microvm-dt.c +0 -0
      hwaddr size = 8;
      char *nodename;
 
hw/rtc/mc146818rtc.c +2 -2
index f235c2ddbe..484f91b6f8 100644
@@ -941,7 +941,7 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)
      qemu_register_suspend_notifier(&s->suspend_notifier);
 
      memory_region_init_io(&s->io, OBJECT(s), &cmos_ops, s, "rtc", 2);
-    isa_register_ioport(isadev, &s->io, RTC_ISA_BASE);
+    isa_register_ioport(isadev, &s->io, s->io_base);
 
      /* register rtc 0x70 port for coalesced_pio */
      memory_region_set_flush_coalesced(&s->io);
@@ -950,7 +950,7 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)
      memory_region_add_subregion(&s->io, 0, &s->coalesced_io);
      memory_region_add_coalescing(&s->coalesced_io, 0, 1);
 
-    qdev_set_legacy_instance_id(dev, RTC_ISA_BASE, 3);
+    qdev_set_legacy_instance_id(dev, s->io_base, 3);
 
      object_property_add_tm(OBJECT(s), "date", rtc_get_date);
 

hw/rtc/mc146818rtc.c ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq) · line 986

Quoted 4 lines
hw/rtc/mc146818rtc.c +1 -0
@@ -983,6 +983,7 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)
 
  static Property mc146818rtc_properties[] = {
      DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980),
+    DEFINE_PROP_UINT32("iobase", RTCState, io_base, 0x70),

I think this should be RTC_ISA_BASE?

Quoted 25 lines
hw/rtc/mc146818rtc.c +1 -1
      DEFINE_PROP_UINT8("irq", RTCState, isairq, RTC_ISA_IRQ),
      DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
                                 lost_tick_policy, LOST_TICK_POLICY_DISCARD),
@@ -1028,7 +1029,7 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope)
       * does, even though qemu only responds to the first two ports.
       */
      crs = aml_resource_template();
-    aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
+    aml_append(crs, aml_io(AML_DECODE16, s->io_base, s->io_base,
                             0x01, 0x08));
      aml_append(crs, aml_irq_no_flags(s->isairq));
 
include/hw/rtc/mc146818rtc.h +1 -0
index 33d85753c0..1f7942a9f8 100644
@@ -26,6 +26,7 @@ struct RTCState {
      uint8_t cmos_data[128];
      uint8_t cmos_index;
      uint8_t isairq;
+    uint32_t io_base;
      int32_t base_year;
      uint64_t base_rtc;
      uint64_t last_update;

include/hw/rtc/mc146818rtc.h struct RTCState { · line 52

Quoted 4 lines
include/hw/rtc/mc146818rtc.h +0 -1
@@ -49,7 +50,6 @@ struct RTCState {
  };
 
  #define RTC_ISA_IRQ 8
-#define RTC_ISA_BASE 0x70

... and so you'll need to keep this.

include/hw/rtc/mc146818rtc.h struct RTCState { · line 55

Quoted 2 lines
include/hw/rtc/mc146818rtc.h +0 -0
  ISADevice *mc146818_rtc_init(ISABus *bus, int base_year,
                               qemu_irq intercept_irq);

Otherwise:

ATB,

Mark.

#6 lore raw

Re: [PATCH 2/2] rtc/mc146818rtc: QOM'ify io_base offset

Quoted 37 lines · Mark Cave-Ayland

hw/i386/microvm-dt.c static void dt_add_isa_rtc(MicrovmMachineState *mms,

Quoted 34 lines · Bernhard Beschow

Exposing the io_base offset as a QOM property not only allows it to be configurable but also to be displayed in HMP:

Before:

(qemu) info qtree

        ...
           dev: mc146818rtc, id ""
             gpio-out "" 1
             base_year = 0 (0x0)
             irq = 8 (0x8)
             lost_tick_policy = "discard"

After:

           dev: mc146818rtc, id ""
             gpio-out "" 1
             base_year = 0 (0x0)
             iobase = 112 (0x70)
             irq = 8 (0x8)
             lost_tick_policy = "discard"
---
  hw/i386/microvm-dt.c         | 2 +-
  hw/rtc/mc146818rtc.c         | 7 ++++---
  include/hw/rtc/mc146818rtc.h | 2 +-
  3 files changed, 6 insertions(+), 5 deletions(-)
hw/i386/microvm-dt.c +0 -0
index a5db9e4e5a..39fe425b26 100644
@@ -209,7 +209,7 @@ static void dt_add_isa_rtc(MicrovmMachineState *mms,

ISADevice *dev)

Quoted 8 lines

hw/i386/microvm-dt.c static void dt_add_isa_rtc(MicrovmMachineState *mms, ISADevice *dev) · line 212

Quoted 5 lines
hw/i386/microvm-dt.c +1 -1
  {
      const char compat[] = "motorola,mc146818";
      uint32_t irq = object_property_get_uint(OBJECT(dev), "irq", NULL);
-    hwaddr base = RTC_ISA_BASE;
+    hwaddr base = object_property_get_int(OBJECT(dev), "iobase", NULL);

Same comment here re: &error_abort.

Ack.

Quoted 66 lines

hw/rtc/mc146818rtc.c static void rtc_realizefn(DeviceState *dev, Error

Quoted 9 lines
hw/i386/microvm-dt.c +0 -0
      hwaddr size = 8;
      char *nodename;
 
hw/rtc/mc146818rtc.c +0 -0
index f235c2ddbe..484f91b6f8 100644
@@ -941,7 +941,7 @@ static void rtc_realizefn(DeviceState *dev, Error

**errp)

hw/rtc/mc146818rtc.c static void rtc_realizefn(DeviceState *dev, Error

Quoted 9 lines
hw/rtc/mc146818rtc.c +1 -1
      qemu_register_suspend_notifier(&s->suspend_notifier);
 
      memory_region_init_io(&s->io, OBJECT(s), &cmos_ops, s, "rtc", 2);
-    isa_register_ioport(isadev, &s->io, RTC_ISA_BASE);
+    isa_register_ioport(isadev, &s->io, s->io_base);
 
      /* register rtc 0x70 port for coalesced_pio */
      memory_region_set_flush_coalesced(&s->io);
@@ -950,7 +950,7 @@ static void rtc_realizefn(DeviceState *dev, Error

**errp)

hw/rtc/mc146818rtc.c ISADevice *mc146818_rtc_init(ISABus *bus, int

Quoted 9 lines
hw/rtc/mc146818rtc.c +1 -1
      memory_region_add_subregion(&s->io, 0, &s->coalesced_io);
      memory_region_add_coalescing(&s->coalesced_io, 0, 1);
 
-    qdev_set_legacy_instance_id(dev, RTC_ISA_BASE, 3);
+    qdev_set_legacy_instance_id(dev, s->io_base, 3);
 
      object_property_add_tm(OBJECT(s), "date", rtc_get_date);
 
@@ -983,6 +983,7 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int

base_year, qemu_irq intercept_irq)

hw/rtc/mc146818rtc.c ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq) · line 986

Quoted 4 lines
hw/rtc/mc146818rtc.c +1 -0
  static Property mc146818rtc_properties[] = {
      DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980),
+    DEFINE_PROP_UINT32("iobase", RTCState, io_base, 0x70),

I think this should be RTC_ISA_BASE?

hw/rtc/mc146818rtc.c ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)

Quoted 3 lines
hw/rtc/mc146818rtc.c +0 -0
      DEFINE_PROP_UINT8("irq", RTCState, isairq, RTC_ISA_IRQ),
      DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
                                 lost_tick_policy,

LOST_TICK_POLICY_DISCARD),

hw/rtc/mc146818rtc.c static void rtc_build_aml(ISADevice *isadev, Aml

Quoted 1 line
hw/rtc/mc146818rtc.c +0 -0
@@ -1028,7 +1029,7 @@ static void rtc_build_aml(ISADevice *isadev, Aml

*scope)

Quoted 23 lines
hw/rtc/mc146818rtc.c +1 -1
       * does, even though qemu only responds to the first two ports.
       */
      crs = aml_resource_template();
-    aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
+    aml_append(crs, aml_io(AML_DECODE16, s->io_base, s->io_base,
                             0x01, 0x08));
      aml_append(crs, aml_irq_no_flags(s->isairq));
 
include/hw/rtc/mc146818rtc.h +1 -0
index 33d85753c0..1f7942a9f8 100644
@@ -26,6 +26,7 @@ struct RTCState {
      uint8_t cmos_data[128];
      uint8_t cmos_index;
      uint8_t isairq;
+    uint32_t io_base;
      int32_t base_year;
      uint64_t base_rtc;
      uint64_t last_update;
@@ -49,7 +50,6 @@ struct RTCState {
  };
 
Quoted 5 lines

include/hw/rtc/mc146818rtc.h struct RTCState { · line 52

Quoted 2 lines
include/hw/rtc/mc146818rtc.h +0 -1
  #define RTC_ISA_IRQ 8
-#define RTC_ISA_BASE 0x70

... and so you'll need to keep this.

My intention was indeed to remove it since it is now redundant. Keeping the constant public has the risk of using it instead of the user-configurable QOM property which could cause bugs.

Quoted 12 lines

include/hw/rtc/mc146818rtc.h struct RTCState { · line 55

Quoted 2 lines
include/hw/rtc/mc146818rtc.h +0 -0
  ISADevice *mc146818_rtc_init(ISABus *bus, int base_year,
                               qemu_irq intercept_irq);

Otherwise:

ATB,

Mark.

#7 lore raw

Re: [PATCH 2/2] rtc/mc146818rtc: QOM'ify io_base offset

Quoted 118 lines · Bernhard Beschow

On Sat, May 21, 2022 at 11:24 AM Mark Cave-Ayland <[email protected] <mailto:[email protected]>> wrote:

    On 20/05/2022 18:45, Bernhard Beschow wrote:

     > Exposing the io_base offset as a QOM property not only allows it to be
     > configurable but also to be displayed in HMP:
     >
     > Before:
     >
     > (qemu) info qtree
     >         ...
     >            dev: mc146818rtc, id ""
     >              gpio-out "" 1
     >              base_year = 0 (0x0)
     >              irq = 8 (0x8)
     >              lost_tick_policy = "discard"
     >
     > After:
     >
     >            dev: mc146818rtc, id ""
     >              gpio-out "" 1
     >              base_year = 0 (0x0)
     >              iobase = 112 (0x70)
     >              irq = 8 (0x8)
     >              lost_tick_policy = "discard"
     >
     > Signed-off-by: Bernhard Beschow <[email protected] <mailto:[email protected]>>
     > ---
     >   hw/i386/microvm-dt.c         | 2 +-
     >   hw/rtc/mc146818rtc.c         | 7 ++++---
     >   include/hw/rtc/mc146818rtc.h | 2 +-
     >   3 files changed, 6 insertions(+), 5 deletions(-)
     >
     > diff --git a/hw/i386/microvm-dt.c b/hw/i386/microvm-dt.c
     > index a5db9e4e5a..39fe425b26 100644
     > --- a/hw/i386/microvm-dt.c
     > +++ b/hw/i386/microvm-dt.c
     > @@ -209,7 +209,7 @@ static void dt_add_isa_rtc(MicrovmMachineState *mms,
    ISADevice *dev)
     >   {
     >       const char compat[] = "motorola,mc146818";
     >       uint32_t irq = object_property_get_uint(OBJECT(dev), "irq", NULL);
     > -    hwaddr base = RTC_ISA_BASE;
     > +    hwaddr base = object_property_get_int(OBJECT(dev), "iobase", NULL);

    Same comment here re: &error_abort.

Ack.

     >       hwaddr size = 8;
     >       char *nodename;
     >
     > diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c
     > index f235c2ddbe..484f91b6f8 100644
     > --- a/hw/rtc/mc146818rtc.c
     > +++ b/hw/rtc/mc146818rtc.c
     > @@ -941,7 +941,7 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)
     >       qemu_register_suspend_notifier(&s->suspend_notifier);
     >
     >       memory_region_init_io(&s->io, OBJECT(s), &cmos_ops, s, "rtc", 2);
     > -    isa_register_ioport(isadev, &s->io, RTC_ISA_BASE);
     > +    isa_register_ioport(isadev, &s->io, s->io_base);
     >
     >       /* register rtc 0x70 port for coalesced_pio */
     >       memory_region_set_flush_coalesced(&s->io);
     > @@ -950,7 +950,7 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)
     >       memory_region_add_subregion(&s->io, 0, &s->coalesced_io);
     >       memory_region_add_coalescing(&s->coalesced_io, 0, 1);
     >
     > -    qdev_set_legacy_instance_id(dev, RTC_ISA_BASE, 3);
     > +    qdev_set_legacy_instance_id(dev, s->io_base, 3);
     >
     >       object_property_add_tm(OBJECT(s), "date", rtc_get_date);
     >
     > @@ -983,6 +983,7 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_year,
    qemu_irq intercept_irq)
     >
     >   static Property mc146818rtc_properties[] = {
     >       DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980),
     > +    DEFINE_PROP_UINT32("iobase", RTCState, io_base, 0x70),

    I think this should be RTC_ISA_BASE?

     >       DEFINE_PROP_UINT8("irq", RTCState, isairq, RTC_ISA_IRQ),
     >       DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
     >                                  lost_tick_policy, LOST_TICK_POLICY_DISCARD),
     > @@ -1028,7 +1029,7 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope)
     >        * does, even though qemu only responds to the first two ports.
     >        */
     >       crs = aml_resource_template();
     > -    aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
     > +    aml_append(crs, aml_io(AML_DECODE16, s->io_base, s->io_base,
     >                              0x01, 0x08));
     >       aml_append(crs, aml_irq_no_flags(s->isairq));
     >
     > diff --git a/include/hw/rtc/mc146818rtc.h b/include/hw/rtc/mc146818rtc.h
     > index 33d85753c0..1f7942a9f8 100644
     > --- a/include/hw/rtc/mc146818rtc.h
     > +++ b/include/hw/rtc/mc146818rtc.h
     > @@ -26,6 +26,7 @@ struct RTCState {
     >       uint8_t cmos_data[128];
     >       uint8_t cmos_index;
     >       uint8_t isairq;
     > +    uint32_t io_base;
     >       int32_t base_year;
     >       uint64_t base_rtc;
     >       uint64_t last_update;
     > @@ -49,7 +50,6 @@ struct RTCState {
     >   };
     >
     >   #define RTC_ISA_IRQ 8
     > -#define RTC_ISA_BASE 0x70

    ... and so you'll need to keep this.
Quoted 1 line

My intention was indeed to remove it since it is now redundant. Keeping the constant public has the risk of using it instead of the user-configurable QOM property which could cause bugs.

True, that's not a completely unreasonable argument. In that case how about moving the RTC_ISA_BASE define to somewhere around the top of hw/rtc/mc146818rtc.c so that the origin of the 0x70 address is preserved?

Quoted 5 lines

>   ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, >                                qemu_irq intercept_irq);

Otherwise:

Quoted 7 lines

<mailto:[email protected]>>

ATB,

Mark.

ATB,

Mark.

#8 lore raw

Re: [PATCH 2/2] rtc/mc146818rtc: QOM'ify io_base offset

Am 22. Mai 2022 12:13:48 UTC schrieb Mark Cave-Ayland <[email protected]>:

Quoted 117 lines · Bernhard Beschow
Quoted 116 lines · On Sat, May 21, 2022 at 11:24 AM Mark Cave-Ayland…
    On 20/05/2022 18:45, Bernhard Beschow wrote:

     > Exposing the io_base offset as a QOM property not only allows it to be
     > configurable but also to be displayed in HMP:
     >
     > Before:
     >
     > (qemu) info qtree
     >         ...
     >            dev: mc146818rtc, id ""
     >              gpio-out "" 1
     >              base_year = 0 (0x0)
     >              irq = 8 (0x8)
     >              lost_tick_policy = "discard"
     >
     > After:
     >
     >            dev: mc146818rtc, id ""
     >              gpio-out "" 1
     >              base_year = 0 (0x0)
     >              iobase = 112 (0x70)
     >              irq = 8 (0x8)
     >              lost_tick_policy = "discard"
     >
     > Signed-off-by: Bernhard Beschow <[email protected] <mailto:[email protected]>>
     > ---
     >   hw/i386/microvm-dt.c         | 2 +-
     >   hw/rtc/mc146818rtc.c         | 7 ++++---
     >   include/hw/rtc/mc146818rtc.h | 2 +-
     >   3 files changed, 6 insertions(+), 5 deletions(-)
     >
     > diff --git a/hw/i386/microvm-dt.c b/hw/i386/microvm-dt.c
     > index a5db9e4e5a..39fe425b26 100644
     > --- a/hw/i386/microvm-dt.c
     > +++ b/hw/i386/microvm-dt.c
     > @@ -209,7 +209,7 @@ static void dt_add_isa_rtc(MicrovmMachineState *mms,
    ISADevice *dev)
     >   {
     >       const char compat[] = "motorola,mc146818";
     >       uint32_t irq = object_property_get_uint(OBJECT(dev), "irq", NULL);
     > -    hwaddr base = RTC_ISA_BASE;
     > +    hwaddr base = object_property_get_int(OBJECT(dev), "iobase", NULL);

    Same comment here re: &error_abort.

Ack.

     >       hwaddr size = 8;
     >       char *nodename;
     >
     > diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c
     > index f235c2ddbe..484f91b6f8 100644
     > --- a/hw/rtc/mc146818rtc.c
     > +++ b/hw/rtc/mc146818rtc.c
     > @@ -941,7 +941,7 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)
     >       qemu_register_suspend_notifier(&s->suspend_notifier);
     >
     >       memory_region_init_io(&s->io, OBJECT(s), &cmos_ops, s, "rtc", 2);
     > -    isa_register_ioport(isadev, &s->io, RTC_ISA_BASE);
     > +    isa_register_ioport(isadev, &s->io, s->io_base);
     >
     >       /* register rtc 0x70 port for coalesced_pio */
     >       memory_region_set_flush_coalesced(&s->io);
     > @@ -950,7 +950,7 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)
     >       memory_region_add_subregion(&s->io, 0, &s->coalesced_io);
     >       memory_region_add_coalescing(&s->coalesced_io, 0, 1);
     >
     > -    qdev_set_legacy_instance_id(dev, RTC_ISA_BASE, 3);
     > +    qdev_set_legacy_instance_id(dev, s->io_base, 3);
     >
     >       object_property_add_tm(OBJECT(s), "date", rtc_get_date);
     >
     > @@ -983,6 +983,7 @@ ISADevice *mc146818_rtc_init(ISABus *bus, int base_year,
    qemu_irq intercept_irq)
     >
     >   static Property mc146818rtc_properties[] = {
     >       DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980),
     > +    DEFINE_PROP_UINT32("iobase", RTCState, io_base, 0x70),

    I think this should be RTC_ISA_BASE?

     >       DEFINE_PROP_UINT8("irq", RTCState, isairq, RTC_ISA_IRQ),
     >       DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
     >                                  lost_tick_policy, LOST_TICK_POLICY_DISCARD),
     > @@ -1028,7 +1029,7 @@ static void rtc_build_aml(ISADevice *isadev, Aml *scope)
     >        * does, even though qemu only responds to the first two ports.
     >        */
     >       crs = aml_resource_template();
     > -    aml_append(crs, aml_io(AML_DECODE16, RTC_ISA_BASE, RTC_ISA_BASE,
     > +    aml_append(crs, aml_io(AML_DECODE16, s->io_base, s->io_base,
     >                              0x01, 0x08));
     >       aml_append(crs, aml_irq_no_flags(s->isairq));
     >
     > diff --git a/include/hw/rtc/mc146818rtc.h b/include/hw/rtc/mc146818rtc.h
     > index 33d85753c0..1f7942a9f8 100644
     > --- a/include/hw/rtc/mc146818rtc.h
     > +++ b/include/hw/rtc/mc146818rtc.h
     > @@ -26,6 +26,7 @@ struct RTCState {
     >       uint8_t cmos_data[128];
     >       uint8_t cmos_index;
     >       uint8_t isairq;
     > +    uint32_t io_base;
     >       int32_t base_year;
     >       uint64_t base_rtc;
     >       uint64_t last_update;
     > @@ -49,7 +50,6 @@ struct RTCState {
     >   };
     >
     >   #define RTC_ISA_IRQ 8
     > -#define RTC_ISA_BASE 0x70
Quoted 6 lines
Quoted 4 lines

... and so you'll need to keep this.

My intention was indeed to remove it since it is now redundant. Keeping the constant public has the risk of using it instead of the user-configurable QOM property which could cause bugs.

True, that's not a completely unreasonable argument. In that case how about moving the RTC_ISA_BASE define to somewhere around the top of hw/rtc/mc146818rtc.c so that the origin of the 0x70 address is preserved?

Okay, I'll move it there.

Quoted 18 lines
Quoted 6 lines

>   ISADevice *mc146818_rtc_init(ISABus *bus, int base_year, >                                qemu_irq intercept_irq);

Otherwise:

Quoted 7 lines

<mailto:[email protected]>>

ATB,

Mark.

ATB,

Mark.