Skip to contentSkip to conversation

i40e: Fix interface init with MSI interrupts (no MSI-X)

PATCH In review Michal Maloszewski 2 participants 2 messages May 20, 2022 – Jul 20, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 i40e: Fix interface init with MSI interrupts (no MSI-X)

Fix the inability to bring an interface up on a setup with only MSI interrupts enabled (no MSI-X).
Solution is to add a default number of QPs = 1. This is enough, since without MSI-X support driver enables only a basic feature set.

Fixes bc6d33c8d93f ("i40e: Fix the number of queues available to be mapped for use")

---
v2: Moving the comment in right place

---
 drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/net/ethernet/intel/i40e/i40e_main.c +4 -0
index 8572993972ef..6c41ee966570 100644
@@ -1835,11 +1835,15 @@ static void i40e_vsi_setup_queue_map(struct i40e_vsi *vsi,
 		 * non-zero req_queue_pairs says that user requested a new
 		 * queue count via ethtool's set_channels, so use this
 		 * value for queues distribution across traffic classes
+		 * We need at least one queue pair for the interface
+		 * to be usable as we see in else statement.
 		 */
 		if (vsi->req_queue_pairs > 0)
 			vsi->num_queue_pairs = vsi->req_queue_pairs;
 		else if (pf->flags & I40E_FLAG_MSIX_ENABLED)
 			vsi->num_queue_pairs = pf->num_lan_msix;
+		else
+			vsi->num_queue_pairs = 1;
 	}
 
 	/* Number of queues per enabled TC */
Signature · 1 line
2.27.0
Tested-by on v2 1/1
#1 lore raw
Quoted 16 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Michal Maloszewski
Sent: Friday, May 20, 2022 11:07 AM
To: [email protected]
Cc: Maloszewski, Michal <[email protected]>; Lukwinski, Dawid <[email protected]>
Subject: [Intel-wired-lan] [PATCH net v2] i40e: Fix interface init with MSI interrupts (no MSI-X)

Fix the inability to bring an interface up on a setup with only MSI interrupts enabled (no MSI-X).
Solution is to add a default number of QPs = 1. This is enough, since without MSI-X support driver enables only a basic feature set.

Fixes bc6d33c8d93f ("i40e: Fix the number of queues available to be mapped
Quoted 8 lines

for use")

---
v2: Moving the comment in right place
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++++

1 file changed, 4 insertions(+)

_______________________________________________
Intel-wired-lan mailing list
[email protected]
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan