Skip to contentSkip to conversation

drm/rockchip: remove vop_writel

PATCH Applied Tom Rix 2 participants 2 messages May 21, 2022 – Sep 15, 2022

Subsystems (4)
lore
Share & tools
lore

Tom Rix

author
#0 lore raw

PATCH 1/1 drm/rockchip: remove vop_writel

cppcheck reports
[drivers/gpu/drm/rockchip/rockchip_drm_vop.c:186]: (style) The function 'vop_writel' is never used.

vop_writel is static function that is not used, so remove it.

---
 drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 ------
 1 file changed, 6 deletions(-)
drivers/gpu/drm/rockchip/rockchip_drm_vop.c +0 -6
index 74562d40f639..d1026e78feff 100644
@@ -183,12 +183,6 @@ struct vop {
 	struct vop_win win[];
 };
 
-static inline void vop_writel(struct vop *vop, uint32_t offset, uint32_t v)
-{
-	writel(v, vop->regs + offset);
-	vop->regsbak[offset >> 2] = v;
-}
-
 static inline uint32_t vop_readl(struct vop *vop, uint32_t offset)
 {
 	return readl(vop->regs + offset);
Signature · 1 line
2.27.0
maintainer Applied
#1 lore raw
Quoted 4 lines · Tom Rix

cppcheck reports
[drivers/gpu/drm/rockchip/rockchip_drm_vop.c:186]: (style) The function 'vop_writel' is never used.

vop_writel is static function that is not used, so remove it.

Applied, thanks!

[1/1] drm/rockchip: remove vop_writel

      commit: 98a65e6d498c46b0beec7a40aac4b3e404642993

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>