xen: remove setting of 'transp' parameter
PATCH 1/1 xen: remove setting of 'transp' parameter
cppcheck reports
[drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.
The value parameter 'transp' is not used, so setting it can be removed.
--- drivers/video/fbdev/xen-fbfront.c | 1 - 1 file changed, 1 deletion(-)
drivers/video/fbdev/xen-fbfront.c +0 -1
@@ -223,7 +223,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green, red =CNVT_TOHW (red, info->var.red.length); green =CNVT_TOHW (green, info->var.green.length); blue =CNVT_TOHW (blue, info->var.blue.length); - transp =CNVT_TOHW (transp, info->var.transp.length);#undef CNVT_TOHW v = (red << info->var.red.offset) |
Signature · 1 line
2.27.0
Quoted 6 lines · Tom Rix
cppcheck reports
[drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.The value parameter 'transp' is not used, so setting it can be removed.
Signed-off-by Tom Rix <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoted 6 lines · Tom Rix
cppcheck reports
[drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.The value parameter 'transp' is not used, so setting it can be removed.
Signed-off-by Tom Rix <[email protected]>
Juergen
Quoted 6 lines · Tom Rix
cppcheck reports
[drivers/video/fbdev/xen-fbfront.c:226]: (style) Assignment of function parameter has no effect outside the function.The value parameter 'transp' is not used, so setting it can be removed.
Signed-off-by Tom Rix <[email protected]>
applied to the fbdev tree.
Thanks!
Helge
Quoted 16 lines
--- drivers/video/fbdev/xen-fbfront.c | 1 - 1 file changed, 1 deletion(-)drivers/video/fbdev/xen-fbfront.c +0
-1@@ -223,7 +223,6 @@ static int xenfb_setcolreg(unsigned regno, unsigned red, unsigned green, red =CNVT_TOHW (red, info->var.red.length); green =CNVT_TOHW (green, info->var.green.length); blue =CNVT_TOHW (blue, info->var.blue.length); - transp =CNVT_TOHW (transp, info->var.transp.length);#undef CNVT_TOHW v = (red << info->var.red.offset) |