Skip to contentSkip to conversation

Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")

PATCH Applied [email protected] 4 participants 7 messages May 23, 2022 – Jun 10, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v3 cover Delete MT8192 msdc gate (was "clk: mediatek: Delete MT8192 msdc gate")

From: Matthias Brugger <[email protected]>

The mt8192-msdc clock is only a single clock gate. This gate is accessed from the mmc driver directly. With
4a1d1379ebf6 ("arm64: dts: mt8192: Add mmc device nodes") the only consumer of this binding was deleted. Delete the binding decription and the clock driver bound to it.

Changes in v3:
- Update commit message to explain better why we do ABI breakage here
- add Reviewed-by tag

Changes in v2:
- Delete compatible in binding descprition as well
- Add RvB tags
- add Reviewed-by tag

Matthias Brugger (2):
dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
clk: mediatek: Delete MT8192 msdc gate

 .../arm/mediatek/mediatek,mt8192-clock.yaml   |  8 -------
 drivers/clk/mediatek/clk-mt8192-msdc.c        | 21 -------------------
 2 files changed, 29 deletions(-)
Signature · 1 line
2.36.0
#1 lore raw

PATCH v3 1/2 dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

From: Matthias Brugger <[email protected]>

The code controlling msdc clock gate was moved inthe the consumer, the MMC driver. This node did never represent a working implementation of any peripheral. It was just a lonely clock gate that wasn't used. Delete the binding description of this node.

---

Changes in v3:
- Update commit message to explain better why we do ABI breakage here

Changes in v2:
- Delete compatible in binding descprition as well
- Add RvB tags

 .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
 1 file changed, 8 deletions(-)
Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml +0 -8
index c8c67c033f8c..b57cc2e69efb 100644
@@ -24,7 +24,6 @@ properties:
           - mediatek,mt8192-imp_iic_wrap_w
           - mediatek,mt8192-imp_iic_wrap_n
           - mediatek,mt8192-msdc_top
-          - mediatek,mt8192-msdc
           - mediatek,mt8192-mfgcfg
           - mediatek,mt8192-imgsys
           - mediatek,mt8192-imgsys2
@@ -107,13 +106,6 @@ examples:
         #clock-cells = <1>;
     };
 
-  - |
-    msdc: clock-controller@11f60000 {
-        compatible = "mediatek,mt8192-msdc";
-        reg = <0x11f60000 0x1000>;
-        #clock-cells = <1>;
-    };
-
   - |
     mfgcfg: clock-controller@13fbf000 {
         compatible = "mediatek,mt8192-mfgcfg";
Signature · 1 line
2.36.0
maintainer Acked-by on v3 1/2
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

Quoted 16 lines · On Mon, 23 May 2022 12:23:38 +0200, [email protected] wrote:

From: Matthias Brugger <[email protected]>

The code controlling msdc clock gate was moved inthe the consumer, the MMC driver. This node did never represent a working implementation of any peripheral. It was just a lonely clock gate that wasn't used. Delete the binding description of this node.

---

Changes in v3:
- Update commit message to explain better why we do ABI breakage here

Quoted 7 lines

Changes in v2:
- Delete compatible in binding descprition as well
- Add RvB tags

 .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
 1 file changed, 8 deletions(-)
maintainer Applied
#3 lore raw

Re: [PATCH v3 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock

In reply to [email protected]

Quoting [email protected] (2022-05-23 03:23:38)

Quoted 7 lines

From: Matthias Brugger <[email protected]>

The code controlling msdc clock gate was moved inthe the consumer, the MMC driver. This node did never represent a working implementation of any peripheral. It was just a lonely clock gate that wasn't used. Delete the binding description of this node.

Quoted 5 lines

---

Applied to clk-next

#4 lore raw

PATCH v3 2/2 clk: mediatek: Delete MT8192 msdc gate

In reply to [email protected]

From: Matthias Brugger <[email protected]>

The msdc gate is part of the MMC driver. Delete the not used code.

---

Changes in v3:
- add Reviewed-by tag

Changes in v2:
- add Reviewed-by tag

 drivers/clk/mediatek/clk-mt8192-msdc.c | 21 ---------------------
 1 file changed, 21 deletions(-)
drivers/clk/mediatek/clk-mt8192-msdc.c +0 -21
index 87c3b79b79cf..635f7a0b629a 100644
@@ -12,28 +12,15 @@
 
 #include <dt-bindings/clock/mt8192-clk.h>
 
-static const struct mtk_gate_regs msdc_cg_regs = {
-	.set_ofs = 0xb4,
-	.clr_ofs = 0xb4,
-	.sta_ofs = 0xb4,
-};
-
 static const struct mtk_gate_regs msdc_top_cg_regs = {
 	.set_ofs = 0x0,
 	.clr_ofs = 0x0,
 	.sta_ofs = 0x0,
 };
 
-#define GATE_MSDC(_id, _name, _parent, _shift)	\
-	GATE_MTK(_id, _name, _parent, &msdc_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv)
-
 #define GATE_MSDC_TOP(_id, _name, _parent, _shift)	\
 	GATE_MTK(_id, _name, _parent, &msdc_top_cg_regs, _shift, &mtk_clk_gate_ops_no_setclr_inv)
 
-static const struct mtk_gate msdc_clks[] = {
-	GATE_MSDC(CLK_MSDC_AXI_WRAP, "msdc_axi_wrap", "axi_sel", 22),
-};
-
 static const struct mtk_gate msdc_top_clks[] = {
 	GATE_MSDC_TOP(CLK_MSDC_TOP_AES_0P, "msdc_top_aes_0p", "aes_msdcfde_sel", 0),
 	GATE_MSDC_TOP(CLK_MSDC_TOP_SRC_0P, "msdc_top_src_0p", "infra_msdc0_src", 1),
@@ -52,11 +39,6 @@ static const struct mtk_gate msdc_top_clks[] = {
 	GATE_MSDC_TOP(CLK_MSDC_TOP_AHB2AXI_BRG_AXI, "msdc_top_ahb2axi_brg_axi", "axi_sel", 14),
 };
 
-static const struct mtk_clk_desc msdc_desc = {
-	.clks = msdc_clks,
-	.num_clks = ARRAY_SIZE(msdc_clks),
-};
-
 static const struct mtk_clk_desc msdc_top_desc = {
 	.clks = msdc_top_clks,
 	.num_clks = ARRAY_SIZE(msdc_top_clks),
@@ -64,9 +46,6 @@ static const struct mtk_clk_desc msdc_top_desc = {
 
 static const struct of_device_id of_match_clk_mt8192_msdc[] = {
 	{
-		.compatible = "mediatek,mt8192-msdc",
-		.data = &msdc_desc,
-	}, {
 		.compatible = "mediatek,mt8192-msdc_top",
 		.data = &msdc_top_desc,
 	}, {
Signature · 1 line
2.36.0
Reviewed-by on the v3 series
#6 lore raw
In reply to [email protected]
Quoted 14 lines · On Mon, May 23, 2022 at 7:19 PM <[email protected]> wrote:

From: Matthias Brugger <[email protected]>

The mt8192-msdc clock is only a single clock gate. This gate is accessed from the mmc driver directly. With
4a1d1379ebf6 ("arm64: dts: mt8192: Add mmc device nodes") the only consumer of this binding was deleted. Delete the binding decription and the clock driver bound to it.

Changes in v3:
- Update commit message to explain better why we do ABI breakage here
- add Reviewed-by tag

Quoted 8 lines

Changes in v2:
- Delete compatible in binding descprition as well
- Add RvB tags
- add Reviewed-by tag

Matthias Brugger (2):
dt-bindings: ARM: Mediatek: Remove msdc binding of MT8192 clock
clk: mediatek: Delete MT8192 msdc gate

Whole series is