Skip to contentSkip to conversation

power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe

PATCH In review Miaoqian Lin 3 participants 3 messages May 23, 2022 – Jun 9, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe

of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot")
---
 drivers/power/reset/arm-versatile-reboot.c | 1 +
 1 file changed, 1 insertion(+)
drivers/power/reset/arm-versatile-reboot.c +1 -0
index 08d0a07b58ef..c7624d7611a7 100644
@@ -146,6 +146,7 @@ static int __init versatile_reboot_probe(void)
 	versatile_reboot_type = (enum versatile_reboot)reboot_id->data;
 
 	syscon_regmap = syscon_node_to_regmap(np);
+	of_node_put(np);
 	if (IS_ERR(syscon_regmap))
 		return PTR_ERR(syscon_regmap);
 
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Miaoqian Lin

of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot")

Yours,
Linus Walleij

#2 lore raw

Hi,

Quoted 10 lines · Linus Walleij
Quoted 6 lines · Miaoqian Lin

of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot")

Thanks, queued to power-supply's fixes branch.

-- Sebastian