power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe
PATCH 1/1 power/reset: arm-versatile: Fix refcount leak in versatile_reboot_probe
of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.
Fixes 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/power/reset/arm-versatile-reboot.c | 1 + 1 file changed, 1 insertion(+)
drivers/power/reset/arm-versatile-reboot.c +1 -0
@@ -146,6 +146,7 @@ static int __init versatile_reboot_probe(void) versatile_reboot_type = (enum versatile_reboot )reboot_id->data; syscon_regmap =syscon_node_to_regmap (np); +of_node_put (np);if (IS_ERR (syscon_regmap))return PTR_ERR (syscon_regmap);
Signature · 1 line
2.25.1
Quoted 6 lines · Miaoqian Lin
of_find_matching_node_and_match()returns a node pointer with refcount incremented, we should useof_node_put()on it when not need anymore. Add missingof_node_put()to avoid refcount leak.Fixes 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot")Signed-off-by Miaoqian Lin <[email protected]>
Reviewed-by Linus Walleij <[email protected]>
Yours,
Linus Walleij
Hi,
Quoted 10 lines · Linus Walleij
Quoted 6 lines · Miaoqian Lin
of_find_matching_node_and_match()returns a node pointer with refcount incremented, we should useof_node_put()on it when not need anymore. Add missingof_node_put()to avoid refcount leak.Fixes 0e545f57b708 ("power: reset: driver for the Versatile syscon reboot")Signed-off-by Miaoqian Lin <[email protected]>Reviewed-by Linus Walleij <[email protected]>
Thanks, queued to power-supply's fixes branch.
-- Sebastian