Skip to contentSkip to conversation

soc: integrator: Fix refcount leak in integrator_soc_init

PATCH In review Miaoqian Lin 2 participants 2 messages May 23, 2022 – Jun 3, 2022 Arm integrator, versatile and realview support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 soc: integrator: Fix refcount leak in integrator_soc_init

of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes f956a785a282 ("soc: move SoC driver for the ARM Integrator")
---
 drivers/soc/versatile/soc-integrator.c | 1 +
 1 file changed, 1 insertion(+)
drivers/soc/versatile/soc-integrator.c +1 -0
index bab4ad87aa75..d5099a3386b4 100644
@@ -113,6 +113,7 @@ static int __init integrator_soc_init(void)
 		return -ENODEV;
 
 	syscon_regmap = syscon_node_to_regmap(np);
+	of_node_put(np);
 	if (IS_ERR(syscon_regmap))
 		return PTR_ERR(syscon_regmap);
 
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · Miaoqian Lin

of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes f956a785a282 ("soc: move SoC driver for the ARM Integrator")

Patch applied!

Yours,
Linus Walleij