Skip to contentSkip to conversation

bus: arm-integrator-lm: Fix refcount leak in integrator_ap_lm_probe

PATCH In review Miaoqian Lin 2 participants 2 messages May 23, 2022 – Jun 3, 2022 Arm integrator, versatile and realview support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 bus: arm-integrator-lm: Fix refcount leak in integrator_ap_lm_probe

of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes ccea5e8a5918 ("bus: Add driver for Integrator/AP logic modules")
---
 drivers/bus/arm-integrator-lm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/bus/arm-integrator-lm.c +1 -0
index 2344d560b144..ab5fad8aaa99 100644
@@ -85,6 +85,7 @@ static int integrator_ap_lm_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 	map = syscon_node_to_regmap(syscon);
+	of_node_put(syscon);
 	if (IS_ERR(map)) {
 		dev_err(dev,
 			"could not find Integrator/AP system controller\n");
Signature · 1 line
2.25.1
#1 lore raw
Quoted 6 lines · Miaoqian Lin

of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak.

Fixes ccea5e8a5918 ("bus: Add driver for Integrator/AP logic modules")

Patch applied!

Yours,
Linus Walleij