dt-bindings: input: matrix-keymap: Add common 'linux,no-autorepeat' property
Subsystems (5)
Rob Herring
maintainerPATCH 1/1 dt-bindings: input: matrix-keymap: Add common 'linux,no-autorepeat' property
'linux,no-autorepeat' is a common property used in multiple bindings, but doesn't have a common type definition nor description. Add a common definition and drop the now redundant description from holtek,ht16k33.yaml.
--- .../devicetree/bindings/auxdisplay/holtek,ht16k33.yaml | 3 +-- Documentation/devicetree/bindings/input/matrix-keymap.yaml | 4 ++++ 2 files changed, 5 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/auxdisplay/holtek,ht16k33.yaml +1 -2
@@ -39,8 +39,7 @@ properties: linux,keymap: true - linux,no-autorepeat: - description: Disable keyrepeat + linux,no-autorepeat: true default-brightness-level: minimum: 1
Documentation/devicetree/bindings/input/matrix-keymap.yaml +4 -0
@@ -27,6 +27,10 @@ properties: column and linux key-code. The 32-bit big endian cell is packed as: row << 24 | column << 16 | key-code + linux,no-autorepeat: + type: boolean + description: Disable keyrepeat + keypad,num-rows: $ref: /schemas/types.yaml#/definitions/uint32 description: Number of row lines connected to the keypad controller.
Signature · 1 line
2.34.1
Dmitry Torokhov
maintainerQuoted 4 lines · Rob Herring
'linux,no-autorepeat' is a common property used in multiple bindings, but doesn't have a common type definition nor description. Add a common definition and drop the now redundant description from holtek,ht16k33.yaml.
We have "autorepeat" in the common input binding description, should we not promote it over "no-autorepeat"?
Thanks.
Signature · 1 line
Dmitry
Rob Herring
maintainerQuoted 8 lines · Dmitry Torokhov
Quoted 4 lines · Rob Herring
'linux,no-autorepeat' is a common property used in multiple bindings, but doesn't have a common type definition nor description. Add a common definition and drop the now redundant description from holtek,ht16k33.yaml.
We have "autorepeat" in the common input binding description, should we not promote it over "no-autorepeat"?
We're kind of stuck with it I think. We can't just deprecate one and switch existing users as what would neither property present mean?
Hopefully, documented in input.yaml vs. matrix-keypad.yaml is enough to say which one is preferred for new users.
Rob
Dmitry Torokhov
maintainerQuoted 7 lines · Rob Herring
Quoted 6 lines · Dmitry Torokhov
Quoted 4 lines · Rob Herring
'linux,no-autorepeat' is a common property used in multiple bindings, but doesn't have a common type definition nor description. Add a common definition and drop the now redundant description from holtek,ht16k33.yaml.
Quoted 5 lines
Quoted 2 lines
We have "autorepeat" in the common input binding description, should we not promote it over "no-autorepeat"?
We're kind of stuck with it I think. We can't just deprecate one and switch existing users as what would neither property present mean?
I agree, we should not change existng bindings.
Quoted 3 lines
Hopefully, documented in
input.yamlvs.matrix-keypad.yamlis enough to say which one is preferred for new users.
So this is what I have issue with, as I think it will introduce
confusion: we have drivers/input/matrix-keymap.c and corresponding binding Documentation/devicetree/bindings/input/matrix-keymap.yaml that deals with parsing keymap-related properties for various matrix keypads. It does not specify autorepeat handling one way or another. Then we have drivers/input/keyboard/matrix_keypad.c that is one implementation of matrix keypads, and it does have linux,no-autorepeat, but it does not mean that other devices resembling matrix keypad are forced to use linux,no-autorepeat. And that is why I think putting this property into the generic binding Documentation/devicetree/bindings/input/matrix-keymap.yaml is not a good idea.
Thanks.
Signature · 1 line
Dmitry
Rob Herring
maintainerQuoted 20 lines · Dmitry Torokhov
Quoted 7 lines · Rob Herring
Quoted 6 lines · Dmitry Torokhov
Quoted 4 lines · Rob Herring
'linux,no-autorepeat' is a common property used in multiple bindings, but doesn't have a common type definition nor description. Add a common definition and drop the now redundant description from holtek,ht16k33.yaml.
Quoted 5 lines
Quoted 2 lines
We have "autorepeat" in the common input binding description, should we not promote it over "no-autorepeat"?
We're kind of stuck with it I think. We can't just deprecate one and switch existing users as what would neither property present mean?
I agree, we should not change existng bindings.
Quoted 3 lines
Hopefully, documented in
input.yamlvs.matrix-keypad.yamlis enough to say which one is preferred for new users.
Quoted 12 lines
So this is what I have issue with, as I think it will introduce
confusion: we havedrivers/input/matrix-keymap.cand corresponding bindingDocumentation/devicetree/bindings/input/matrix-keymap.yamlthat deals with parsing keymap-related properties for various matrix keypads. It does not specify autorepeat handling one way or another. Then we havedrivers/input/keyboard/matrix_keypad.cthat is one implementation of matrix keypads, and it does have linux,no-autorepeat, but it does not mean that other devices resembling matrix keypad are forced to use linux,no-autorepeat. And that is why I think putting this property into the generic bindingDocumentation/devicetree/bindings/input/matrix-keymap.yamlis not a good idea.
You are right. As it looks like there are only 3 users of linux,no-autorepeat, we can live with multiple definitions. Looks like we have a variety of other autorepeat properties too.
Rob