Skip to contentSkip to conversation

dt-bindings: timestamp: Correct id path

PATCH In review Dipen Patel 4 participants 7 messages May 23, 2022 – Jun 2, 2022

Subsystems (3)
lore
Share & tools
lore

Dipen Patel

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: timestamp: Correct id path

During the repository renaming from hte to timestamp, $id path was not updated accordingly. This patch corrects $id path.

Fixes af583852d2ef ("dt-bindings: Renamed hte directory to timestamp")
---
 .../bindings/timestamp/hardware-timestamps-common.yaml          | 2 +-
 Documentation/devicetree/bindings/timestamp/hte-consumer.yaml   | 2 +-
 .../devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml +1 -1
index 4c25ba248a72..fd6a7b51f571 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/hardware-timestamps-common.yaml#
+$id: http://devicetree.org/schemas/timestamp/hardware-timestamps-common.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Hardware timestamp providers
Documentation/devicetree/bindings/timestamp/hte-consumer.yaml +1 -1
index 68d764ac040a..6456515c3d26 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/hte-consumer.yaml#
+$id: http://devicetree.org/schemas/timestamp/hte-consumer.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: HTE Consumer Device Tree Bindings
Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml +1 -1
index 69e8402d95e5..c31e207d1652 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/nvidia,tegra194-hte.yaml#
+$id: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Tegra194 on chip generic hardware timestamping engine (HTE)

base-commit: cc63e8e92cb872081f249ea16e6c460642f3e4fb

Signature · 1 line
2.17.1
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Dipen Patel

During the repository renaming from hte to timestamp, $id path was not updated accordingly. This patch corrects $id path.

Fixes af583852d2ef ("dt-bindings: Renamed hte directory to timestamp")
---
 .../bindings/timestamp/hardware-timestamps-common.yaml          | 2 +-
 Documentation/devicetree/bindings/timestamp/hte-consumer.yaml   | 2 +-
 .../devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
#2 lore raw
In reply to Dipen Patel
Quoted 11 lines · Dipen Patel

During the repository renaming from hte to timestamp, $id path was not updated accordingly. This patch corrects $id path.

Fixes af583852d2ef ("dt-bindings: Renamed hte directory to timestamp")
---
 .../bindings/timestamp/hardware-timestamps-common.yaml          | 2 +-
 Documentation/devicetree/bindings/timestamp/hte-consumer.yaml   | 2 +-
 .../devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Ping. Still failing in linux-next.

Quoted 45 lines
Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml +1 -1
index 4c25ba248a72..fd6a7b51f571 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/hardware-timestamps-common.yaml#
+$id: http://devicetree.org/schemas/timestamp/hardware-timestamps-common.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Hardware timestamp providers
Documentation/devicetree/bindings/timestamp/hte-consumer.yaml +1 -1
index 68d764ac040a..6456515c3d26 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/hte-consumer.yaml#
+$id: http://devicetree.org/schemas/timestamp/hte-consumer.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: HTE Consumer Device Tree Bindings
Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml +1 -1
index 69e8402d95e5..c31e207d1652 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/nvidia,tegra194-hte.yaml#
+$id: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Tegra194 on chip generic hardware timestamping engine (HTE)

base-commit: cc63e8e92cb872081f249ea16e6c460642f3e4fb --
2.17.1

author maintainer
#3 lore raw

Hi Rob,

What is the failing signature and command? I tried below commands on 31st May

linux-next and I can not see any failure.

make O=./output/ DT_CHECKER_FLAGS=-m dt_binding_check
  DTC     Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb

make O=./output/ dt_binding_check
  LINT    Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dts DTEX    Documentation/devicetree/bindings/timestamp/hte-consumer.example.dts DTEX    Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dts CHKDT   Documentation/devicetree/bindings/processed-schema.json
  DTC     Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb

make O=./output dtbs_check

Best Regards,

Dipen Patel

Quoted 57 lines · Rob Herring
Quoted 10 lines · Dipen Patel

During the repository renaming from hte to timestamp, $id path was not updated accordingly. This patch corrects $id path.

Fixes af583852d2ef ("dt-bindings: Renamed hte directory to timestamp")
---
 .../bindings/timestamp/hardware-timestamps-common.yaml          | 2 +-
 Documentation/devicetree/bindings/timestamp/hte-consumer.yaml   | 2 +-
 .../devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Ping. Still failing in linux-next.

Quoted 44 lines
Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml +1 -1
index 4c25ba248a72..fd6a7b51f571 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/hardware-timestamps-common.yaml#
+$id: http://devicetree.org/schemas/timestamp/hardware-timestamps-common.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Hardware timestamp providers
Documentation/devicetree/bindings/timestamp/hte-consumer.yaml +1 -1
index 68d764ac040a..6456515c3d26 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/hte-consumer.yaml#
+$id: http://devicetree.org/schemas/timestamp/hte-consumer.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: HTE Consumer Device Tree Bindings
Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml +1 -1
index 69e8402d95e5..c31e207d1652 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/nvidia,tegra194-hte.yaml#
+$id: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Tegra194 on chip generic hardware timestamping engine (HTE)

base-commit: cc63e8e92cb872081f249ea16e6c460642f3e4fb --
2.17.1

maintainer
#4 lore raw
Quoted 3 lines · Dipen Patel

Hi Rob,

What is the failing signature and command? I tried below commands on 31st May

Well, you fixed it in your patch. I'd hope you'd know.

Quoted 2 lines

linux-next and I can not see any failure.

You confirm your fix is there?

Quoted 8 lines

make O=./output/ DT_CHECKER_FLAGS=-m dt_binding_check
  DTC     Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb

Had you already run dt_binding_check?

Quoted 12 lines

make O=./output/ dt_binding_check
  LINT    Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dts DTEX    Documentation/devicetree/bindings/timestamp/hte-consumer.example.dts DTEX    Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dts CHKDT   Documentation/devicetree/bindings/processed-schema.json
  DTC     Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb

I don't see 'SCHEMA' target here. It should have run since LINT and CHKDT did.

Do a 'rm output/Documentation/devicetree/bindings/processed-schema.json' first.

Rob

Quoted 67 lines

make O=./output dtbs_check

Best Regards,

Dipen Patel

Quoted 57 lines · Rob Herring
Quoted 10 lines · Dipen Patel

During the repository renaming from hte to timestamp, $id path was not updated accordingly. This patch corrects $id path.

Fixes af583852d2ef ("dt-bindings: Renamed hte directory to timestamp")
---
 .../bindings/timestamp/hardware-timestamps-common.yaml          | 2 +-
 Documentation/devicetree/bindings/timestamp/hte-consumer.yaml   | 2 +-
 .../devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Ping. Still failing in linux-next.

Quoted 44 lines
Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml +1 -1
index 4c25ba248a72..fd6a7b51f571 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/hardware-timestamps-common.yaml#
+$id: http://devicetree.org/schemas/timestamp/hardware-timestamps-common.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Hardware timestamp providers
Documentation/devicetree/bindings/timestamp/hte-consumer.yaml +1 -1
index 68d764ac040a..6456515c3d26 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/hte-consumer.yaml#
+$id: http://devicetree.org/schemas/timestamp/hte-consumer.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: HTE Consumer Device Tree Bindings
Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml +1 -1
index 69e8402d95e5..c31e207d1652 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/nvidia,tegra194-hte.yaml#
+$id: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Tegra194 on chip generic hardware timestamping engine (HTE)

base-commit: cc63e8e92cb872081f249ea16e6c460642f3e4fb --
2.17.1

author maintainer
#5 lore raw

Hi Rob,

The fix is not yet merged in linux-next, I assumed you applied fix on top of linux-next and still it failed.

In below snippets, I synced linux-next and applied the fix before running dt_binding_check and it did

not report any errors.

Best Regards,

Dipen Patel

Quoted 103 lines · Rob Herring
Quoted 3 lines · Dipen Patel

Hi Rob,

What is the failing signature and command? I tried below commands on 31st May

Well, you fixed it in your patch. I'd hope you'd know.

Quoted 1 line

linux-next and I can not see any failure.

You confirm your fix is there?

Quoted 7 lines

make O=./output/ DT_CHECKER_FLAGS=-m dt_binding_check
  DTC     Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb

Had you already run dt_binding_check?

Quoted 11 lines

make O=./output/ dt_binding_check
  LINT    Documentation/devicetree/bindings
  DTEX    Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dts DTEX    Documentation/devicetree/bindings/timestamp/hte-consumer.example.dts DTEX    Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dts CHKDT   Documentation/devicetree/bindings/processed-schema.json
  DTC     Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.example.dtb CHECK   Documentation/devicetree/bindings/timestamp/hte-consumer.example.dtb DTC     Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.example.dtb

I don't see 'SCHEMA' target here. It should have run since LINT and CHKDT did.

Do a 'rm output/Documentation/devicetree/bindings/processed-schema.json' first.

Rob

Quoted 66 lines

make O=./output dtbs_check

Best Regards,

Dipen Patel

Quoted 57 lines · Rob Herring
Quoted 10 lines · Dipen Patel

During the repository renaming from hte to timestamp, $id path was not updated accordingly. This patch corrects $id path.

Fixes af583852d2ef ("dt-bindings: Renamed hte directory to timestamp")
---
 .../bindings/timestamp/hardware-timestamps-common.yaml          | 2 +-
 Documentation/devicetree/bindings/timestamp/hte-consumer.yaml   | 2 +-
 .../devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Ping. Still failing in linux-next.

Quoted 44 lines
Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml +1 -1
index 4c25ba248a72..fd6a7b51f571 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/hardware-timestamps-common.yaml#
+$id: http://devicetree.org/schemas/timestamp/hardware-timestamps-common.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Hardware timestamp providers
Documentation/devicetree/bindings/timestamp/hte-consumer.yaml +1 -1
index 68d764ac040a..6456515c3d26 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/hte-consumer.yaml#
+$id: http://devicetree.org/schemas/timestamp/hte-consumer.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: HTE Consumer Device Tree Bindings
Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml +1 -1
index 69e8402d95e5..c31e207d1652 100644
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/hte/nvidia,tegra194-hte.yaml#
+$id: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Tegra194 on chip generic hardware timestamping engine (HTE)

base-commit: cc63e8e92cb872081f249ea16e6c460642f3e4fb --
2.17.1

#6 lore raw
In reply to Dipen Patel
Quoted 10 lines · Dipen Patel

During the repository renaming from hte to timestamp, $id path was not updated accordingly. This patch corrects $id path.

Fixes af583852d2ef ("dt-bindings: Renamed hte directory to timestamp")
---
 .../bindings/timestamp/hardware-timestamps-common.yaml          | 2 +-
 Documentation/devicetree/bindings/timestamp/hte-consumer.yaml   | 2 +-
 .../devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Sorry for the delay. I've applied this patch now and dt_binding_check now no longer shows any errors for these files.

Thanks,
Thierry