ARM: DTS: myir-x335x: Add GPIO aliases
PATCH 1/1 ARM: DTS: myir-x335x: Add GPIO aliases
For the correct work of GPIO driver, we need to define aliases. Let's add them to the devicetree.
--- arch/arm/dts/am335x-myirtech-myd.dts | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm/dts/am335x-myirtech-myd.dts +7 -0
@@ -6,6 +6,13 @@ #include <arm/am335x-myirtech-myd.dts> / { + aliases { + gpio0 = &gpio0; + gpio1 = &gpio1; + gpio2 = &gpio2; + gpio3 = &gpio3; + }; + chosen { environment { compatible = "barebox,environment";
Signature · 7 lines
2.32.0 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 13 lines · Alexander Shiyan
For the correct work of GPIO driver, we need to define aliases. Let's add them to the devicetree.
Signed-off-by Alexander Shiyan <[email protected]>--- arch/arm/dts/am335x-myirtech-myd.dts | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm/dts/am335x-myirtech-myd.dts +0
-0
arch/arm/dts/am335x-myirtech-myd.dts line 14
Quoted 9 lines
arch/arm/dts/am335x-myirtech-myd.dts +6
-0@@ -6,6 +6,13 @@ #include <arm/am335x-myirtech-myd.dts> / { + aliases { + gpio0 = &gpio0; + gpio1 = &gpio1; + gpio2 = &gpio2; + gpio3 = &gpio3; + };
Out of curiousity, are those aliases not defined in the "upstream" linux device-tree? If not, wouldn't it be better to defined it there?
Regards,
Marco
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
вт, 24 мая 2022 г. в 12:03, Marco Felsch <[email protected]>:
Quoted 3 lines · Alexander Shiyan
Quoted 2 lines
For the correct work of GPIO driver, we need to define aliases. Let's add them to the devicetree.
...
Quoted 9 lines
arch/arm/dts/am335x-myirtech-myd.dts line 14
Quoted 6 lines
arch/arm/dts/am335x-myirtech-myd.dts +6
-0+ aliases { + gpio0 = &gpio0; + gpio1 = &gpio1; + gpio2 = &gpio2; + gpio3 = &gpio3; + };Out of curiousity, are those aliases not defined in the "upstream" linux device-tree? If not, wouldn't it be better to defined it there?
Hello.
The linux gpio-omap driver does not use aliases, it would be hard for me to explain the need to make such changes to the linux dts tree :)
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Quoted 12 lines · Alexander Shiyan
вт, 24 мая 2022 г. в 12:03, Marco Felsch <[email protected]>:
Quoted 3 lines · Alexander Shiyan
Quoted 2 lines
For the correct work of GPIO driver, we need to define aliases. Let's add them to the devicetree.
...
Quoted 7 lines
Quoted 6 lines
arch/arm/dts/am335x-myirtech-myd.dts +6
-0+ aliases { + gpio0 = &gpio0; + gpio1 = &gpio1; + gpio2 = &gpio2; + gpio3 = &gpio3; + };
Quoted 7 lines
Quoted 2 lines
Out of curiousity, are those aliases not defined in the "upstream" linux device-tree? If not, wouldn't it be better to defined it there?
Hello.
The linux gpio-omap driver does not use aliases, it would be hard for me to explain the need to make such changes to the linux dts tree :)
Ah.. Thanks for the explanation, of course this would be a bit hard to explain. So everything fine from pov :)
Regards,
Marco
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Hi,
Quoted 13 lines · Alexander Shiyan
For the correct work of GPIO driver, we need to define aliases. Let's add them to the devicetree.
Signed-off-by Alexander Shiyan <[email protected]>--- arch/arm/dts/am335x-myirtech-myd.dts | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm/dts/am335x-myirtech-myd.dts +0
-0
arch/arm/dts/am335x-myirtech-myd.dts line 6
Quoted 1 line
arch/arm/dts/am335x-myirtech-myd.dts +0
-0@@ -6,6 +6,13 @@ #include <arm/am335x-myirtech-myd.dts>
Other boards do #include "am33xx.dtsi", which takes care of these aliases. It's probably better you include that too.
Cheers,
Ahmad
Quoted 12 lines
arch/arm/dts/am335x-myirtech-myd.dts +7
-0/ { + aliases { + gpio0 = &gpio0; + gpio1 = &gpio1; + gpio2 = &gpio2; + gpio3 = &gpio3; + }; + chosen { environment { compatible = "barebox,environment";
Signature · 9 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Quoted 11 lines · Ahmad Fatoum
Hi,
Quoted 8 lines · Alexander Shiyan
For the correct work of GPIO driver, we need to define aliases. Let's add them to the devicetree.
Signed-off-by Alexander Shiyan <[email protected]>--- arch/arm/dts/am335x-myirtech-myd.dts | 7 +++++++ 1 file changed, 7 insertions(+)
Quoted 9 lines
arch/arm/dts/am335x-myirtech-myd.dts line 6
Quoted 6 lines
arch/arm/dts/am335x-myirtech-myd.dts +0
-0@@ -6,6 +6,13 @@ #include <arm/am335x-myirtech-myd.dts>Other boards do #include "
am33xx.dtsi", which takes care of these aliases. It's probably better you include that too.
+1 :)
Regards,
Marco
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Hello.
вт, 24 мая 2022 г. в 15:28, Ahmad Fatoum <[email protected]>:
Quoted 3 lines · Alexander Shiyan
Quoted 2 lines
For the correct work of GPIO driver, we need to define aliases. Let's add them to the devicetree.
...
Quoted 9 lines
arch/arm/dts/am335x-myirtech-myd.dts line 6
Quoted 6 lines
arch/arm/dts/am335x-myirtech-myd.dts +0
-0@@ -6,6 +6,13 @@ #include <arm/am335x-myirtech-myd.dts>Other boards do #include "
am33xx.dtsi", which takes care of these aliases. It's probably better you include that too.
Including this file results in an error.
Changed to:
#include "am33xx.dtsi"
#include <arm/am335x-myirtech-myd.dts>
Output:
DTC arch/arm/dts/am335x-myirtech-myd.dtb
Error: /home/ARM/barebox/dts/src/arm/am335x-myirtech-myd.dts:6.1-9 syntax error FATAL ERROR: Unable to parse input tree
Most likely this is the result of double inclusion of the file arm/am33xx.dtsi, first time from "am33xx.dtsi" and second from arm/am335x-myirtech-myd.dts.
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Quoted 23 lines · Alexander Shiyan
Hello.
вт, 24 мая 2022 г. в 15:28, Ahmad Fatoum <[email protected]>:
Quoted 3 lines · Alexander Shiyan
Quoted 2 lines
For the correct work of GPIO driver, we need to define aliases. Let's add them to the devicetree.
...
Quoted 9 lines
arch/arm/dts/am335x-myirtech-myd.dts line 6
Quoted 6 lines
arch/arm/dts/am335x-myirtech-myd.dts +0
-0@@ -6,6 +6,13 @@ #include <arm/am335x-myirtech-myd.dts>Other boards do #include "
am33xx.dtsi", which takes care of these aliases. It's probably better you include that too.Including this file results in an error.
Changed to:
#include "am33xx.dtsi"
#include <arm/am335x-myirtech-myd.dts>
Quoted 7 lines
Output:
DTCarch/arm/dts/am335x-myirtech-myd.dtb
Error: /home/ARM/barebox/dts/src/arm/am335x-myirtech-myd.dts:6.1-9 syntax error FATAL ERROR: Unable to parse input treeMost likely this is the result of double inclusion of the file
arm/am33xx.dtsi, first time from "am33xx.dtsi" and second fromarm/am335x-myirtech-myd.dts.
Hi, you need to include if after the upstream DT. That's why it doesn't have a /dts-v1/;
Cheers,
Ahmad
Quoted 1 line
Signature · 9 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
ср, 25 мая 2022 г. в 11:16, Ahmad Fatoum <[email protected]>:
Quoted 27 lines · Alexander Shiyan
Quoted 26 lines
вт, 24 мая 2022 г. в 15:28, Ahmad Fatoum <[email protected]>:
Quoted 3 lines · Alexander Shiyan
Quoted 2 lines
For the correct work of GPIO driver, we need to define aliases. Let's add them to the devicetree.
...
Quoted 9 lines
arch/arm/dts/am335x-myirtech-myd.dts line 6
Quoted 6 lines
arch/arm/dts/am335x-myirtech-myd.dts +0
-0@@ -6,6 +6,13 @@ #include <arm/am335x-myirtech-myd.dts>Other boards do #include "
am33xx.dtsi", which takes care of these aliases. It's probably better you include that too.Including this file results in an error.
Changed to:
#include "am33xx.dtsi"
#include <arm/am335x-myirtech-myd.dts>Output:
DTCarch/arm/dts/am335x-myirtech-myd.dtb
Error: /home/ARM/barebox/dts/src/arm/am335x-myirtech-myd.dts:6.1-9 syntax error FATAL ERROR: Unable to parse input tree
Quoted 5 lines
Quoted 2 lines
Most likely this is the result of double inclusion of the file
arm/am33xx.dtsi, first time from "am33xx.dtsi" and second fromarm/am335x-myirtech-myd.dts.Hi, you need to include if after the upstream DT. That's why it doesn't have a /dts-v1/;
Yes, if "am33xx.dtsi" is after <arm/am335x-myirtech-myd.dts>, it compiles fine. But in this case, upstreaming <arm/am33xx.dtsi> (from local am33xx.dtsi) overwrites
any binding changes from the board file.
_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Ahmad Fatoum
Reviewed-byHello Alexander,
Quoted 10 lines · Alexander Shiyan
Quoted 5 lines
Quoted 2 lines
Most likely this is the result of double inclusion of the file
arm/am33xx.dtsi, first time from "am33xx.dtsi" and second fromarm/am335x-myirtech-myd.dts.Hi, you need to include if after the upstream DT. That's why it doesn't have a /dts-v1/;
Yes, if "
am33xx.dtsi" is after <arm/am335x-myirtech-myd.dts>, it compiles fine. But in this case, upstreaming <arm/am33xx.dtsi> (from localam33xx.dtsi) overwrites
any binding changes from the board file.
Argh. Other platforms (e.g. imx6q.dtsi) intentionally skip dts/ includes to avoid just that... One could remedy that at the cost of annoying out-of-tree users, but that's not something that you need to do IMO.
Cheers,
Ahmad
Quoted 1 line
Signature · 9 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Sascha Hauer
AppliedQuoted 7 lines · Alexander Shiyan
For the correct work of GPIO driver, we need to define aliases. Let's add them to the devicetree.
Signed-off-by Alexander Shiyan <[email protected]>--- arch/arm/dts/am335x-myirtech-myd.dts | 7 +++++++ 1 file changed, 7 insertions(+)
Applied, thanks
Sascha
Quoted 28 lines
arch/arm/dts/am335x-myirtech-myd.dts +7
-0@@ -6,6 +6,13 @@ #include <arm/am335x-myirtech-myd.dts> / { + aliases { + gpio0 = &gpio0; + gpio1 = &gpio1; + gpio2 = &gpio2; + gpio3 = &gpio3; + }; + chosen { environment { compatible = "barebox,environment";Signature · 7 lines
2.32.0 _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ barebox mailing list [email protected] http://lists.infradead.org/mailman/listinfo/barebox